Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Test Setup Failed
Pull Request — master (#2949)
by Bogdan
30:07 queued 01:43
created
src/routes/backpack/base.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@
 block discarded – undo
16 16
     'middleware' => config('backpack.base.web_middleware', 'web'),
17 17
     'prefix'     => config('backpack.base.route_prefix'),
18 18
 ],
19
-function () {
19
+function() {
20 20
     // if not otherwise configured, setup the auth routes
21 21
     if (config('backpack.base.setup_auth_routes')) {
22 22
         // Authentication Routes...
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/UpdateOperation.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
     {
42 42
         $this->crud->allowAccess('update');
43 43
 
44
-        $this->crud->operation('update', function () {
44
+        $this->crud->operation('update', function() {
45 45
             $this->crud->loadDefaultOperationSettingsFromConfig();
46 46
 
47 47
             if ($this->crud->getModel()->translationEnabled()) {
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
             $this->crud->setupDefaultSaveActions();
56 56
         });
57 57
 
58
-        $this->crud->operation(['list', 'show'], function () {
58
+        $this->crud->operation(['list', 'show'], function() {
59 59
             $this->crud->addButton('line', 'update', 'view', 'crud::buttons.update', 'end');
60 60
         });
61 61
     }
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/CreateOperation.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -41,12 +41,12 @@
 block discarded – undo
41 41
     {
42 42
         $this->crud->allowAccess('create');
43 43
 
44
-        $this->crud->operation('create', function () {
44
+        $this->crud->operation('create', function() {
45 45
             $this->crud->loadDefaultOperationSettingsFromConfig();
46 46
             $this->crud->setupDefaultSaveActions();
47 47
         });
48 48
 
49
-        $this->crud->operation('list', function () {
49
+        $this->crud->operation('list', function() {
50 50
             $this->crud->addButton('top', 'create', 'view', 'crud::buttons.create');
51 51
         });
52 52
     }
Please login to merge, or discard this patch.
src/app/Models/Traits/HasIdentifiableAttribute.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@
 block discarded – undo
62 62
         // we get the first column from database
63 63
         // that is NOT indexed (usually primary, foreign keys)
64 64
         foreach ($columns as $columnName => $columnProperties) {
65
-            if (! in_array($columnName, $indexedColumns)) {
65
+            if (!in_array($columnName, $indexedColumns)) {
66 66
 
67 67
                 //check for convention "field<_id>" in case developer didn't add foreign key constraints.
68 68
                 if (strpos($columnName, '_id') !== false) {
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/SaveActions.php 1 patch
Spacing   +15 added lines, -16 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
      */
47 47
     public function getSaveActionByOrder($order)
48 48
     {
49
-        return array_filter($this->getOperationSetting('save_actions'), function ($arr) use ($order) {
49
+        return array_filter($this->getOperationSetting('save_actions'), function($arr) use ($order) {
50 50
             return $arr['order'] == $order;
51 51
         });
52 52
     }
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
         $orderCounter = $this->getOperationSetting('save_actions') !== null ? (count($this->getOperationSetting('save_actions')) + 1) : 1;
81 81
         //check for some mandatory fields
82 82
         $saveAction['name'] ?? abort(500, 'Please define save action name.');
83
-        $saveAction['redirect'] = $saveAction['redirect'] ?? function ($crud, $request, $itemId) {
83
+        $saveAction['redirect'] = $saveAction['redirect'] ?? function($crud, $request, $itemId) {
84 84
             return $request->has('http_referrer') ? $request->get('http_referrer') : $crud->route;
85 85
         };
86 86
         $saveAction['visible'] = $saveAction['visible'] ?? true;
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
 
90 90
         $actions = $this->getOperationSetting('save_actions') ?? [];
91 91
 
92
-        if (! in_array($saveAction['name'], $actions)) {
92
+        if (!in_array($saveAction['name'], $actions)) {
93 93
             $actions[$saveAction['name']] = $saveAction;
94 94
         }
95 95
 
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
     public function orderSaveAction(string $saveAction, int $wantedOrder)
107 107
     {
108 108
         $actions = $this->getOperationSetting('save_actions') ?? [];
109
-        if (! empty($actions)) {
109
+        if (!empty($actions)) {
110 110
             $replaceOrder = isset($actions[$saveAction]) ? $actions[$saveAction]['order'] : count($actions) + 1;
111 111
 
112 112
             foreach ($actions as $key => $sv) {
@@ -197,7 +197,7 @@  discard block
 block discarded – undo
197 197
     public function orderSaveActions(array $saveActions)
198 198
     {
199 199
         foreach ($saveActions as $sv => $order) {
200
-            if (! is_int($order)) {
200
+            if (!is_int($order)) {
201 201
                 $this->orderSaveAction($order, $sv + 1);
202 202
             } else {
203 203
                 $this->orderSaveAction($sv, $order);
@@ -214,7 +214,7 @@  discard block
 block discarded – undo
214 214
     {
215 215
         $actions = $this->getOperationSetting('save_actions') ?? [];
216 216
 
217
-        uasort($actions, function ($a, $b) {
217
+        uasort($actions, function($a, $b) {
218 218
             return $a['order'] <=> $b['order'];
219 219
         });
220 220
 
@@ -236,7 +236,7 @@  discard block
 block discarded – undo
236 236
             }
237 237
         }
238 238
 
239
-        return array_filter($actions, function ($action) {
239
+        return array_filter($actions, function($action) {
240 240
             return $action['visible'] == true;
241 241
         }, ARRAY_FILTER_USE_BOTH);
242 242
     }
@@ -300,8 +300,7 @@  discard block
 block discarded – undo
300 300
      */
301 301
     public function setSaveAction($forceSaveAction = null)
302 302
     {
303
-        $saveAction = $forceSaveAction ?:
304
-            \Request::input('save_action', $this->getFallBackSaveAction());
303
+        $saveAction = $forceSaveAction ?: \Request::input('save_action', $this->getFallBackSaveAction());
305 304
 
306 305
         $showBubble = $this->getOperationSetting('showSaveActionChange') ?? config('backpack.crud.operations.'.$this->getCurrentOperation().'.showSaveActionChange') ?? true;
307 306
 
@@ -369,20 +368,20 @@  discard block
 block discarded – undo
369 368
         $defaultSaveActions = [
370 369
             [
371 370
                 'name' => 'save_and_back',
372
-                'visible' => function ($crud) {
371
+                'visible' => function($crud) {
373 372
                     return $crud->hasAccess('list');
374 373
                 },
375
-                'redirect' => function ($crud, $request, $itemId = null) {
374
+                'redirect' => function($crud, $request, $itemId = null) {
376 375
                     return $request->has('http_referrer') ? $request->get('http_referrer') : $crud->route;
377 376
                 },
378 377
                 'button_text' => trans('backpack::crud.save_action_save_and_back'),
379 378
             ],
380 379
             [
381 380
                 'name' => 'save_and_edit',
382
-                'visible' => function ($crud) {
381
+                'visible' => function($crud) {
383 382
                     return $crud->hasAccess('update');
384 383
                 },
385
-                'redirect' => function ($crud, $request, $itemId = null) {
384
+                'redirect' => function($crud, $request, $itemId = null) {
386 385
                     $itemId = $itemId ?: $request->input('id');
387 386
                     $redirectUrl = $crud->route.'/'.$itemId.'/edit';
388 387
                     if ($request->has('locale')) {
@@ -394,17 +393,17 @@  discard block
 block discarded – undo
394 393
 
395 394
                     return $redirectUrl;
396 395
                 },
397
-                'referrer_url' => function ($crud, $request, $itemId) {
396
+                'referrer_url' => function($crud, $request, $itemId) {
398 397
                     return url($crud->route.'/'.$itemId.'/edit');
399 398
                 },
400 399
                 'button_text' => trans('backpack::crud.save_action_save_and_edit'),
401 400
             ],
402 401
             [
403 402
                 'name' => 'save_and_new',
404
-                'visible' => function ($crud) {
403
+                'visible' => function($crud) {
405 404
                     return $crud->hasAccess('create');
406 405
                 },
407
-                'redirect' => function ($crud, $request, $itemId = null) {
406
+                'redirect' => function($crud, $request, $itemId = null) {
408 407
                     return $this->route.'/create';
409 408
                 },
410 409
                 'button_text' => trans('backpack::crud.save_action_save_and_new'),
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/AutoSet.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -12,12 +12,12 @@  discard block
 block discarded – undo
12 12
      */
13 13
     public function setFromDb()
14 14
     {
15
-        if (! $this->driverIsMongoDb()) {
15
+        if (!$this->driverIsMongoDb()) {
16 16
             $this->setDoctrineTypesMapping();
17 17
             $this->getDbColumnTypes();
18 18
         }
19 19
 
20
-        array_map(function ($field) {
20
+        array_map(function($field) {
21 21
             $new_field = [
22 22
                 'name'       => $field,
23 23
                 'label'      => $this->makeLabel($field),
@@ -29,11 +29,11 @@  discard block
 block discarded – undo
29 29
                 'autoset'    => true,
30 30
             ];
31 31
 
32
-            if (! isset($this->fields()[$field])) {
32
+            if (!isset($this->fields()[$field])) {
33 33
                 $this->addField($new_field);
34 34
             }
35 35
 
36
-            if (! in_array($field, $this->model->getHidden()) && ! in_array($field, $this->columns())) {
36
+            if (!in_array($field, $this->model->getHidden()) && !in_array($field, $this->columns())) {
37 37
                 $this->addColumn([
38 38
                     'name'    => $field,
39 39
                     'label'   => $this->makeLabel($field),
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
 
106 106
         $dbColumnTypes = $this->getDbColumnTypes();
107 107
 
108
-        if (! isset($dbColumnTypes[$fieldName])) {
108
+        if (!isset($dbColumnTypes[$fieldName])) {
109 109
             return 'text';
110 110
         }
111 111
 
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
         $types = ['enum' => 'string'];
164 164
         $platform = $this->getSchema()->getConnection()->getDoctrineConnection()->getDatabasePlatform();
165 165
         foreach ($types as $type_key => $type_value) {
166
-            if (! $platform->hasDoctrineTypeMappingFor($type_key)) {
166
+            if (!$platform->hasDoctrineTypeMappingFor($type_key)) {
167 167
                 $platform->registerDoctrineTypeMapping($type_key, $type_value);
168 168
             }
169 169
         }
@@ -222,7 +222,7 @@  discard block
 block discarded – undo
222 222
             // Automatically-set columns should be both in the database, and in the $fillable variable on the Eloquent Model
223 223
             $columns = $this->model->getConnection()->getSchemaBuilder()->getColumnListing($this->model->getTable());
224 224
 
225
-            if (! empty($fillable)) {
225
+            if (!empty($fillable)) {
226 226
                 $columns = array_intersect($columns, $fillable);
227 227
             }
228 228
         }
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelSaveActionsTest.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -21,10 +21,10 @@  discard block
 block discarded – undo
21 21
 
22 22
         $this->singleSaveAction = [
23 23
             'name' => 'save_action_one',
24
-            'redirect' => function ($crud, $request, $itemId) {
24
+            'redirect' => function($crud, $request, $itemId) {
25 25
                 return $crud->route;
26 26
             },
27
-            'visible' => function ($crud) {
27
+            'visible' => function($crud) {
28 28
                 return true;
29 29
             },
30 30
         ];
@@ -32,19 +32,19 @@  discard block
 block discarded – undo
32 32
         $this->multipleSaveActions = [
33 33
             [
34 34
                 'name' => 'save_action_one',
35
-                'redirect' => function ($crud, $request, $itemId) {
35
+                'redirect' => function($crud, $request, $itemId) {
36 36
                     return $crud->route;
37 37
                 },
38
-                'visible' => function ($crud) {
38
+                'visible' => function($crud) {
39 39
                     return true;
40 40
                 },
41 41
             ],
42 42
             [
43 43
                 'name' => 'save_action_two',
44
-                'redirect' => function ($crud, $request, $itemId) {
44
+                'redirect' => function($crud, $request, $itemId) {
45 45
                     return $crud->route;
46 46
                 },
47
-                'visible' => function ($crud) {
47
+                'visible' => function($crud) {
48 48
                     return true;
49 49
                 },
50 50
             ],
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/InlineCreateOperation.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@
 block discarded – undo
49 49
      */
50 50
     public function getInlineCreateModal()
51 51
     {
52
-        if (! request()->has('entity')) {
52
+        if (!request()->has('entity')) {
53 53
             abort(400, 'No "entity" inside the request.');
54 54
         }
55 55
 
Please login to merge, or discard this patch.
src/app/Library/Auth/ResetsPasswords.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@
 block discarded – undo
45 45
         // will update the password on an actual user model and persist it to the
46 46
         // database. Otherwise we will parse the error and return the response.
47 47
         $response = $this->broker()->reset(
48
-            $this->credentials($request), function ($user, $password) {
48
+            $this->credentials($request), function($user, $password) {
49 49
                 $this->resetPassword($user, $password);
50 50
             }
51 51
         );
Please login to merge, or discard this patch.