Laravel-Backpack /
CRUD
We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
| Total Complexity | 89 |
| Total Lines | 415 |
| Duplicated Lines | 0 % |
| Changes | 0 | ||
Complex classes like HandleRepeatableUploads often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use HandleRepeatableUploads, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 17 | trait HandleRepeatableUploads |
||
| 18 | { |
||
| 19 | public bool $handleRepeatableFiles = false; |
||
| 20 | |||
| 21 | public null|string $repeatableContainerName = null; |
||
| 22 | |||
| 23 | /******************************* |
||
| 24 | * Setters - fluently configure the uploader |
||
| 25 | *******************************/ |
||
| 26 | public function repeats(string $repeatableContainerName): self |
||
| 27 | { |
||
| 28 | $this->handleRepeatableFiles = true; |
||
| 29 | |||
| 30 | $this->repeatableContainerName = $repeatableContainerName; |
||
| 31 | |||
| 32 | return $this; |
||
| 33 | } |
||
| 34 | |||
| 35 | /******************************* |
||
| 36 | * Getters |
||
| 37 | *******************************/ |
||
| 38 | public function getRepeatableContainerName(): null|string |
||
| 39 | { |
||
| 40 | return $this->repeatableContainerName; |
||
| 41 | } |
||
| 42 | |||
| 43 | /******************************* |
||
| 44 | * Default implementation methods |
||
| 45 | *******************************/ |
||
| 46 | protected function uploadRepeatableFiles($values, $previousValues, $entry = null) |
||
| 48 | } |
||
| 49 | |||
| 50 | protected function handleRepeatableFiles(Model $entry): Model |
||
| 51 | { |
||
| 52 | $values = collect(CRUD::getRequest()->get($this->getRepeatableContainerName())); |
||
|
Bug
introduced
by
|
|||
| 53 | $files = collect(CRUD::getRequest()->file($this->getRepeatableContainerName())); |
||
| 54 | |||
| 55 | $value = $this->mergeValuesRecursive($values, $files); |
||
| 56 | |||
| 57 | if ($this->isRelationship()) { |
||
| 58 | if ($value->isEmpty()) { |
||
| 59 | return $entry; |
||
| 60 | } |
||
| 61 | |||
| 62 | return $this->processRelationshipRepeatableUploaders($entry); |
||
| 63 | } |
||
| 64 | |||
| 65 | $processedEntryValues = $this->processRepeatableUploads($entry, $value)->toArray(); |
||
| 66 | |||
| 67 | if ($this->isFake()) { |
||
| 68 | $fakeValues = $entry->{$this->getFakeAttribute()} ?? []; |
||
| 69 | |||
| 70 | if (is_string($fakeValues)) { |
||
| 71 | $fakeValues = json_decode($fakeValues, true); |
||
| 72 | } |
||
| 73 | |||
| 74 | $fakeValues[$this->getRepeatableContainerName()] = empty($processedEntryValues) |
||
| 75 | ? null |
||
| 76 | : (isset($entry->getCasts()[$this->getFakeAttribute()]) |
||
| 77 | ? $processedEntryValues |
||
| 78 | : json_encode($processedEntryValues)); |
||
| 79 | |||
| 80 | $entry->{$this->getFakeAttribute()} = isset($entry->getCasts()[$this->getFakeAttribute()]) |
||
| 81 | ? $fakeValues |
||
| 82 | : json_encode($fakeValues); |
||
| 83 | |||
| 84 | return $entry; |
||
| 85 | } |
||
| 86 | |||
| 87 | $entry->{$this->getRepeatableContainerName()} = empty($processedEntryValues) |
||
| 88 | ? null |
||
| 89 | : (isset($entry->getCasts()[$this->getRepeatableContainerName()]) |
||
| 90 | ? $processedEntryValues |
||
| 91 | : json_encode($processedEntryValues)); |
||
| 92 | |||
| 93 | return $entry; |
||
| 94 | } |
||
| 95 | |||
| 96 | private function processRelationshipRepeatableUploaders(Model $entry) |
||
| 103 | } |
||
| 104 | |||
| 105 | protected function uploadRelationshipFiles(Model $entry): Model |
||
| 106 | { |
||
| 107 | $entryValue = $this->getFilesFromEntry($entry); |
||
| 108 | |||
| 109 | if ($this->handleMultipleFiles && is_string($entryValue)) { |
||
| 110 | try { |
||
| 111 | $entryValue = json_decode($entryValue, true); |
||
| 112 | } catch (\Exception) { |
||
| 113 | return $entry; |
||
| 114 | } |
||
| 115 | } |
||
| 116 | |||
| 117 | if ($this->hasDeletedFiles($entryValue)) { |
||
| 118 | $entry->{$this->getAttributeName()} = $this->uploadFiles($entry, false); |
||
| 119 | $this->updatedPreviousFiles = $this->getEntryAttributeValue($entry); |
||
| 120 | } |
||
| 121 | |||
| 122 | if ($this->shouldKeepPreviousValueUnchanged($entry, $entryValue)) { |
||
| 123 | $entry->{$this->getAttributeName()} = $this->updatedPreviousFiles ?? $this->getEntryOriginalValue($entry); |
||
| 124 | |||
| 125 | return $entry; |
||
| 126 | } |
||
| 127 | |||
| 128 | if ($this->shouldUploadFiles($entryValue)) { |
||
| 129 | $entry->{$this->getAttributeName()} = $this->uploadFiles($entry, $entryValue); |
||
| 130 | } |
||
| 131 | |||
| 132 | return $entry; |
||
| 133 | } |
||
| 134 | |||
| 135 | protected function getFilesFromEntry(Model $entry) |
||
| 136 | { |
||
| 137 | return $entry->getAttribute($this->getAttributeName()); |
||
| 138 | } |
||
| 139 | |||
| 140 | protected function getEntryAttributeValue(Model $entry) |
||
| 143 | } |
||
| 144 | |||
| 145 | protected function getEntryOriginalValue(Model $entry) |
||
| 148 | } |
||
| 149 | |||
| 150 | protected function processRepeatableUploads(Model $entry, Collection $values): Collection |
||
| 151 | { |
||
| 152 | foreach (app('UploadersRepository')->getRepeatableUploadersFor($this->getRepeatableContainerName()) as $uploader) { |
||
| 153 | $uploadedValues = $uploader->uploadRepeatableFiles($values->pluck($uploader->getAttributeName())->toArray(), $this->getPreviousRepeatableValues($entry, $uploader)); |
||
| 154 | |||
| 155 | $values = $values->map(function ($item, $key) use ($uploadedValues, $uploader) { |
||
| 156 | $item[$uploader->getAttributeName()] = $uploadedValues[$key] ?? null; |
||
| 157 | |||
| 158 | return $item; |
||
| 159 | }); |
||
| 160 | } |
||
| 161 | |||
| 162 | return $values; |
||
| 163 | } |
||
| 164 | |||
| 165 | private function retrieveRepeatableFiles(Model $entry): Model |
||
| 166 | { |
||
| 167 | if ($this->isRelationship) { |
||
| 168 | return $this->retrieveRepeatableRelationFiles($entry); |
||
| 169 | } |
||
| 170 | |||
| 171 | $repeatableUploaders = app('UploadersRepository')->getRepeatableUploadersFor($this->getRepeatableContainerName()); |
||
| 172 | |||
| 173 | if ($this->attachedToFakeField) { |
||
| 174 | $values = $entry->{$this->attachedToFakeField}; |
||
| 175 | |||
| 176 | $values = is_string($values) ? json_decode($values, true) : $values; |
||
| 177 | |||
| 178 | $values[$this->getAttributeName()] = isset($values[$this->getAttributeName()]) ? $this->getValueWithoutPath($values[$this->getAttributeName()]) : null; |
||
| 179 | $entry->{$this->attachedToFakeField} = isset($entry->getCasts()[$this->attachedToFakeField]) ? $values : json_encode($values); |
||
| 180 | |||
| 181 | return $entry; |
||
| 182 | } |
||
| 183 | |||
| 184 | $values = $entry->{$this->getRepeatableContainerName()}; |
||
| 185 | $values = is_string($values) ? json_decode($values, true) : $values; |
||
| 186 | $values = array_map(function ($item) use ($repeatableUploaders) { |
||
| 187 | foreach ($repeatableUploaders as $upload) { |
||
| 188 | $item[$upload->getAttributeName()] = $this->getValuesWithPathStripped($item, $upload); |
||
| 189 | } |
||
| 190 | |||
| 191 | return $item; |
||
| 192 | }, $values ?? []); |
||
| 193 | |||
| 194 | $entry->{$this->getRepeatableContainerName()} = $values; |
||
| 195 | |||
| 196 | return $entry; |
||
| 197 | } |
||
| 198 | |||
| 199 | private function retrieveRepeatableRelationFiles(Model $entry) |
||
| 200 | { |
||
| 201 | switch($this->getRepeatableRelationType()) { |
||
| 202 | case 'BelongsToMany': |
||
| 203 | case 'MorphToMany': |
||
| 204 | $pivotClass = app('crud')->getModel()->{$this->getUploaderSubfield()['baseEntity']}()->getPivotClass(); |
||
| 205 | $pivotFieldName = 'pivot_'.$this->getAttributeName(); |
||
| 206 | $connectedEntry = new $pivotClass([$this->getAttributeName() => $entry->$pivotFieldName]); |
||
| 207 | $entry->{$pivotFieldName} = $this->retrieveFiles($connectedEntry)->{$this->getAttributeName()}; |
||
| 208 | |||
| 209 | break; |
||
| 210 | default: |
||
| 211 | $entry = $this->retrieveFiles($entry); |
||
| 212 | } |
||
| 213 | |||
| 214 | return $entry; |
||
| 215 | } |
||
| 216 | |||
| 217 | private function getRepeatableRelationType() |
||
| 218 | { |
||
| 219 | return $this->getUploaderField()->getAttributes()['relation_type']; |
||
| 220 | } |
||
| 221 | |||
| 222 | private function getUploaderField() |
||
| 223 | { |
||
| 224 | return app('crud')->field($this->getRepeatableContainerName()); |
||
| 225 | } |
||
| 226 | |||
| 227 | private function getUploaderSubfield() |
||
| 230 | } |
||
| 231 | |||
| 232 | private function getUploaderFieldSubfields() |
||
| 233 | { |
||
| 234 | return $this->getUploaderField()->getAttributes()['subfields']; |
||
| 235 | } |
||
| 236 | |||
| 237 | private function deleteRepeatableFiles(Model $entry): void |
||
| 238 | { |
||
| 239 | if ($this->isRelationship) { |
||
| 240 | $this->deleteRelationshipFiles($entry); |
||
| 241 | |||
| 242 | return; |
||
| 243 | } |
||
| 244 | |||
| 245 | if ($this->attachedToFakeField) { |
||
| 246 | $repeatableValues = $entry->{$this->attachedToFakeField}[$this->getRepeatableContainerName()] ?? null; |
||
| 247 | $repeatableValues = is_string($repeatableValues) ? json_decode($repeatableValues, true) : $repeatableValues; |
||
| 248 | $repeatableValues = collect($repeatableValues); |
||
| 249 | } |
||
| 250 | |||
| 251 | $repeatableValues ??= collect($entry->{$this->getRepeatableContainerName()}); |
||
| 252 | |||
| 253 | foreach (app('UploadersRepository')->getRepeatableUploadersFor($this->getRepeatableContainerName()) as $upload) { |
||
| 254 | if (! $upload->shouldDeleteFiles()) { |
||
| 255 | continue; |
||
| 256 | } |
||
| 257 | $values = $repeatableValues->pluck($upload->getName())->toArray(); |
||
| 258 | foreach ($values as $value) { |
||
| 259 | if (! $value) { |
||
| 260 | continue; |
||
| 261 | } |
||
| 262 | |||
| 263 | if (is_array($value)) { |
||
| 264 | foreach ($value as $subvalue) { |
||
| 265 | Storage::disk($upload->getDisk())->delete($upload->getPath().$subvalue); |
||
| 266 | } |
||
| 267 | |||
| 268 | continue; |
||
| 269 | } |
||
| 270 | |||
| 271 | Storage::disk($upload->getDisk())->delete($upload->getPath().$value); |
||
| 272 | } |
||
| 273 | } |
||
| 274 | } |
||
| 275 | /******************************* |
||
| 276 | * Helper methods |
||
| 277 | *******************************/ |
||
| 278 | |||
| 279 | /** |
||
| 280 | * Given two multidimensional arrays/collections, merge them recursively. |
||
| 281 | */ |
||
| 282 | protected function mergeValuesRecursive(array|Collection $array1, array|Collection $array2): array|Collection |
||
| 283 | { |
||
| 284 | $merged = $array1; |
||
| 285 | foreach ($array2 as $key => &$value) { |
||
| 286 | if (is_array($value) && isset($merged[$key]) && is_array($merged[$key])) { |
||
| 287 | $merged[$key] = $this->mergeValuesRecursive($merged[$key], $value); |
||
| 288 | } else { |
||
| 289 | $merged[$key] = $value; |
||
| 290 | } |
||
| 291 | } |
||
| 292 | |||
| 293 | return $merged; |
||
| 294 | } |
||
| 295 | |||
| 296 | /** |
||
| 297 | * Repeatable items send `_order_` parameter in the request. |
||
| 298 | * This holds the order of the items in the repeatable container. |
||
| 299 | */ |
||
| 300 | protected function getFileOrderFromRequest(): array |
||
| 310 | } |
||
| 311 | |||
| 312 | private function getPreviousRepeatableValues(Model $entry, UploaderInterface $uploader): array |
||
| 313 | { |
||
| 314 | $previousValues = $entry->getOriginal($uploader->getRepeatableContainerName()); |
||
| 315 | |||
| 316 | if (! is_array($previousValues)) { |
||
| 317 | $previousValues = json_decode($previousValues, true); |
||
| 318 | } |
||
| 319 | |||
| 320 | if (! empty($previousValues)) { |
||
| 321 | $previousValues = array_column($previousValues, $uploader->getName()); |
||
| 322 | } |
||
| 323 | |||
| 324 | return $previousValues ?? []; |
||
| 325 | } |
||
| 326 | |||
| 327 | private function getValuesWithPathStripped(array|string|null $item, UploaderInterface $uploader) |
||
| 328 | { |
||
| 329 | $uploadedValues = $item[$uploader->getName()] ?? null; |
||
| 330 | if (is_array($uploadedValues)) { |
||
| 331 | return array_map(function ($value) use ($uploader) { |
||
| 332 | return $uploader->getValueWithoutPath($value); |
||
| 333 | }, $uploadedValues); |
||
| 334 | } |
||
| 335 | |||
| 336 | return isset($uploadedValues) ? $uploader->getValueWithoutPath($uploadedValues) : null; |
||
| 337 | } |
||
| 338 | |||
| 339 | private function deleteRelationshipFiles(Model $entry): void |
||
| 340 | { |
||
| 341 | if (! is_a($entry, Pivot::class, true) && |
||
| 342 | ! $entry->relationLoaded($this->getRepeatableContainerName()) && |
||
| 343 | method_exists($entry, $this->getRepeatableContainerName()) |
||
| 344 | ) { |
||
| 345 | $entry->loadMissing($this->getRepeatableContainerName()); |
||
| 346 | } |
||
| 347 | |||
| 348 | foreach (app('UploadersRepository')->getRepeatableUploadersFor($this->getRepeatableContainerName()) as $uploader) { |
||
| 349 | if ($uploader->shouldDeleteFiles()) { |
||
| 350 | $uploader->deleteRepeatableRelationFiles($entry); |
||
| 351 | } |
||
| 352 | } |
||
| 353 | } |
||
| 354 | |||
| 355 | protected function deleteRepeatableRelationFiles(Model $entry) |
||
| 360 | }; |
||
| 361 | } |
||
| 362 | |||
| 363 | private function deleteRelatedFiles(Model $entry) |
||
| 375 | } |
||
| 376 | } |
||
| 377 | |||
| 378 | protected function deletePivotFiles(Pivot|Model $entry) |
||
| 379 | { |
||
| 401 | } |
||
| 402 | |||
| 403 | private function deletePivotModelFiles(Pivot|Model $entry) |
||
| 404 | { |
||
| 405 | $files = $entry->getOriginal()['pivot_'.$this->getAttributeName()]; |
||
| 432 | } |
||
| 433 | } |
||
| 434 |
Loading history...
