Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Test Setup Failed
Pull Request — master (#3871)
by Cristian
13:32
created
src/app/Library/CrudPanel/Traits/SaveActions.php 1 patch
Spacing   +16 added lines, -17 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
         $higherAction = $this->getSaveActionByOrder(1);
29 29
 
30 30
         //if there is an higher action and that action is not the backpack default higher one `save_and_back` we return it.
31
-        if (! empty($higherAction) && key($higherAction) !== 'save_and_back') {
31
+        if (!empty($higherAction) && key($higherAction) !== 'save_and_back') {
32 32
             return key($higherAction);
33 33
         }
34 34
 
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
      */
48 48
     public function getSaveActionByOrder($order)
49 49
     {
50
-        return array_filter($this->getOperationSetting('save_actions'), function ($arr) use ($order) {
50
+        return array_filter($this->getOperationSetting('save_actions'), function($arr) use ($order) {
51 51
             return $arr['order'] == $order;
52 52
         });
53 53
     }
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
         $orderCounter = $this->getOperationSetting('save_actions') !== null ? (count($this->getOperationSetting('save_actions')) + 1) : 1;
82 82
         //check for some mandatory fields
83 83
         $saveAction['name'] ?? abort(500, 'Please define save action name.');
84
-        $saveAction['redirect'] = $saveAction['redirect'] ?? function ($crud, $request, $itemId) {
84
+        $saveAction['redirect'] = $saveAction['redirect'] ?? function($crud, $request, $itemId) {
85 85
             return $request->has('http_referrer') ? $request->get('http_referrer') : $crud->route;
86 86
         };
87 87
         $saveAction['visible'] = $saveAction['visible'] ?? true;
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
 
91 91
         $actions = $this->getOperationSetting('save_actions') ?? [];
92 92
 
93
-        if (! in_array($saveAction['name'], $actions)) {
93
+        if (!in_array($saveAction['name'], $actions)) {
94 94
             $actions[$saveAction['name']] = $saveAction;
95 95
         }
96 96
 
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
     public function orderSaveAction(string $saveAction, int $wantedOrder)
108 108
     {
109 109
         $actions = $this->getOperationSetting('save_actions') ?? [];
110
-        if (! empty($actions)) {
110
+        if (!empty($actions)) {
111 111
             $replaceOrder = isset($actions[$saveAction]) ? $actions[$saveAction]['order'] : count($actions) + 1;
112 112
 
113 113
             foreach ($actions as $key => $sv) {
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
     public function orderSaveActions(array $saveActions)
202 202
     {
203 203
         foreach ($saveActions as $sv => $order) {
204
-            if (! is_int($order)) {
204
+            if (!is_int($order)) {
205 205
                 $this->orderSaveAction($order, $sv + 1);
206 206
             } else {
207 207
                 $this->orderSaveAction($sv, $order);
@@ -218,7 +218,7 @@  discard block
 block discarded – undo
218 218
     {
219 219
         $actions = $this->getOperationSetting('save_actions') ?? [];
220 220
 
221
-        uasort($actions, function ($a, $b) {
221
+        uasort($actions, function($a, $b) {
222 222
             return $a['order'] <=> $b['order'];
223 223
         });
224 224
 
@@ -240,7 +240,7 @@  discard block
 block discarded – undo
240 240
             }
241 241
         }
242 242
 
243
-        return array_filter($actions, function ($action) {
243
+        return array_filter($actions, function($action) {
244 244
             return $action['visible'] == true;
245 245
         }, ARRAY_FILTER_USE_BOTH);
246 246
     }
@@ -304,8 +304,7 @@  discard block
 block discarded – undo
304 304
      */
305 305
     public function setSaveAction($forceSaveAction = null)
306 306
     {
307
-        $saveAction = $forceSaveAction ?:
308
-            \Request::input('save_action', $this->getFallBackSaveAction());
307
+        $saveAction = $forceSaveAction ?: \Request::input('save_action', $this->getFallBackSaveAction());
309 308
 
310 309
         $showBubble = $this->getOperationSetting('showSaveActionChange') ?? config('backpack.crud.operations.'.$this->getCurrentOperation().'.showSaveActionChange') ?? true;
311 310
 
@@ -373,20 +372,20 @@  discard block
 block discarded – undo
373 372
         $defaultSaveActions = [
374 373
             [
375 374
                 'name' => 'save_and_back',
376
-                'visible' => function ($crud) {
375
+                'visible' => function($crud) {
377 376
                     return $crud->hasAccess('list');
378 377
                 },
379
-                'redirect' => function ($crud, $request, $itemId = null) {
378
+                'redirect' => function($crud, $request, $itemId = null) {
380 379
                     return $request->has('http_referrer') ? $request->get('http_referrer') : $crud->route;
381 380
                 },
382 381
                 'button_text' => trans('backpack::crud.save_action_save_and_back'),
383 382
             ],
384 383
             [
385 384
                 'name' => 'save_and_edit',
386
-                'visible' => function ($crud) {
385
+                'visible' => function($crud) {
387 386
                     return $crud->hasAccess('update');
388 387
                 },
389
-                'redirect' => function ($crud, $request, $itemId = null) {
388
+                'redirect' => function($crud, $request, $itemId = null) {
390 389
                     $itemId = $itemId ?: $request->input('id');
391 390
                     $redirectUrl = $crud->route.'/'.$itemId.'/edit';
392 391
                     if ($request->has('locale')) {
@@ -398,17 +397,17 @@  discard block
 block discarded – undo
398 397
 
399 398
                     return $redirectUrl;
400 399
                 },
401
-                'referrer_url' => function ($crud, $request, $itemId) {
400
+                'referrer_url' => function($crud, $request, $itemId) {
402 401
                     return url($crud->route.'/'.$itemId.'/edit');
403 402
                 },
404 403
                 'button_text' => trans('backpack::crud.save_action_save_and_edit'),
405 404
             ],
406 405
             [
407 406
                 'name' => 'save_and_new',
408
-                'visible' => function ($crud) {
407
+                'visible' => function($crud) {
409 408
                     return $crud->hasAccess('create');
410 409
                 },
411
-                'redirect' => function ($crud, $request, $itemId = null) {
410
+                'redirect' => function($crud, $request, $itemId = null) {
412 411
                     return $this->route.'/create';
413 412
                 },
414 413
                 'button_text' => trans('backpack::crud.save_action_save_and_new'),
Please login to merge, or discard this patch.
src/LicenseCheck.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
             return;
29 29
         }
30 30
 
31
-        if (! $this->validCode(config('backpack.base.license_code'))) {
31
+        if (!$this->validCode(config('backpack.base.license_code'))) {
32 32
             \Alert::add('warning', "<strong>You're using unlicensed software.</strong> Please ask your web developer to <a target='_blank' class='alert-link text-white' href='http://backpackforlaravel.com'>purchase a license code</a> to hide this message.");
33 33
         }
34 34
     }
@@ -46,6 +46,6 @@  discard block
 block discarded – undo
46 46
      */
47 47
     private function validCode($j)
48 48
     {
49
-        $k = str_replace('-', '', $j); $s = substr($k, 0, 8); $c = substr($k, 8, 2); $a = substr($k, 10, 2); $l = substr($k, 12, 2); $p = substr($k, 14, 2); $n = substr($k, 16, 2); $m = substr($k, 18, 2); $z = substr($k, 20, 24); $w = 'ADEFHKLMVWXYZ146'; $x = $s; for ($i = 0; $i < strlen($w); $i++) { $r = $w[$i]; $x = str_replace($r, '-', $x); } $x = str_replace('-', '', $x); if ($x != '') { return false; } if (substr_count($j, '-') != 5) { return false; } $e = substr(hexdec(hash('crc32b', substr($k, 0, 20))), -4); if ($z !== $e) { return false; } $o = strrev(substr(preg_replace('/[0-9]+/', '', strtoupper(sha1($a.'sand('.$s.')'.$n.'tos()'))), 2, 2)); if ($m !== $o) { return false; } $o2 = substr(((int)preg_replace('/[^0-9]/','', $s.$c)==0 ? 8310 : (int)preg_replace('/[^0-9]/','', $s.$c) )*9971, -2);if ($a !== $o2) {return false;} return true; 
49
+        $k = str_replace('-', '', $j); $s = substr($k, 0, 8); $c = substr($k, 8, 2); $a = substr($k, 10, 2); $l = substr($k, 12, 2); $p = substr($k, 14, 2); $n = substr($k, 16, 2); $m = substr($k, 18, 2); $z = substr($k, 20, 24); $w = 'ADEFHKLMVWXYZ146'; $x = $s; for ($i = 0; $i < strlen($w); $i++) { $r = $w[$i]; $x = str_replace($r, '-', $x); } $x = str_replace('-', '', $x); if ($x != '') { return false; } if (substr_count($j, '-') != 5) { return false; } $e = substr(hexdec(hash('crc32b', substr($k, 0, 20))), -4); if ($z !== $e) { return false; } $o = strrev(substr(preg_replace('/[0-9]+/', '', strtoupper(sha1($a.'sand('.$s.')'.$n.'tos()'))), 2, 2)); if ($m !== $o) { return false; } $o2 = substr(((int) preg_replace('/[^0-9]/', '', $s.$c) == 0 ? 8310 : (int) preg_replace('/[^0-9]/', '', $s.$c)) * 9971, -2); if ($a !== $o2) {return false; } return true; 
50 50
     }
51 51
 }
Please login to merge, or discard this patch.
src/routes/backpack/custom.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,5 +13,5 @@
 block discarded – undo
13 13
         (array) config('backpack.base.middleware_key', 'admin')
14 14
     ),
15 15
     'namespace'  => 'App\Http\Controllers\Admin',
16
-], function () { // custom admin routes
16
+], function() { // custom admin routes
17 17
 }); // this should be the absolute last line of this file
Please login to merge, or discard this patch.
config/database/migrations/2017_09_08_000001_create_addresses_table.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@
 block discarded – undo
13 13
      */
14 14
     public function up()
15 15
     {
16
-        Schema::create('addresses', function (Blueprint $table) {
16
+        Schema::create('addresses', function(Blueprint $table) {
17 17
             $table->increments('id');
18 18
             $table->integer('account_details_id')->unsigned();
19 19
             $table->string('city')->nullable();
Please login to merge, or discard this patch.
tests/Unit/Http/CrudControllerTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
 
27 27
         $app['router']->get('admin/users', "$controller@index")->name('admin.users.index');
28 28
 
29
-        $app->singleton('crud', function ($app) {
29
+        $app->singleton('crud', function($app) {
30 30
             return new CrudPanel($app);
31 31
         });
32 32
 
Please login to merge, or discard this patch.
src/app/Models/Traits/HasRelationshipFields.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
         $table = $instance->getTableWithPrefix();
73 73
 
74 74
         // MongoDB columns are alway nullable
75
-        if (! in_array($conn->getConfig()['driver'], CRUD::getSqlDriverList())) {
75
+        if (!in_array($conn->getConfig()['driver'], CRUD::getSqlDriverList())) {
76 76
             return true;
77 77
         }
78 78
 
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
             // check for NOT NULL
83 83
             $notNull = $column->getNotnull();
84 84
             // return the value of nullable (aka the inverse of NOT NULL)
85
-            return ! $notNull;
85
+            return !$notNull;
86 86
         } catch (\Exception $e) {
87 87
             return true;
88 88
         }
Please login to merge, or discard this patch.
src/helpers.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-if (! function_exists('backpack_url')) {
3
+if (!function_exists('backpack_url')) {
4 4
     /**
5 5
      * Appends the configured backpack prefix and returns
6 6
      * the URL using the standard Laravel helpers.
@@ -11,13 +11,13 @@  discard block
 block discarded – undo
11 11
      */
12 12
     function backpack_url($path = null, $parameters = [], $secure = null)
13 13
     {
14
-        $path = ! $path || (substr($path, 0, 1) == '/') ? $path : '/'.$path;
14
+        $path = !$path || (substr($path, 0, 1) == '/') ? $path : '/'.$path;
15 15
 
16 16
         return url(config('backpack.base.route_prefix', 'admin').$path, $parameters, $secure);
17 17
     }
18 18
 }
19 19
 
20
-if (! function_exists('backpack_authentication_column')) {
20
+if (!function_exists('backpack_authentication_column')) {
21 21
     /**
22 22
      * Return the username column name.
23 23
      * The Laravel default (and Backpack default) is 'email'.
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
     }
31 31
 }
32 32
 
33
-if (! function_exists('backpack_form_input')) {
33
+if (!function_exists('backpack_form_input')) {
34 34
     /**
35 35
      * Parse the submitted input in request('form') to an usable array.
36 36
      * Joins the multiple[] fields in a single key and transform the dot notation fields into arrayed ones.
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
             }
60 60
 
61 61
             if (is_null($input_arg)) {
62
-                if (! isset($result[$input_key])) {
62
+                if (!isset($result[$input_key])) {
63 63
                     $result[$input_key] = $start ? [$row['value']] : $row['value'];
64 64
                 } else {
65 65
                     array_push($result[$input_key], $row['value']);
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
     }
74 74
 }
75 75
 
76
-if (! function_exists('backpack_users_have_email')) {
76
+if (!function_exists('backpack_users_have_email')) {
77 77
     /**
78 78
      * Check if the email column is present on the user table.
79 79
      *
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
     }
89 89
 }
90 90
 
91
-if (! function_exists('backpack_avatar_url')) {
91
+if (!function_exists('backpack_avatar_url')) {
92 92
     /**
93 93
      * Returns the avatar URL of a user.
94 94
      *
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
     }
122 122
 }
123 123
 
124
-if (! function_exists('backpack_middleware')) {
124
+if (!function_exists('backpack_middleware')) {
125 125
     /**
126 126
      * Return the key of the middleware used across Backpack.
127 127
      * That middleware checks if the visitor is an admin.
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
     }
137 137
 }
138 138
 
139
-if (! function_exists('backpack_guard_name')) {
139
+if (!function_exists('backpack_guard_name')) {
140 140
     /*
141 141
      * Returns the name of the guard defined
142 142
      * by the application config
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
     }
148 148
 }
149 149
 
150
-if (! function_exists('backpack_auth')) {
150
+if (!function_exists('backpack_auth')) {
151 151
     /*
152 152
      * Returns the user instance if it exists
153 153
      * of the currently authenticated admin
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
     }
160 160
 }
161 161
 
162
-if (! function_exists('backpack_user')) {
162
+if (!function_exists('backpack_user')) {
163 163
     /*
164 164
      * Returns back a user instance without
165 165
      * the admin guard, however allows you
@@ -171,7 +171,7 @@  discard block
 block discarded – undo
171 171
     }
172 172
 }
173 173
 
174
-if (! function_exists('mb_ucfirst')) {
174
+if (!function_exists('mb_ucfirst')) {
175 175
     /**
176 176
      * Capitalize the first letter of a string,
177 177
      * even if that string is multi-byte (non-latin alphabet).
@@ -193,7 +193,7 @@  discard block
 block discarded – undo
193 193
     }
194 194
 }
195 195
 
196
-if (! function_exists('backpack_view')) {
196
+if (!function_exists('backpack_view')) {
197 197
     /**
198 198
      * Returns a new displayable view based on the configured backpack view namespace.
199 199
      * If that view doesn't exist, it will load the one from the original theme.
@@ -213,7 +213,7 @@  discard block
 block discarded – undo
213 213
 
214 214
         $returnView = $theme.$view;
215 215
 
216
-        if (! view()->exists($returnView)) {
216
+        if (!view()->exists($returnView)) {
217 217
             $returnView = $originalTheme.$view;
218 218
         }
219 219
 
@@ -221,7 +221,7 @@  discard block
 block discarded – undo
221 221
     }
222 222
 }
223 223
 
224
-if (! function_exists('square_brackets_to_dots')) {
224
+if (!function_exists('square_brackets_to_dots')) {
225 225
     /**
226 226
      * Turns a string from bracket-type array to dot-notation array.
227 227
      * Ex: array[0][property] turns into array.0.property.
@@ -238,7 +238,7 @@  discard block
 block discarded – undo
238 238
     }
239 239
 }
240 240
 
241
-if (! function_exists('is_countable')) {
241
+if (!function_exists('is_countable')) {
242 242
     /**
243 243
      * We need this because is_countable was only introduced in PHP 7.3,
244 244
      * and in PHP 7.2 you should check if count() argument is really countable.
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Columns.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
      */
115 115
     public function makeFirstColumn()
116 116
     {
117
-        if (! $this->columns()) {
117
+        if (!$this->columns()) {
118 118
             return false;
119 119
         }
120 120
 
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
      */
160 160
     public function removeColumns($columns)
161 161
     {
162
-        if (! empty($columns)) {
162
+        if (!empty($columns)) {
163 163
             foreach ($columns as $columnKey) {
164 164
                 $this->removeColumn($columnKey);
165 165
             }
@@ -252,8 +252,8 @@  discard block
 block discarded – undo
252 252
     {
253 253
         $columns = $this->columns();
254 254
 
255
-        return collect($columns)->pluck('entity')->reject(function ($value, $key) {
256
-            return ! $value;
255
+        return collect($columns)->pluck('entity')->reject(function($value, $key) {
256
+            return !$value;
257 257
         })->toArray();
258 258
     }
259 259
 
@@ -329,7 +329,7 @@  discard block
 block discarded – undo
329 329
      */
330 330
     public function hasColumnWhere($attribute, $value)
331 331
     {
332
-        $match = Arr::first($this->columns(), function ($column, $columnKey) use ($attribute, $value) {
332
+        $match = Arr::first($this->columns(), function($column, $columnKey) use ($attribute, $value) {
333 333
             return isset($column[$attribute]) && $column[$attribute] == $value;
334 334
         });
335 335
 
@@ -345,7 +345,7 @@  discard block
 block discarded – undo
345 345
      */
346 346
     public function firstColumnWhere($attribute, $value)
347 347
     {
348
-        return Arr::first($this->columns(), function ($column, $columnKey) use ($attribute, $value) {
348
+        return Arr::first($this->columns(), function($column, $columnKey) use ($attribute, $value) {
349 349
             return isset($column[$attribute]) && $column[$attribute] == $value;
350 350
         });
351 351
     }
@@ -395,8 +395,8 @@  discard block
 block discarded – undo
395 395
      */
396 396
     public function countColumnsWithoutActions()
397 397
     {
398
-        return collect($this->columns())->filter(function ($column, $key) {
399
-            return ! isset($column['hasActions']) || $column['hasActions'] == false;
398
+        return collect($this->columns())->filter(function($column, $key) {
399
+            return !isset($column['hasActions']) || $column['hasActions'] == false;
400 400
         })->count();
401 401
     }
402 402
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/AutoSet.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@  discard block
 block discarded – undo
16 16
             $this->getDbColumnTypes();
17 17
         }
18 18
 
19
-        array_map(function ($field) {
19
+        array_map(function($field) {
20 20
             $new_field = [
21 21
                 'name'       => $field,
22 22
                 'label'      => $this->makeLabel($field),
@@ -28,11 +28,11 @@  discard block
 block discarded – undo
28 28
                 'autoset'    => true,
29 29
             ];
30 30
 
31
-            if (! isset($this->fields()[$field])) {
31
+            if (!isset($this->fields()[$field])) {
32 32
                 $this->addField($new_field);
33 33
             }
34 34
 
35
-            if (! in_array($field, $this->model->getHidden()) && ! in_array($field, $this->columns())) {
35
+            if (!in_array($field, $this->model->getHidden()) && !in_array($field, $this->columns())) {
36 36
                 $this->addColumn([
37 37
                     'name'    => $field,
38 38
                     'label'   => $this->makeLabel($field),
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
 
111 111
         $dbColumnTypes = $this->getDbColumnTypes();
112 112
 
113
-        if (! isset($dbColumnTypes[$fieldName])) {
113
+        if (!isset($dbColumnTypes[$fieldName])) {
114 114
             return 'text';
115 115
         }
116 116
 
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
168 168
         $types = ['enum' => 'string'];
169 169
         $platform = $this->getSchema()->getConnection()->getDoctrineSchemaManager()->getDatabasePlatform();
170 170
         foreach ($types as $type_key => $type_value) {
171
-            if (! $platform->hasDoctrineTypeMappingFor($type_key)) {
171
+            if (!$platform->hasDoctrineTypeMappingFor($type_key)) {
172 172
                 $platform->registerDoctrineTypeMapping($type_key, $type_value);
173 173
             }
174 174
         }
@@ -221,13 +221,13 @@  discard block
 block discarded – undo
221 221
     {
222 222
         $fillable = $this->model->getFillable();
223 223
 
224
-        if (! $this->driverIsSql()) {
224
+        if (!$this->driverIsSql()) {
225 225
             $columns = $fillable;
226 226
         } else {
227 227
             // Automatically-set columns should be both in the database, and in the $fillable variable on the Eloquent Model
228 228
             $columns = $this->model->getConnection()->getSchemaBuilder()->getColumnListing($this->model->getTable());
229 229
 
230
-            if (! empty($fillable)) {
230
+            if (!empty($fillable)) {
231 231
                 $columns = array_intersect($columns, $fillable);
232 232
             }
233 233
         }
Please login to merge, or discard this patch.