Fields - Code Metrics - Inspection of "[Feature] Added the ability to add bootstrap tabs..." - Laravel-Backpack/CRUD - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#289)

by Owen

created 2016-12-08 20:31 UTC

Fields A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	146
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

Metric	Value
dl	0
loc	146
rs	10
c	0
b	0
f	0
wmc	21
lcom	1
cbo	0

8 Methods

Rating	Name	Size	Complexity
C	addField()	41	7
A	addFields()	8	3
A	removeField()	17	3
A	removeFields()	8	3
A	checkIfFieldIsFirstOfItsType()	8	2
A	setFieldOrder()	4	1
A	setFieldsOrder()	4	1
A	orderFields()	4	1

<?php

namespace Backpack\CRUD\PanelTraits;

trait Fields
{
    // ------------
    // FIELDS
    // ------------

    /**
     * Add a field to the create/update form or both.
     *
     * @param string   $form    The form to add the field to (create/update/both)
     */
    public function addField($field, $form = 'both')
    {
        // if the field_defition_array array is a string, it means the programmer was lazy and has only passed the name
        // set some default values, so the field will still work
        if (is_string($field)) {
            $complete_field_array['name'] = $field;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        } else {
            $complete_field_array = $field;
        }

        // if the label is missing, we should set it
        if (! isset($complete_field_array['label'])) {
            $complete_field_array['label'] = ucfirst($complete_field_array['name']);
        }

        // if the field type is missing, we should set it
        if (! isset($complete_field_array['type'])) {
            $complete_field_array['type'] = $this->getFieldTypeFromDbColumnType($complete_field_array['name']);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }

        // store the field information into the correct variable on the CRUD object
        switch (strtolower($form)) {
            case 'create':
                $this->create_fields[$complete_field_array['name']] = $complete_field_array;
class MyClass { }

$x = new MyClass();
$x->foo = true;
                break;

            case 'update':
                $this->update_fields[$complete_field_array['name']] = $complete_field_array;
class MyClass { }

$x = new MyClass();
$x->foo = true;
                break;

            default:
                $this->create_fields[$complete_field_array['name']] = $complete_field_array;
                $this->update_fields[$complete_field_array['name']] = $complete_field_array;
                break;
        }

        // add to the tabset if there is one
        if ($this->getTabs()->count() > 0) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            $this->getTabs()->last()->fields->push(array_merge($complete_field_array, ['method' => strtolower($form)]));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }
    }

    public function addFields($fields, $form = 'both')
    {
        if (count($fields)) {
            foreach ($fields as $field) {
                $this->addField($field, $form);
            }
        }
    }

    /**
     * Remove a certain field from the create/update/both forms by its name.
     *
     * @param string $name Field name (as defined with the addField() procedure)
     * @param string $form update/create/both
     */
    public function removeField($name, $form = 'both')
    {
        switch (strtolower($form)) {
            case 'create':
                array_forget($this->create_fields, $name);
                break;

            case 'update':
                array_forget($this->update_fields, $name);
                break;

            default:
                array_forget($this->create_fields, $name);
                array_forget($this->update_fields, $name);
                break;
        }
    }

    /**
     * Remove many fields from the create/update/both forms by their name.
     *
     * @param array  $array_of_names A simple array of the names of the fields to be removed.
     * @param string $form           update/create/both
     */
    public function removeFields($array_of_names, $form = 'both')

    {
        if (! empty($array_of_names)) {
            foreach ($array_of_names as $name) {
                $this->removeField($name, $form);
            }
        }
    }

    /**
     * Check if field is the first of its type in the given fields array.
     * It's used in each field_type.blade.php to determine wether to push the css and js content or not (we only need to push the js and css for a field the first time it's loaded in the form, not any subsequent times).

     *
     * @param array $field        The current field being tested if it's the first of its type.
     * @param array $fields_array All the fields in that particular form.
     *
     * @return bool true/false
     */
    public function checkIfFieldIsFirstOfItsType($field, $fields_array)

    {
        if ($field['name'] == $this->getFirstOfItsTypeInArray($field['type'], $fields_array)['name']) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            return true;
        }

        return false;
    }

    /**
     * Order the fields in a certain way.
     *
     * @param [string] Column name.
     * @param [attributes and values array]
     */
    public function setFieldOrder($fields)

    {
        // TODO
    }

    // ALIAS of setFieldOrder($fields)
    public function setFieldsOrder($fields)
    {
        $this->setFieldOrder($fields);
    }

    // ------------
    // TONE FUNCTIONS - UNDOCUMENTED, UNTESTED, SOME MAY BE USED
    // ------------
    // TODO: check them

    public function orderFields($order)
    {
        $this->setSort('fields', (array) $order);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1			<?php
2
3			namespace Backpack\CRUD\PanelTraits;
4
5			trait Fields
6			{
7			// ------------
8			// FIELDS
9			// ------------
10
11			/**
12			* Add a field to the create/update form or both.
13			*
14			* @param string $form The form to add the field to (create/update/both)
15			*/
16			public function addField($field, $form = 'both')
17			{
18			// if the field_defition_array array is a string, it means the programmer was lazy and has only passed the name
19			// set some default values, so the field will still work
20			if (is_string($field)) {
21			$complete_field_array['name'] = $field;
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-06-16 14:52 UTC by Report Bug Copy Issue Report `$complete_field_array` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$complete_field_array = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
22			} else {
23			$complete_field_array = $field;
24			}
25
26			// if the label is missing, we should set it
27			if (! isset($complete_field_array['label'])) {
28			$complete_field_array['label'] = ucfirst($complete_field_array['name']);
29			}
30
31			// if the field type is missing, we should set it
32			if (! isset($complete_field_array['type'])) {
33			$complete_field_array['type'] = $this->getFieldTypeFromDbColumnType($complete_field_array['name']);
			0 ignored issues – show Bug introduced 2016-06-16 14:52 UTC by Report Bug Copy Issue Report It seems like `getFieldTypeFromDbColumnType()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
34			}
35
36			// store the field information into the correct variable on the CRUD object
37			switch (strtolower($form)) {
38			case 'create':
39			$this->create_fields[$complete_field_array['name']] = $complete_field_array;
			0 ignored issues – show Bug introduced 2016-06-16 14:52 UTC by Report Bug Copy Issue Report The property `create_fields` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
40			break;
41
42			case 'update':
43			$this->update_fields[$complete_field_array['name']] = $complete_field_array;
			0 ignored issues – show Bug introduced 2016-06-16 14:52 UTC by Report Bug Copy Issue Report The property `update_fields` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
44			break;
45
46			default:
47			$this->create_fields[$complete_field_array['name']] = $complete_field_array;
48			$this->update_fields[$complete_field_array['name']] = $complete_field_array;
49			break;
50			}
51
52			// add to the tabset if there is one
53			if ($this->getTabs()->count() > 0) {
			0 ignored issues – show Bug introduced 2016-12-05 17:31 UTC by Report Bug Copy Issue Report It seems like `getTabs()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
54			$this->getTabs()->last()->fields->push(array_merge($complete_field_array, ['method' => strtolower($form)]));
			0 ignored issues – show Bug introduced 2016-12-05 17:31 UTC by Report Bug Copy Issue Report It seems like `getTabs()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
55			}
56			}
57
58			public function addFields($fields, $form = 'both')
59			{
60			if (count($fields)) {
61			foreach ($fields as $field) {
62			$this->addField($field, $form);
63			}
64			}
65			}
66
67			/**
68			* Remove a certain field from the create/update/both forms by its name.
69			*
70			* @param string $name Field name (as defined with the addField() procedure)
71			* @param string $form update/create/both
72			*/
73			public function removeField($name, $form = 'both')
74			{
75			switch (strtolower($form)) {
76			case 'create':
77			array_forget($this->create_fields, $name);
78			break;
79
80			case 'update':
81			array_forget($this->update_fields, $name);
82			break;
83
84			default:
85			array_forget($this->create_fields, $name);
86			array_forget($this->update_fields, $name);
87			break;
88			}
89			}
90
91			/**
92			* Remove many fields from the create/update/both forms by their name.
93			*
94			* @param array $array_of_names A simple array of the names of the fields to be removed.
95			* @param string $form update/create/both
96			*/
97			public function removeFields($array_of_names, $form = 'both')
			0 ignored issues – show Coding Style Naming introduced 2016-06-16 14:52 UTC by Report Bug Copy Issue Report The parameter $array_of_names is not named in camelCase. This check marks parameter names that have not been written in camelCase. In camelCase names are written without any punctuation, the start of each new word being marked by a capital letter. Thus the name database connection string becomes `databaseConnectionString`. Loading history...
98			{
99			if (! empty($array_of_names)) {
100			foreach ($array_of_names as $name) {
101			$this->removeField($name, $form);
102			}
103			}
104			}
105
106			/**
107			* Check if field is the first of its type in the given fields array.
108			* It's used in each field_type.blade.php to determine wether to push the css and js content or not (we only need to push the js and css for a field the first time it's loaded in the form, not any subsequent times).
			0 ignored issues – show Coding Style introduced 2016-06-16 14:52 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 219 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
109			*
110			* @param array $field The current field being tested if it's the first of its type.
111			* @param array $fields_array All the fields in that particular form.
112			*
113			* @return bool true/false
114			*/
115			public function checkIfFieldIsFirstOfItsType($field, $fields_array)
			0 ignored issues – show Coding Style Naming introduced 2016-06-16 14:52 UTC by Report Bug Copy Issue Report The parameter $fields_array is not named in camelCase. This check marks parameter names that have not been written in camelCase. In camelCase names are written without any punctuation, the start of each new word being marked by a capital letter. Thus the name database connection string becomes `databaseConnectionString`. Loading history...
116			{
117			if ($field['name'] == $this->getFirstOfItsTypeInArray($field['type'], $fields_array)['name']) {
			0 ignored issues – show Bug introduced 2016-06-16 14:52 UTC by Report Bug Copy Issue Report It seems like `getFirstOfItsTypeInArray()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Unused Code introduced 2016-06-16 14:52 UTC by Report Bug Copy Issue Report This `if` statement, and the following `return` statement can be replaced with `return $field['name'] ==...$fields_array)['name'];`. Loading history...
118			return true;
119			}
120
121			return false;
122			}
123
124			/**
125			* Order the fields in a certain way.
126			*
127			* @param [string] Column name.
128			* @param [attributes and values array]
129			*/
130			public function setFieldOrder($fields)
			0 ignored issues – show Unused Code introduced 2016-06-16 14:52 UTC by Report Bug Copy Issue Report The parameter `$fields` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
131			{
132			// TODO
133			}
134
135			// ALIAS of setFieldOrder($fields)
136			public function setFieldsOrder($fields)
137			{
138			$this->setFieldOrder($fields);
139			}
140
141			// ------------
142			// TONE FUNCTIONS - UNDOCUMENTED, UNTESTED, SOME MAY BE USED
143			// ------------
144			// TODO: check them
145
146			public function orderFields($order)
147			{
148			$this->setSort('fields', (array) $order);
			0 ignored issues – show Bug introduced 2016-06-16 14:52 UTC by Report Bug Copy Issue Report It seems like `setSort()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
149			}
150			}
151

Laravel-Backpack / CRUD

Scrutinizer GitHub App not installed

Pull Request — master (#289)

Fields A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

8 Methods

Duplication Side-by-Side

Filter issues like