Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Test Setup Failed
Pull Request — master (#2940)
by Cristian
11:18
created
src/BackpackServiceProvider.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -58,18 +58,18 @@  discard block
 block discarded – undo
58 58
     public function register()
59 59
     {
60 60
         // Bind the CrudPanel object to Laravel's service container
61
-        $this->app->singleton('crud', function ($app) {
61
+        $this->app->singleton('crud', function($app) {
62 62
             return new CrudPanel($app);
63 63
         });
64 64
 
65 65
         // Bind the widgets collection object to Laravel's service container
66
-        $this->app->singleton('widgets', function ($app) {
66
+        $this->app->singleton('widgets', function($app) {
67 67
             return new Collection();
68 68
         });
69 69
 
70 70
         // load a macro for Route,
71 71
         // helps developers load all routes for a CRUD resource in one line
72
-        if (! Route::hasMacro('crud')) {
72
+        if (!Route::hasMacro('crud')) {
73 73
             $this->addRouteMacro();
74 74
         }
75 75
 
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
         $middleware_key = config('backpack.base.middleware_key');
86 86
         $middleware_class = config('backpack.base.middleware_class');
87 87
 
88
-        if (! is_array($middleware_class)) {
88
+        if (!is_array($middleware_class)) {
89 89
             $router->pushMiddlewareToGroup($middleware_key, $middleware_class);
90 90
 
91 91
             return;
@@ -187,7 +187,7 @@  discard block
 block discarded – undo
187 187
      */
188 188
     private function addRouteMacro()
189 189
     {
190
-        Route::macro('crud', function ($name, $controller) {
190
+        Route::macro('crud', function($name, $controller) {
191 191
             // put together the route name prefix,
192 192
             // as passed to the Route::group() statements
193 193
             $routeName = '';
@@ -242,7 +242,7 @@  discard block
 block discarded – undo
242 242
         $operationConfigs = scandir(__DIR__.'/config/backpack/operations/');
243 243
         $operationConfigs = array_diff($operationConfigs, ['.', '..']);
244 244
 
245
-        if (! count($operationConfigs)) {
245
+        if (!count($operationConfigs)) {
246 246
             return;
247 247
         }
248 248
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/AutoSet.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -16,8 +16,8 @@  discard block
 block discarded – undo
16 16
             $this->getDbColumnTypes();
17 17
         }
18 18
 
19
-        array_map(function ($field) use ($setFields, $setColumns) {
20
-            if ($setFields && ! isset($this->getCleanStateFields()[$field])) {
19
+        array_map(function($field) use ($setFields, $setColumns) {
20
+            if ($setFields && !isset($this->getCleanStateFields()[$field])) {
21 21
                 $this->addField([
22 22
                     'name'       => $field,
23 23
                     'label'      => $this->makeLabel($field),
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
                 ]);
31 31
             }
32 32
 
33
-            if ($setColumns && ! in_array($field, $this->model->getHidden()) && ! isset($this->columns()[$field])) {
33
+            if ($setColumns && !in_array($field, $this->model->getHidden()) && !isset($this->columns()[$field])) {
34 34
                 $this->addColumn([
35 35
                     'name'    => $field,
36 36
                     'label'   => $this->makeLabel($field),
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
 
108 108
         $dbColumnTypes = $this->getDbColumnTypes();
109 109
 
110
-        if (! isset($dbColumnTypes[$fieldName])) {
110
+        if (!isset($dbColumnTypes[$fieldName])) {
111 111
             return 'text';
112 112
         }
113 113
 
@@ -165,7 +165,7 @@  discard block
 block discarded – undo
165 165
         $types = ['enum' => 'string'];
166 166
         $platform = $this->getSchema()->getConnection()->getDoctrineSchemaManager()->getDatabasePlatform();
167 167
         foreach ($types as $type_key => $type_value) {
168
-            if (! $platform->hasDoctrineTypeMappingFor($type_key)) {
168
+            if (!$platform->hasDoctrineTypeMappingFor($type_key)) {
169 169
                 $platform->registerDoctrineTypeMapping($type_key, $type_value);
170 170
             }
171 171
         }
@@ -216,13 +216,13 @@  discard block
 block discarded – undo
216 216
     {
217 217
         $fillable = $this->model->getFillable();
218 218
 
219
-        if (! $this->driverIsSql()) {
219
+        if (!$this->driverIsSql()) {
220 220
             $columns = $fillable;
221 221
         } else {
222 222
             // Automatically-set columns should be both in the database, and in the $fillable variable on the Eloquent Model
223 223
             $columns = $this->model->getConnection()->getSchemaBuilder()->getColumnListing($this->model->getTable());
224 224
 
225
-            if (! empty($fillable)) {
225
+            if (!empty($fillable)) {
226 226
                 $columns = array_intersect($columns, $fillable);
227 227
             }
228 228
         }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Fields.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
      */
89 89
     public function afterField($targetFieldName)
90 90
     {
91
-        $this->transformFields(function ($fields) use ($targetFieldName) {
91
+        $this->transformFields(function($fields) use ($targetFieldName) {
92 92
             return $this->moveField($fields, $targetFieldName, false);
93 93
         });
94 94
     }
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
      */
101 101
     public function beforeField($targetFieldName)
102 102
     {
103
-        $this->transformFields(function ($fields) use ($targetFieldName) {
103
+        $this->transformFields(function($fields) use ($targetFieldName) {
104 104
             return $this->moveField($fields, $targetFieldName, true);
105 105
         });
106 106
     }
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
      */
113 113
     public function makeFirstField()
114 114
     {
115
-        if (! $this->fields()) {
115
+        if (!$this->fields()) {
116 116
             return false;
117 117
         }
118 118
 
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
      */
128 128
     public function removeField($name)
129 129
     {
130
-        $this->transformFields(function ($fields) use ($name) {
130
+        $this->transformFields(function($fields) use ($name) {
131 131
             Arr::forget($fields, $name);
132 132
 
133 133
             return $fields;
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
141 141
      */
142 142
     public function removeFields($array_of_names)
143 143
     {
144
-        if (! empty($array_of_names)) {
144
+        if (!empty($array_of_names)) {
145 145
             foreach ($array_of_names as $name) {
146 146
                 $this->removeField($name);
147 147
             }
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
154 154
     public function removeAllFields()
155 155
     {
156 156
         $current_fields = $this->getCleanStateFields();
157
-        if (! empty($current_fields)) {
157
+        if (!empty($current_fields)) {
158 158
             foreach ($current_fields as $field) {
159 159
                 $this->removeField($field['name']);
160 160
             }
@@ -246,7 +246,7 @@  discard block
 block discarded – undo
246 246
                 $jsonCastables = ['array', 'object', 'json'];
247 247
                 $fieldCasting = $casted_attributes[$field['name']];
248 248
 
249
-                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && ! empty($data[$field['name']]) && ! is_array($data[$field['name']])) {
249
+                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && !empty($data[$field['name']]) && !is_array($data[$field['name']])) {
250 250
                     try {
251 251
                         $data[$field['name']] = json_decode($data[$field['name']]);
252 252
                     } catch (\Exception $e) {
@@ -275,7 +275,7 @@  discard block
 block discarded – undo
275 275
      */
276 276
     public function orderFields($order)
277 277
     {
278
-        $this->transformFields(function ($fields) use ($order) {
278
+        $this->transformFields(function($fields) use ($order) {
279 279
             return $this->applyOrderToFields($fields, $order);
280 280
         });
281 281
     }
@@ -301,7 +301,7 @@  discard block
 block discarded – undo
301 301
     public function hasUploadFields()
302 302
     {
303 303
         $fields = $this->getCleanStateFields();
304
-        $upload_fields = Arr::where($fields, function ($value, $key) {
304
+        $upload_fields = Arr::where($fields, function($value, $key) {
305 305
             return isset($value['upload']) && $value['upload'] == true;
306 306
         });
307 307
 
@@ -364,7 +364,7 @@  discard block
 block discarded – undo
364 364
         $alreadyLoaded = $this->getLoadedFieldTypes();
365 365
         $type = $this->getFieldTypeWithNamespace($field);
366 366
 
367
-        if (! in_array($type, $this->getLoadedFieldTypes(), true)) {
367
+        if (!in_array($type, $this->getLoadedFieldTypes(), true)) {
368 368
             $alreadyLoaded[] = $type;
369 369
             $this->setLoadedFieldTypes($alreadyLoaded);
370 370
 
@@ -405,7 +405,7 @@  discard block
 block discarded – undo
405 405
      */
406 406
     public function fieldTypeNotLoaded($field)
407 407
     {
408
-        return ! in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
408
+        return !in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
409 409
     }
410 410
 
411 411
     /**
@@ -445,7 +445,7 @@  discard block
 block discarded – undo
445 445
      */
446 446
     public function hasFieldWhere($attribute, $value)
447 447
     {
448
-        $match = Arr::first($this->getCleanStateFields(), function ($field, $fieldKey) use ($attribute, $value) {
448
+        $match = Arr::first($this->getCleanStateFields(), function($field, $fieldKey) use ($attribute, $value) {
449 449
             return isset($field[$attribute]) && $field[$attribute] == $value;
450 450
         });
451 451
 
@@ -461,7 +461,7 @@  discard block
 block discarded – undo
461 461
      */
462 462
     public function firstFieldWhere($attribute, $value)
463 463
     {
464
-        return Arr::first($this->getCleanStateFields(), function ($field, $fieldKey) use ($attribute, $value) {
464
+        return Arr::first($this->getCleanStateFields(), function($field, $fieldKey) use ($attribute, $value) {
465 465
             return isset($field[$attribute]) && $field[$attribute] == $value;
466 466
         });
467 467
     }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/ColumnsProtectedMethods.php 1 patch
Spacing   +7 added lines, -8 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
             $column = ['name' => $column];
50 50
         }
51 51
 
52
-        if (is_array($column) && ! isset($column['name'])) {
52
+        if (is_array($column) && !isset($column['name'])) {
53 53
             $column['name'] = 'anonymous_column_'.Str::random(5);
54 54
         }
55 55
 
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
      */
66 66
     protected function makeSureColumnHasLabel($column)
67 67
     {
68
-        if (! isset($column['label'])) {
68
+        if (!isset($column['label'])) {
69 69
             $column['label'] = mb_ucfirst($this->makeLabel($column['name']));
70 70
         }
71 71
 
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
      */
147 147
     protected function makeSureColumnHasKey($column)
148 148
     {
149
-        if (! isset($column['key'])) {
149
+        if (!isset($column['key'])) {
150 150
             $column['key'] = str_replace('.', '__', $column['name']);
151 151
         }
152 152
 
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
      */
165 165
     protected function makeSureColumnHasWrapper($column)
166 166
     {
167
-        if (! isset($column['wrapper'])) {
167
+        if (!isset($column['wrapper'])) {
168 168
             $column['wrapper'] = [];
169 169
         }
170 170
 
@@ -255,7 +255,7 @@  discard block
 block discarded – undo
255 255
     {
256 256
         // if this is a relation type field and no corresponding model was specified,
257 257
         // get it from the relation method defined in the main model
258
-        if (isset($column['entity']) && $column['entity'] !== false && ! isset($column['model'])) {
258
+        if (isset($column['entity']) && $column['entity'] !== false && !isset($column['model'])) {
259 259
             $column['model'] = $this->getRelationModel($column['entity']);
260 260
         }
261 261
 
@@ -276,8 +276,7 @@  discard block
 block discarded – undo
276 276
         $columnsArray = $this->columns();
277 277
 
278 278
         if (array_key_exists($targetColumnName, $columnsArray)) {
279
-            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) :
280
-                array_search($targetColumnName, array_keys($columnsArray)) + 1;
279
+            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) : array_search($targetColumnName, array_keys($columnsArray)) + 1;
281 280
 
282 281
             $element = array_pop($columnsArray);
283 282
             $beginningPart = array_slice($columnsArray, 0, $targetColumnPosition, true);
@@ -299,7 +298,7 @@  discard block
 block discarded – undo
299 298
     {
300 299
         static $cache = [];
301 300
 
302
-        if (! $this->driverIsSql()) {
301
+        if (!$this->driverIsSql()) {
303 302
             return true;
304 303
         }
305 304
 
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/ShowOperation.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -30,25 +30,25 @@
 block discarded – undo
30 30
         $this->crud->allowAccess('show');
31 31
         $this->crud->setOperationSetting('setFromDb', true);
32 32
 
33
-        $this->crud->operation('show', function () {
33
+        $this->crud->operation('show', function() {
34 34
             $this->crud->loadDefaultOperationSettingsFromConfig();
35 35
 
36
-            if (! method_exists($this, 'setupShowOperation')) {
36
+            if (!method_exists($this, 'setupShowOperation')) {
37 37
                 $this->autoSetupShowOperation();
38 38
             }
39 39
         });
40 40
 
41
-        $this->crud->operation('list', function () {
41
+        $this->crud->operation('list', function() {
42 42
             $this->crud->addButton('line', 'show', 'view', 'crud::buttons.show', 'beginning');
43 43
         });
44 44
 
45
-        $this->crud->operation(['create', 'update'], function () {
45
+        $this->crud->operation(['create', 'update'], function() {
46 46
             $this->crud->addSaveAction([
47 47
                 'name' => 'save_and_preview',
48
-                'visible' => function ($crud) {
48
+                'visible' => function($crud) {
49 49
                     return $crud->hasAccess('show');
50 50
                 },
51
-                'redirect' => function ($crud, $request, $itemId = null) {
51
+                'redirect' => function($crud, $request, $itemId = null) {
52 52
                     $itemId = $itemId ?: $request->input('id');
53 53
                     $redirectUrl = $crud->route.'/'.$itemId.'/show';
54 54
                     if ($request->has('_locale')) {
Please login to merge, or discard this patch.
src/app/Models/Traits/HasRelationshipFields.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
         [$conn, $table] = self::getConnectionAndTable();
68 68
 
69 69
         // MongoDB columns are alway nullable
70
-        if (! in_array($conn->getConfig()['driver'], CRUD::getSqlDriverList())) {
70
+        if (!in_array($conn->getConfig()['driver'], CRUD::getSqlDriverList())) {
71 71
             return true;
72 72
         }
73 73
 
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
             // check for NOT NULL
78 78
             $notNull = $column->getNotnull();
79 79
             // return the value of nullable (aka the inverse of NOT NULL)
80
-            return ! $notNull;
80
+            return !$notNull;
81 81
         } catch (\Exception $e) {
82 82
             return true;
83 83
         }
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
         [$conn, $table] = self::getConnectionAndTable();
95 95
 
96 96
         // MongoDB columns don't have default values
97
-        if (! in_array($conn->getConfig()['driver'], CRUD::getSqlDriverList())) {
97
+        if (!in_array($conn->getConfig()['driver'], CRUD::getSqlDriverList())) {
98 98
             return false;
99 99
         }
100 100
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Validation.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -29,10 +29,10 @@  discard block
 block discarded – undo
29 29
         // construct the validation rules array
30 30
         // (eg. ['name' => 'required|min:2'])
31 31
         $rules = collect($fields)
32
-                    ->filter(function ($value, $key) {
32
+                    ->filter(function($value, $key) {
33 33
                         // only keep fields where 'validationRules' attribute is defined
34 34
                         return array_key_exists('validationRules', $value);
35
-                    })->map(function ($item, $key) {
35
+                    })->map(function($item, $key) {
36 36
                         // only keep the rules, not the entire field definition
37 37
                         return $item['validationRules'];
38 38
                     })->toArray();
@@ -41,10 +41,10 @@  discard block
 block discarded – undo
41 41
         // (eg. ['title.required' => 'You gotta write smth man.'])
42 42
         $messages = [];
43 43
         collect($fields)
44
-                    ->filter(function ($value, $key) {
44
+                    ->filter(function($value, $key) {
45 45
                         // only keep fields where 'validationMessages' attribute is defined
46 46
                         return array_key_exists('validationMessages', $value);
47
-                    })->each(function ($item, $key) use (&$messages) {
47
+                    })->each(function($item, $key) use (&$messages) {
48 48
                         foreach ($item['validationMessages'] as $rule => $message) {
49 49
                             $messages[$key.'.'.$rule] = $message;
50 50
                         }
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
      */
75 75
     public function setValidation($classOrRulesArray = false, $messages = [])
76 76
     {
77
-        if (! $classOrRulesArray) {
77
+        if (!$classOrRulesArray) {
78 78
             $this->setValidationFromFields();
79 79
         } elseif (is_array($classOrRulesArray)) {
80 80
             $this->setValidationFromArray($classOrRulesArray, $messages);
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
      */
203 203
     public function isRequired($inputKey)
204 204
     {
205
-        if (! $this->hasOperationSetting('requiredFields')) {
205
+        if (!$this->hasOperationSetting('requiredFields')) {
206 206
             return false;
207 207
         }
208 208
 
Please login to merge, or discard this patch.
src/resources/views/crud/fields/table.blade.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
 <?php
4 4
     $max = isset($field['max']) && (int) $field['max'] > 0 ? $field['max'] : -1;
5 5
     $min = isset($field['min']) && (int) $field['min'] > 0 ? $field['min'] : -1;
6
-    $item_name = strtolower(isset($field['entity_singular']) && ! empty($field['entity_singular']) ? $field['entity_singular'] : $field['label']);
6
+    $item_name = strtolower(isset($field['entity_singular']) && !empty($field['entity_singular']) ? $field['entity_singular'] : $field['label']);
7 7
 
8 8
     $items = old_empty_or_null($field['name'], '') ?? $field['value'] ?? $field['default'] ?? '';
9 9
 
@@ -15,12 +15,12 @@  discard block
 block discarded – undo
15 15
         } else {
16 16
             $items = '[]';
17 17
         }
18
-    } elseif (is_string($items) && ! is_array(json_decode($items))) {
18
+    } elseif (is_string($items) && !is_array(json_decode($items))) {
19 19
         $items = '[]';
20 20
     }
21 21
 
22 22
     // make sure columns are defined
23
-    if (! isset($field['columns'])) {
23
+    if (!isset($field['columns'])) {
24 24
         $field['columns'] = ['value' => 'Value'];
25 25
     }
26 26
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/FieldsProtectedMethods.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
      */
69 69
     public function overwriteFieldNameFromDotNotationToArray($field)
70 70
     {
71
-        if (! is_array($field['name']) && strpos($field['name'], '.') !== false) {
71
+        if (!is_array($field['name']) && strpos($field['name'], '.') !== false) {
72 72
             $entity_array = explode('.', $field['name']);
73 73
             $name_string = '';
74 74
 
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
             return ['name' => $field];
111 111
         }
112 112
 
113
-        if (is_array($field) && ! isset($field['name'])) {
113
+        if (is_array($field) && !isset($field['name'])) {
114 114
             abort(500, 'All fields must have their name defined');
115 115
         }
116 116
 
@@ -173,7 +173,7 @@  discard block
 block discarded – undo
173 173
     {
174 174
         // if there's a model defined, but no attribute
175 175
         // guess an attribute using the identifiableAttribute functionality in CrudTrait
176
-        if (isset($field['model']) && ! isset($field['attribute']) && method_exists($field['model'], 'identifiableAttribute')) {
176
+        if (isset($field['model']) && !isset($field['attribute']) && method_exists($field['model'], 'identifiableAttribute')) {
177 177
             $field['attribute'] = call_user_func([(new $field['model']()), 'identifiableAttribute']);
178 178
         }
179 179
 
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
189 189
      */
190 190
     protected function makeSureFieldHasLabel($field)
191 191
     {
192
-        if (! isset($field['label'])) {
192
+        if (!isset($field['label'])) {
193 193
             $name = is_array($field['name']) ? $field['name'][0] : $field['name'];
194 194
             $name = str_replace('_id', '', $name);
195 195
             $field['label'] = mb_ucfirst(str_replace('_', ' ', $name));
@@ -207,7 +207,7 @@  discard block
 block discarded – undo
207 207
      */
208 208
     protected function makeSureFieldHasType($field)
209 209
     {
210
-        if (! isset($field['type'])) {
210
+        if (!isset($field['type'])) {
211 211
             $field['type'] = isset($field['relation_type']) ? 'relationship' : $this->inferFieldTypeFromDbColumnType($field['name']);
212 212
         }
213 213
 
@@ -224,7 +224,7 @@  discard block
 block discarded – undo
224 224
     {
225 225
         // if a tab was mentioned, we should enable it
226 226
         if (isset($field['tab'])) {
227
-            if (! $this->tabsEnabled()) {
227
+            if (!$this->tabsEnabled()) {
228 228
                 $this->enableTabs();
229 229
             }
230 230
         }
Please login to merge, or discard this patch.