Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Test Setup Failed
Pull Request — master (#2940)
by Cristian
11:18
created
config/database/migrations/2017_09_08_000001_create_addresses_table.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@
 block discarded – undo
13 13
      */
14 14
     public function up()
15 15
     {
16
-        Schema::create('addresses', function (Blueprint $table) {
16
+        Schema::create('addresses', function(Blueprint $table) {
17 17
             $table->increments('id');
18 18
             $table->integer('account_details_id')->unsigned();
19 19
             $table->string('city')->nullable();
Please login to merge, or discard this patch.
tests/Unit/Http/CrudControllerTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
 
27 27
         $app['router']->get('admin/users', "$controller@index")->name('admin.users.index');
28 28
 
29
-        $app->singleton('crud', function ($app) {
29
+        $app->singleton('crud', function($app) {
30 30
             return new CrudPanel($app);
31 31
         });
32 32
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Columns.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
      */
115 115
     public function makeFirstColumn()
116 116
     {
117
-        if (! $this->columns()) {
117
+        if (!$this->columns()) {
118 118
             return false;
119 119
         }
120 120
 
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
      */
160 160
     public function removeColumns($columns)
161 161
     {
162
-        if (! empty($columns)) {
162
+        if (!empty($columns)) {
163 163
             foreach ($columns as $columnKey) {
164 164
                 $this->removeColumn($columnKey);
165 165
             }
@@ -252,8 +252,8 @@  discard block
 block discarded – undo
252 252
     {
253 253
         $columns = $this->columns();
254 254
 
255
-        return collect($columns)->pluck('entity')->reject(function ($value, $key) {
256
-            return ! $value;
255
+        return collect($columns)->pluck('entity')->reject(function($value, $key) {
256
+            return !$value;
257 257
         })->toArray();
258 258
     }
259 259
 
@@ -329,7 +329,7 @@  discard block
 block discarded – undo
329 329
      */
330 330
     public function hasColumnWhere($attribute, $value)
331 331
     {
332
-        $match = Arr::first($this->columns(), function ($column, $columnKey) use ($attribute, $value) {
332
+        $match = Arr::first($this->columns(), function($column, $columnKey) use ($attribute, $value) {
333 333
             return isset($column[$attribute]) && $column[$attribute] == $value;
334 334
         });
335 335
 
@@ -345,7 +345,7 @@  discard block
 block discarded – undo
345 345
      */
346 346
     public function firstColumnWhere($attribute, $value)
347 347
     {
348
-        return Arr::first($this->columns(), function ($column, $columnKey) use ($attribute, $value) {
348
+        return Arr::first($this->columns(), function($column, $columnKey) use ($attribute, $value) {
349 349
             return isset($column[$attribute]) && $column[$attribute] == $value;
350 350
         });
351 351
     }
@@ -395,8 +395,8 @@  discard block
 block discarded – undo
395 395
      */
396 396
     public function countColumnsWithoutActions()
397 397
     {
398
-        return collect($this->columns())->filter(function ($column, $key) {
399
-            return ! isset($column['hasActions']) || $column['hasActions'] == false;
398
+        return collect($this->columns())->filter(function($column, $key) {
399
+            return !isset($column['hasActions']) || $column['hasActions'] == false;
400 400
         })->count();
401 401
     }
402 402
 
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/FetchOperation.php 1 patch
Spacing   +6 added lines, -8 removed lines patch added patch discarded remove patch
@@ -46,8 +46,8 @@  discard block
 block discarded – undo
46 46
         // otherwise assume the arguments are actually the configuration array
47 47
         $config = [];
48 48
 
49
-        if (! is_array($arg)) {
50
-            if (! class_exists($arg)) {
49
+        if (!is_array($arg)) {
50
+            if (!class_exists($arg)) {
51 51
                 return response()->json(['error' => 'Class: '.$arg.' does not exists'], 500);
52 52
             }
53 53
             $config['model'] = $arg;
@@ -77,8 +77,7 @@  discard block
 block discarded – undo
77 77
 
78 78
         if ($search_string === false) {
79 79
             return ($config['paginate'] !== false) ?
80
-            $config['query']->paginate($config['paginate']) :
81
-            $config['query']->get();
80
+            $config['query']->paginate($config['paginate']) : $config['query']->get();
82 81
         }
83 82
 
84 83
         $textColumnTypes = ['string', 'json_string', 'text', 'longText', 'json_array', 'json'];
@@ -89,8 +88,8 @@  discard block
 block discarded – undo
89 88
         // .... 'query' => function($model) { return $model->where('active', 1); }
90 89
         // So it reads: SELECT ... WHERE active = 1 AND (XXX = x OR YYY = y) and not SELECT ... WHERE active = 1 AND XXX = x OR YYY = y;
91 90
 
92
-        if (! empty($config['query']->getQuery()->wheres)) {
93
-            $config['query'] = $config['query']->where(function ($query) use ($model_instance, $config, $search_string, $textColumnTypes) {
91
+        if (!empty($config['query']->getQuery()->wheres)) {
92
+            $config['query'] = $config['query']->where(function($query) use ($model_instance, $config, $search_string, $textColumnTypes) {
94 93
                 foreach ((array) $config['searchable_attributes'] as $k => $searchColumn) {
95 94
                     $operation = ($k == 0) ? 'where' : 'orWhere';
96 95
                     $columnType = $model_instance->getColumnType($searchColumn);
@@ -122,7 +121,6 @@  discard block
 block discarded – undo
122 121
 
123 122
         // return the results with or without pagination
124 123
         return ($config['paginate'] !== false) ?
125
-                    $config['query']->paginate($config['paginate']) :
126
-                    $config['query']->get();
124
+                    $config['query']->paginate($config['paginate']) : $config['query']->get();
127 125
     }
128 126
 }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Read.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
      */
57 57
     public function getEntry($id)
58 58
     {
59
-        if (! $this->entry) {
59
+        if (!$this->entry) {
60 60
             $this->entry = $this->model->findOrFail($id);
61 61
             $this->entry = $this->entry->withFakes();
62 62
         }
@@ -258,7 +258,7 @@  discard block
 block discarded – undo
258 258
                 // we will apply the same labels as the values to the menu if developer didn't
259 259
                 $this->abortIfInvalidPageLength($menu[0]);
260 260
 
261
-                if (! isset($menu[1]) || ! is_array($menu[1])) {
261
+                if (!isset($menu[1]) || !is_array($menu[1])) {
262 262
                     $menu[1] = $menu[0];
263 263
                 }
264 264
             } else {
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/ListOperation.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
     {
42 42
         $this->crud->allowAccess('list');
43 43
 
44
-        $this->crud->operation('list', function () {
44
+        $this->crud->operation('list', function() {
45 45
             $this->crud->loadDefaultOperationSettingsFromConfig();
46 46
         });
47 47
     }
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
                 $column_number = (int) $order['column'];
100 100
                 $column_direction = (strtolower((string) $order['dir']) == 'asc' ? 'ASC' : 'DESC');
101 101
                 $column = $this->crud->findColumnById($column_number);
102
-                if ($column['tableColumn'] && ! isset($column['orderLogic'])) {
102
+                if ($column['tableColumn'] && !isset($column['orderLogic'])) {
103 103
                     // apply the current orderBy rules
104 104
                     $this->crud->orderByWithPrefix($column['name'], $column_direction);
105 105
                 }
@@ -119,12 +119,12 @@  discard block
 block discarded – undo
119 119
         $table = $this->crud->model->getTable();
120 120
         $key = $this->crud->model->getKeyName();
121 121
 
122
-        $hasOrderByPrimaryKey = collect($orderBy)->some(function ($item) use ($key, $table) {
122
+        $hasOrderByPrimaryKey = collect($orderBy)->some(function($item) use ($key, $table) {
123 123
             return (isset($item['column']) && $item['column'] === $key)
124 124
                 || (isset($item['sql']) && str_contains($item['sql'], "$table.$key"));
125 125
         });
126 126
 
127
-        if (! $hasOrderByPrimaryKey) {
127
+        if (!$hasOrderByPrimaryKey) {
128 128
             $this->crud->orderByWithPrefix($this->crud->model->getKeyName(), 'DESC');
129 129
         }
130 130
 
Please login to merge, or discard this patch.
src/app/Console/Commands/AddCustomRouteContent.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
 
84 84
         // otherwise, in case the last line HAS been modified
85 85
         // return the last line that has an ending in it
86
-        $possible_end_lines = array_filter($file_lines, function ($k) {
86
+        $possible_end_lines = array_filter($file_lines, function($k) {
87 87
             return strpos($k, '});') === 0;
88 88
         });
89 89
 
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
      */
105 105
     private function getLastLineNumberThatContains($needle, $haystack)
106 106
     {
107
-        $matchingLines = array_filter($haystack, function ($k) use ($needle) {
107
+        $matchingLines = array_filter($haystack, function($k) use ($needle) {
108 108
             return strpos($k, $needle) !== false;
109 109
         });
110 110
 
Please login to merge, or discard this patch.
src/app/Console/Commands/RequireDevTools.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
         // Check if auth exists
49 49
         $details = null;
50 50
         $process = new Process(['composer', 'config', 'http-basic.backpackforlaravel.com']);
51
-        $process->run(function ($type, $buffer) use (&$details) {
51
+        $process->run(function($type, $buffer) use (&$details) {
52 52
             if ($type !== Process::ERR && $buffer !== '') {
53 53
                 $details = json_decode($buffer);
54 54
             } elseif (File::exists('auth.json')) {
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
         });
59 59
 
60 60
         // Create an auth.json file
61
-        if (! $details) {
61
+        if (!$details) {
62 62
             $this->info(' Creating auth.json file with your authentication token');
63 63
 
64 64
             $this->line(' (Find your access token details on https://backpackforlaravel.com/user/tokens)');
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
             $password = $this->ask('Access token password');
67 67
 
68 68
             $process = new Process(['composer', 'config', 'http-basic.backpackforlaravel.com', $username, $password]);
69
-            $process->run(function ($type, $buffer) use ($username, $password) {
69
+            $process->run(function($type, $buffer) use ($username, $password) {
70 70
                 if ($type === Process::ERR) {
71 71
                     // Fallback
72 72
                     $authFile = [
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
 
81 81
                     if (File::exists('auth.json')) {
82 82
                         $currentFile = json_decode(File::get('auth.json'), true);
83
-                        if (! ($currentFile['http-basic']['backpackforlaravel.com'] ?? false)) {
83
+                        if (!($currentFile['http-basic']['backpackforlaravel.com'] ?? false)) {
84 84
                             $authFile = array_merge_recursive($authFile, $currentFile);
85 85
                         }
86 86
                     }
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
         // Check if repositories exists
95 95
         $details = null;
96 96
         $process = new Process(['composer', 'config', 'repositories.backpack/devtools']);
97
-        $process->run(function ($type, $buffer) use (&$details) {
97
+        $process->run(function($type, $buffer) use (&$details) {
98 98
             if ($type !== Process::ERR && $buffer !== '') {
99 99
                 $details = json_decode($buffer);
100 100
             } else {
@@ -104,11 +104,11 @@  discard block
 block discarded – undo
104 104
         });
105 105
 
106 106
         // Create repositories
107
-        if (! $details) {
107
+        if (!$details) {
108 108
             $this->info(' Creating repositories entry in composer.json');
109 109
 
110 110
             $process = new Process(['composer', 'config', 'repositories.backpack/devtools', 'composer', 'https://repo.backpackforlaravel.com']);
111
-            $process->run(function ($type, $buffer) {
111
+            $process->run(function($type, $buffer) {
112 112
                 if ($type === Process::ERR) {
113 113
                     // Fallback
114 114
                     $composerJson = Str::of(File::get('composer.json'));
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
         // Require package
140 140
         $process = new Process(['composer', 'require', '--dev', '--with-all-dependencies', 'backpack/devtools']);
141 141
         $process->setTimeout(300);
142
-        $process->run(function ($type, $buffer) {
142
+        $process->run(function($type, $buffer) {
143 143
             $this->progressBar->advance();
144 144
         });
145 145
 
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
         $this->info(' Now running the DevTools installation command.');
153 153
 
154 154
         // manually include the command in the run-time
155
-        if (! class_exists(\Backpack\DevTools\Console\Commands\InstallDevTools::class)) {
155
+        if (!class_exists(\Backpack\DevTools\Console\Commands\InstallDevTools::class)) {
156 156
             include base_path('vendor/backpack/devtools/src/Console/Commands/InstallDevTools.php');
157 157
         }
158 158
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/CrudPanel.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -102,11 +102,11 @@  discard block
 block discarded – undo
102 102
      */
103 103
     public function setModel($model_namespace)
104 104
     {
105
-        if (! class_exists($model_namespace)) {
105
+        if (!class_exists($model_namespace)) {
106 106
             throw new \Exception('The model does not exist.', 500);
107 107
         }
108 108
 
109
-        if (! method_exists($model_namespace, 'hasCrudTrait')) {
109
+        if (!method_exists($model_namespace, 'hasCrudTrait')) {
110 110
             throw new \Exception('Please use CrudTrait on the model.', 500);
111 111
         }
112 112
 
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
195 195
     {
196 196
         $complete_route = $route.'.index';
197 197
 
198
-        if (! \Route::has($complete_route)) {
198
+        if (!\Route::has($complete_route)) {
199 199
             throw new \Exception('There are no routes for this route name.', 404);
200 200
         }
201 201
 
@@ -293,7 +293,7 @@  discard block
 block discarded – undo
293 293
      */
294 294
     public function getFirstOfItsTypeInArray($type, $array)
295 295
     {
296
-        return Arr::first($array, function ($item) use ($type) {
296
+        return Arr::first($array, function($item) use ($type) {
297 297
             return $item['type'] == $type;
298 298
         });
299 299
     }
@@ -310,8 +310,8 @@  discard block
 block discarded – undo
310 310
 
311 311
     public function sync($type, $fields, $attributes)
312 312
     {
313
-        if (! empty($this->{$type})) {
314
-            $this->{$type} = array_map(function ($field) use ($fields, $attributes) {
313
+        if (!empty($this->{$type})) {
314
+            $this->{$type} = array_map(function($field) use ($fields, $attributes) {
315 315
                 if (in_array($field['name'], (array) $fields)) {
316 316
                     $field = array_merge($field, $attributes);
317 317
                 }
@@ -341,15 +341,15 @@  discard block
 block discarded – undo
341 341
     {
342 342
         $relationArray = explode('.', $relationString);
343 343
 
344
-        if (! isset($length)) {
344
+        if (!isset($length)) {
345 345
             $length = count($relationArray);
346 346
         }
347 347
 
348
-        if (! isset($model)) {
348
+        if (!isset($model)) {
349 349
             $model = $this->model;
350 350
         }
351 351
 
352
-        $result = array_reduce(array_splice($relationArray, 0, $length), function ($obj, $method) {
352
+        $result = array_reduce(array_splice($relationArray, 0, $length), function($obj, $method) {
353 353
             try {
354 354
                 $result = $obj->$method();
355 355
 
@@ -384,7 +384,7 @@  discard block
 block discarded – undo
384 384
             if (is_array($entries)) {
385 385
                 //if attribute does not exist in main array we have more than one entry OR the attribute
386 386
                 //is an acessor that is not in $appends property of model.
387
-                if (! isset($entries[$attribute])) {
387
+                if (!isset($entries[$attribute])) {
388 388
                     //we first check if we don't have the attribute because it's an acessor that is not in appends.
389 389
                     if ($model_instance->hasGetMutator($attribute) && isset($entries[$modelKey])) {
390 390
                         $entry_in_database = $model_instance->find($entries[$modelKey]);
@@ -423,21 +423,21 @@  discard block
 block discarded – undo
423 423
      */
424 424
     public function parseTranslatableAttributes($model, $attribute, $value)
425 425
     {
426
-        if (! method_exists($model, 'isTranslatableAttribute')) {
426
+        if (!method_exists($model, 'isTranslatableAttribute')) {
427 427
             return $value;
428 428
         }
429 429
 
430
-        if (! $model->isTranslatableAttribute($attribute)) {
430
+        if (!$model->isTranslatableAttribute($attribute)) {
431 431
             return $value;
432 432
         }
433 433
 
434
-        if (! is_array($value)) {
434
+        if (!is_array($value)) {
435 435
             $decodedAttribute = json_decode($value, true);
436 436
         } else {
437 437
             $decodedAttribute = $value;
438 438
         }
439 439
 
440
-        if (is_array($decodedAttribute) && ! empty($decodedAttribute)) {
440
+        if (is_array($decodedAttribute) && !empty($decodedAttribute)) {
441 441
             if (isset($decodedAttribute[app()->getLocale()])) {
442 442
                 return $decodedAttribute[app()->getLocale()];
443 443
             } else {
@@ -463,7 +463,7 @@  discard block
 block discarded – undo
463 463
         $relation = $model->{$firstRelationName};
464 464
 
465 465
         $results = [];
466
-        if (! is_null($relation)) {
466
+        if (!is_null($relation)) {
467 467
             if ($relation instanceof Collection) {
468 468
                 $currentResults = $relation->all();
469 469
             } elseif (is_array($relation)) {
@@ -476,7 +476,7 @@  discard block
 block discarded – undo
476 476
 
477 477
             array_shift($relationArray);
478 478
 
479
-            if (! empty($relationArray)) {
479
+            if (!empty($relationArray)) {
480 480
                 foreach ($currentResults as $currentResult) {
481 481
                     $results = array_merge_recursive($results, $this->getRelatedEntries($currentResult, implode('.', $relationArray)));
482 482
                 }
Please login to merge, or discard this patch.