ExampleCrudController::update() - Code Metrics - Inspection of "officially added call-based api" - Laravel-Backpack/CRUD - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c61b79...4016a1 )

by Cristian

created 2016-05-18 15:10 UTC

ExampleCrudController::update() A

↳ Parent: ExampleCrudController

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
cc	1
eloc	2
nc	1
nop	1
dl	0
loc	4
rs	10
c	1
b	0
f	1

1			<?php namespace App\Http\Controllers\Admin;
2
3			use App\Http\Requests;
4			use App\Http\Controllers\Controller;
5			use Backpack\CRUD\app\Http\Controllers\CrudController;
6			use Illuminate\Http\Request;
7
8			// VALIDATION: change the requests to match your own file names if you need form validation
9			use Backpack\CRUD\app\Http\Requests\CrudRequest as StoreRequest;
10			use Backpack\CRUD\app\Http\Requests\CrudRequest as UpdateRequest;
11
12			class ExampleCrudController extends CrudController {
13
14			public function __construct() {
15			parent::__construct();
16
17			/*
18			\|--------------------------------------------------------------------------
19			\| API
20			\|--------------------------------------------------------------------------
21			*/
22
23
24			// USAGE LEVEL 1 - ALWAYS ================================================== LEVEL 1
25			$this->crud->setModel("App\Models\Example");
26			$this->crud->setRoute("admin/example");
27			// $this->crud->setRouteName("admin.example");
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
28			$this->crud->setEntityNameStrings("example", "examples");
29
30			// $this->crud->setColumns(); // set the columns you want in the table view, either as array of column names, or multidimensional array with all columns detailed with their types
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `60%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
31			// TODO: $this->crud->setFields($array_of_arrays, 'update/create/both'); // set fields for both create&update forms
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `57%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
32			// $this->crud->setFromDb(); // automatically set fields and columns from your database columns TODO: rephrase
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `60%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
33
34
35
36			// USAGE LEVEL 2 - OFTEN ================================================== LEVEL 2
37
38
39			// ------ FIELDS (the last parameter is always the form - create/update/both)
40			// TODO: $this->crud->addField('name', $options, 'update/create/both');
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `62%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
41			// TODO: $this->crud->addFields($array_of_arrays, 'update/create/both');
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `60%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
42			// TODO: $this->crud->removeField('name', 'update/create/both');
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `60%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
43			// TODO: $this->crud->removeFields($array_of_names, 'update/create/both');
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `60%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
44			// TODO: $this->crud->replaceField('name', 'update/create/both');
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `60%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
45
46			// TODO: $this->crud->setRequiredFields(['field_1', 'field_2'], 'update/create/both');
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `65%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
47			// TODO: $this->crud->setRequiredField('field_1', 'update/create/both');
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `60%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
48			// TODO: $this->crud->getRequiredFields();
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `55%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
49
50			// TODO: $this->crud->setFieldOrder(['field_1', 'field_2', 'field_3'], 'update/create/both');
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `66%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
51
52
53			// ------ COLUMNS
54			// $this->crud->addColumn(); // add a single column, at the end of the stack
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `60%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
55			// $this->crud->addColumns(); // add multiple columns, at the end of the stack
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `60%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
56			// $this->crud->removeColumn('column_name'); // remove a column from the stack
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `64%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
57			// $this->crud->removeColumns(['column_name_1', 'column_name_2']); // remove an array of columns from the stack
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `69%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
58			// $this->crud->setColumnDetails('column_name', ['attribute' => 'value']);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `69%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
59			// $this->crud->setColumnsDetails(['column_1', 'column_2'], ['attribute' => 'value']);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `71%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
60			// TODO: $this->crud->setColumnOrder(['column_1', 'column_2', 'column_3']);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `65%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
61
62
63			// ------ FIELDS AND COLUMNS
64			// TODO: $this->crud->setLabel('column_name/field_name', 'New Label'); // changes label for columns, create&update fields
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `57%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
65
66
67			// ------ ACCESS
68			// $this->crud->allowAccess('list');
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
69			// $this->crud->allowAccess(['list', 'create', 'delete']);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `73%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
70			// $this->crud->denyAccess('list');
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
71			// $this->crud->denyAccess(['list', 'create', 'delete']);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `73%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
72
73			// $this->crud->hasAccess('add'); // returns true/false
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `64%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
74			// $this->crud->hasAccessOrFail('add'); // throws 403 error
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `64%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
75
76
77			// ------ REORDER
78			// $this->crud->enableReorder('label_name', MAX_TREE_LEVEL);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `62%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
79			// NOTE: you also need to do allow access to the right users: $this->crud->allowAccess('reorder');
80
81			// $this->crud->disableReorder();
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
82			// $this->crud->isReorderEnabled(); // return true/false
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `60%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
83
84
85			// ------ DETAILS ROW
86			// $this->crud->enableDetailsRow();
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
87			// NOTE: you also need to do allow access to the right users: $this->crud->allowAccess('details_row');
88			// NOTE: you also need to do overwrite the showDetailsRow($id) method in your EntityCrudController to show whatever you'd like in the details row OR overwrite the views/backpack/crud/details_row.blade.php
89
90			// $this->crud->disableDetailsRow();
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
91
92
93			// ------ ADVANCED QUERIES
94			// $this->crud->addClause('active');
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
95			// $this->crud->addClause('type', 'car');
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
96			// $this->crud->addClause('where', 'name', '==', 'car');
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `69%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
97			// $this->crud->addClause('whereName', 'car');
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
98			// $this->crud->addClause('whereHas', 'posts', function($query) {
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `69%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
99			// $query->activePosts();
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `72%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
100			// });
101			// $this->crud->orderBy();
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
102			// $this->crud->groupBy();
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
103			// $this->crud->limit();
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
104
105
106
107			// USAGE LEVEL 3 - SOMETIMES ============================================== LEVEL 3
108
109			// TODO: $this->crud->setButtons(); // default includes edit and delete, with their name, icon, permission, link and class (btn-default)
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
110			// TODO: $this->crud->addButton();
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `55%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
111			// TODO: $this->crud->removeButton();
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `55%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
112			// TODO: $this->crud->replaceButton();
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `55%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
113
114
115
116			// USAGE LEVEL 4 - RARELY ================================================== LEVEL 4
117
118			// $this->crud->getEntry($entry_id);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
119			// $this->crud->getEntries();
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
120
121			// $this->crud->getFields('create/update/both');
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
122
123			// $this->crud->create($entry_request);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
124			// $this->crud->update($entry_id, $entry_request);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
125			// $this->crud->delete($entry_id);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
126
127
128			// USAGE LEVEL 5 - ALMOST NEVER ============================================== LEVEL 5
129
130			// $this->crud->updateTreeOrder($all_entries);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
131
132
133
134
135			// ------------------------
136			// MEANWHILE THIS WILL WORK
137			// ------------------------
138
139
140			$this->crud->reorder = true;
141			$this->crud->reorder_label = "name";
			0 ignored issues – show Documentation Bug introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report The property `$reorder_label` was declared of type `boolean`, but `'name'` is of type `string`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
142			$this->crud->reorder_max_level = 3;
143			$this->crud->details_row = true;
144			// $this->crud->permissions = ['add', 'list', 'edit', 'delete', 'show'];
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report `60%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
145
146			$this->crud->columns = [
147			[
148			'name' => 'name',
149			'label' => "Example item text"
150			],
151			[
152			'label' => "Parent",
153			'type' => 'select',
154			'name' => 'parent_id',
155			'entity' => 'parent',
156			'attribute' => 'name',
157			'model' => "App\Models\Example"
158			],
159			];
160			$this->crud->fields = [
161			[
162			'name' => 'name',
163			'label' => "Example item text"
164			],
165			[
166			'label' => "Parent",
167			'type' => 'select',
168			'name' => 'parent_id',
169			'entity' => 'parent',
170			'attribute' => 'name',
171			'model' => "App\Models\Example"
172			],
173			[
174			'name' => 'type',
175			'label' => "Type",
176			'type' => 'page_or_link'
177			],
178			];
179
180			}
181
182			public function store(StoreRequest $request)
183			{
184			return parent::storeCrud();
			0 ignored issues – show Comprehensibility Bug introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`storeCrud()` instead of `store()`). Are you sure this is correct? If so, you might want to change this to `$this->storeCrud()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
185			}
186
187			public function update(UpdateRequest $request)
188			{
189			return parent::updateCrud();
			0 ignored issues – show Comprehensibility Bug introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`updateCrud()` instead of `update()`). Are you sure this is correct? If so, you might want to change this to `$this->updateCrud()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
190			}
191
192			}
193

Laravel-Backpack / CRUD

Scrutinizer GitHub App not installed

Push — master ( c61b79...4016a1 )

ExampleCrudController::update() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like