Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Push — use-db-transactions ( f233f9 )
by Pedro
31:23
created
src/app/Library/CrudPanel/Traits/Relationships.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
         $model = $this->getRelationModel($entity, -1);
66 66
         $lastSegmentAfterDot = Str::of($field['entity'])->afterLast('.');
67 67
 
68
-        if (! method_exists($model, $lastSegmentAfterDot)) {
68
+        if (!method_exists($model, $lastSegmentAfterDot)) {
69 69
             return (string) Str::of($field['entity'])->beforeLast('.');
70 70
         }
71 71
 
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
 
87 87
         return collect($this->getCleanStateFields())
88 88
             ->whereIn('relation_type', $relation_types)
89
-            ->filter(function ($item) use ($nested) {
89
+            ->filter(function($item) use ($nested) {
90 90
                 if ($nested) {
91 91
                     return true;
92 92
                 }
@@ -130,7 +130,7 @@  discard block
 block discarded – undo
130 130
      */
131 131
     private function getRelationFieldsWithoutRelationType($relations, $fields = [])
132 132
     {
133
-        if (! is_array($relations)) {
133
+        if (!is_array($relations)) {
134 134
             $relations = [$relations];
135 135
         }
136 136
 
@@ -139,8 +139,8 @@  discard block
 block discarded – undo
139 139
         }
140 140
 
141 141
         foreach ($relations as $relation) {
142
-            $fields = array_filter($fields, function ($field) use ($relation) {
143
-                if (! isset($field['relation_type'])) {
142
+            $fields = array_filter($fields, function($field) use ($relation) {
143
+                if (!isset($field['relation_type'])) {
144 144
                     return false;
145 145
                 }
146 146
 
@@ -174,7 +174,7 @@  discard block
 block discarded – undo
174 174
                     $fields = array_merge($field['subfields'], $fields);
175 175
                 }
176 176
             }
177
-            $fields = array_filter($fields, function ($field) {
177
+            $fields = array_filter($fields, function($field) {
178 178
                 return isset($field['relation_type']) && $field['relation_type'] === 'BelongsTo';
179 179
             });
180 180
         }
@@ -241,8 +241,8 @@  discard block
 block discarded – undo
241 241
     {
242 242
         $all_relation_fields = $this->getRelationFields();
243 243
 
244
-        return Arr::where($all_relation_fields, function ($value, $key) {
245
-            return isset($value['pivot']) && ! $value['pivot'];
244
+        return Arr::where($all_relation_fields, function($value, $key) {
245
+            return isset($value['pivot']) && !$value['pivot'];
246 246
         });
247 247
     }
248 248
 
@@ -255,7 +255,7 @@  discard block
 block discarded – undo
255 255
     {
256 256
         $all_relation_fields = $this->getRelationFields();
257 257
 
258
-        return Arr::where($all_relation_fields, function ($value, $key) {
258
+        return Arr::where($all_relation_fields, function($value, $key) {
259 259
             return isset($value['pivot']) && $value['pivot'];
260 260
         });
261 261
     }
@@ -336,7 +336,7 @@  discard block
 block discarded – undo
336 336
         }
337 337
 
338 338
         // relationships are always public methods.
339
-        if (! $methodReflection->isPublic()) {
339
+        if (!$methodReflection->isPublic()) {
340 340
             return false;
341 341
         }
342 342
 
@@ -363,7 +363,7 @@  discard block
 block discarded – undo
363 363
      */
364 364
     public function isAttributeInRelationString(array $field): bool
365 365
     {
366
-        if (! str_contains($field['entity'], '.')) {
366
+        if (!str_contains($field['entity'], '.')) {
367 367
             return false;
368 368
         }
369 369
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Support/MacroableWithAttributes.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@
 block discarded – undo
44 44
                                         ->filter(fn ($item) => isset($item[$macro]));
45 45
 
46 46
                 $subfieldsWithMacros->each(
47
-                    function ($item) use ($subfieldsWithMacros, $macro) {
47
+                    function($item) use ($subfieldsWithMacros, $macro) {
48 48
                         if ($subfieldsWithMacros->last() === $item) {
49 49
                             $this->{$macro}($item[$macro], $item);
50 50
                         } else {
Please login to merge, or discard this patch.
tests/BaseTestClass.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@
 block discarded – undo
23 23
             (array) config('backpack.base.middleware_key', 'admin'),
24 24
             'prefix'     => config('backpack.base.route_prefix', 'admin'),
25 25
         ],
26
-            function () {
26
+            function() {
27 27
                 Route::get('articles/{id}/show/{detail}', ['as' => 'article.show.detail', 'action' => 'Backpack\CRUD\Tests\config\Http\Controllers\ArticleCrudController@detail']);
28 28
                 Route::crud('users', 'Backpack\CRUD\Tests\config\Http\Controllers\UserCrudController');
29 29
                 Route::crud('articles', 'Backpack\CRUD\Tests\config\Http\Controllers\ArticleCrudController');
Please login to merge, or discard this patch.
src/macros.php 1 patch
Spacing   +19 added lines, -19 removed lines patch added patch discarded remove patch
@@ -19,8 +19,8 @@  discard block
 block discarded – undo
19 19
  *      - when true: `address[street]`
20 20
  *      - when false: `[address][street]`
21 21
  */
22
-if (! Str::hasMacro('dotsToSquareBrackets')) {
23
-    Str::macro('dotsToSquareBrackets', function ($string, $ignore = [], $keyFirst = true) {
22
+if (!Str::hasMacro('dotsToSquareBrackets')) {
23
+    Str::macro('dotsToSquareBrackets', function($string, $ignore = [], $keyFirst = true) {
24 24
         $stringParts = explode('.', $string);
25 25
         $result = '';
26 26
 
@@ -34,8 +34,8 @@  discard block
 block discarded – undo
34 34
         return $result;
35 35
     });
36 36
 }
37
-if (! CrudColumn::hasMacro('withFiles')) {
38
-    CrudColumn::macro('withFiles', function ($uploadDefinition = [], $subfield = null, $registerUploaderEvents = true) {
37
+if (!CrudColumn::hasMacro('withFiles')) {
38
+    CrudColumn::macro('withFiles', function($uploadDefinition = [], $subfield = null, $registerUploaderEvents = true) {
39 39
         $uploadDefinition = is_array($uploadDefinition) ? $uploadDefinition : [];
40 40
         /** @var CrudField|CrudColumn $this */
41 41
         RegisterUploadEvents::handle($this, $uploadDefinition, 'withFiles', $subfield, $registerUploaderEvents);
@@ -44,8 +44,8 @@  discard block
 block discarded – undo
44 44
     });
45 45
 }
46 46
 
47
-if (! CrudField::hasMacro('withFiles')) {
48
-    CrudField::macro('withFiles', function ($uploadDefinition = [], $subfield = null, $registerUploaderEvents = true) {
47
+if (!CrudField::hasMacro('withFiles')) {
48
+    CrudField::macro('withFiles', function($uploadDefinition = [], $subfield = null, $registerUploaderEvents = true) {
49 49
         $uploadDefinition = is_array($uploadDefinition) ? $uploadDefinition : [];
50 50
         /** @var CrudField|CrudColumn $this */
51 51
         RegisterUploadEvents::handle($this, $uploadDefinition, 'withFiles', $subfield, $registerUploaderEvents);
@@ -54,8 +54,8 @@  discard block
 block discarded – undo
54 54
     });
55 55
 }
56 56
 
57
-if (! CrudColumn::hasMacro('linkTo')) {
58
-    CrudColumn::macro('linkTo', function (string|array|Closure $routeOrConfiguration, ?array $parameters = []): static {
57
+if (!CrudColumn::hasMacro('linkTo')) {
58
+    CrudColumn::macro('linkTo', function(string | array | Closure $routeOrConfiguration, ?array $parameters = []): static {
59 59
         $wrapper = $this->attributes['wrapper'] ?? [];
60 60
 
61 61
         // parse the function input to get the actual route and parameters we'll be working with
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
 
69 69
         // if the route is a closure, we'll just call it
70 70
         if ($route instanceof Closure) {
71
-            $wrapper['href'] = function ($crud, $column, $entry, $related_key) use ($route) {
71
+            $wrapper['href'] = function($crud, $column, $entry, $related_key) use ($route) {
72 72
                 return $route($entry, $related_key, $column, $crud);
73 73
             };
74 74
             $this->wrapper($wrapper);
@@ -77,13 +77,13 @@  discard block
 block discarded – undo
77 77
         }
78 78
 
79 79
         // if the route doesn't exist, we'll throw an exception
80
-        if (! $routeInstance = Route::getRoutes()->getByName($route)) {
80
+        if (!$routeInstance = Route::getRoutes()->getByName($route)) {
81 81
             throw new \Exception("Route [{$route}] not found while building the link for column [{$this->attributes['name']}].");
82 82
         }
83 83
 
84 84
         // calculate the parameters we'll be using for the route() call
85 85
         // (eg. if there's only one parameter and user didn't provide it, we'll assume it's the entry's related key)
86
-        $parameters = (function () use ($parameters, $routeInstance, $route) {
86
+        $parameters = (function() use ($parameters, $routeInstance, $route) {
87 87
             $expectedParameters = $routeInstance->parameterNames();
88 88
 
89 89
             if (count($expectedParameters) === 0) {
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
             if (count($autoInferedParameter) > 1) {
95 95
                 throw new \Exception("Route [{$route}] expects parameters [".implode(', ', $expectedParameters)."]. Insuficient parameters provided in column: [{$this->attributes['name']}].");
96 96
             }
97
-            $autoInferedParameter = current($autoInferedParameter) ? [current($autoInferedParameter) => function ($entry, $related_key, $column, $crud) {
97
+            $autoInferedParameter = current($autoInferedParameter) ? [current($autoInferedParameter) => function($entry, $related_key, $column, $crud) {
98 98
                 $entity = $crud->isAttributeInRelationString($column) ? Str::before($column['entity'], '.') : $column['entity'];
99 99
 
100 100
                 return $related_key ?? $entry->{$entity}?->getKey();
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
         })();
105 105
 
106 106
         // set up the wrapper href attribute
107
-        $wrapper['href'] = function ($crud, $column, $entry, $related_key) use ($route, $parameters) {
107
+        $wrapper['href'] = function($crud, $column, $entry, $related_key) use ($route, $parameters) {
108 108
             // if the parameter is callable, we'll call it
109 109
             $parameters = collect($parameters)->map(fn ($item) => is_callable($item) ? $item($entry, $related_key, $column, $crud) : $item)->toArray();
110 110
 
@@ -117,17 +117,17 @@  discard block
 block discarded – undo
117 117
     });
118 118
 }
119 119
 
120
-if (! CrudColumn::hasMacro('linkToShow')) {
121
-    CrudColumn::macro('linkToShow', function (): static {
120
+if (!CrudColumn::hasMacro('linkToShow')) {
121
+    CrudColumn::macro('linkToShow', function(): static {
122 122
         $name = $this->attributes['name'];
123 123
         $entity = $this->attributes['entity'] ?? null;
124 124
         $route = "$entity.show";
125 125
 
126
-        if (! $entity) {
126
+        if (!$entity) {
127 127
             throw new \Exception("Entity not found while building the link for column [{$name}].");
128 128
         }
129 129
 
130
-        if (! Route::getRoutes()->getByName($route)) {
130
+        if (!Route::getRoutes()->getByName($route)) {
131 131
             throw new \Exception("Route '{$route}' not found while building the link for column [{$name}].");
132 132
         }
133 133
 
@@ -144,8 +144,8 @@  discard block
 block discarded – undo
144 144
  *
145 145
  * It will go to the given CrudController and get the setupRoutes() method on it.
146 146
  */
147
-if (! Route::hasMacro('crud')) {
148
-    Route::macro('crud', function ($name, $controller) {
147
+if (!Route::hasMacro('crud')) {
148
+    Route::macro('crud', function($name, $controller) {
149 149
         // put together the route name prefix,
150 150
         // as passed to the Route::group() statements
151 151
         $routeName = '';
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/ListOperation.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
             'operation' => 'list',
28 28
         ]);
29 29
 
30
-        if (! isset($this->setupDetailsRowRoute) || $this->setupDetailsRowRoute === true) {
30
+        if (!isset($this->setupDetailsRowRoute) || $this->setupDetailsRowRoute === true) {
31 31
             Route::get($segment.'/{id}/details', [
32 32
                 'as'        => $routeName.'.showDetailsRow',
33 33
                 'uses'      => $controller.'@showDetailsRow',
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
     {
44 44
         $this->crud->allowAccess('list');
45 45
 
46
-        $this->crud->operation('list', function () {
46
+        $this->crud->operation('list', function() {
47 47
             $this->crud->loadDefaultOperationSettingsFromConfig();
48 48
         });
49 49
     }
Please login to merge, or discard this patch.
src/app/Library/Uploaders/MultipleFiles.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -10,7 +10,7 @@  discard block
 block discarded – undo
10 10
 
11 11
 class MultipleFiles extends Uploader
12 12
 {
13
-    public static function for(array $field, $configuration): UploaderInterface
13
+    public static function for (array $field, $configuration): UploaderInterface
14 14
     {
15 15
         return (new self($field, $configuration))->multiple();
16 16
     }
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
         $value = $value ?? collect(CRUD::getRequest()->file($this->getRepeatableContainerName() ?? $this->getName()))->flatten()->toArray();
26 26
         $previousFiles = $this->getPreviousFiles($entry) ?? [];
27 27
 
28
-        if (! is_array($previousFiles) && is_string($previousFiles)) {
28
+        if (!is_array($previousFiles) && is_string($previousFiles)) {
29 29
             $previousFiles = json_decode($previousFiles, true);
30 30
         }
31 31
 
@@ -34,14 +34,14 @@  discard block
 block discarded – undo
34 34
                 if (in_array($previousFile, $filesToDelete)) {
35 35
                     Storage::disk($this->getDisk())->delete($previousFile);
36 36
 
37
-                    $previousFiles = Arr::where($previousFiles, function ($value, $key) use ($previousFile) {
37
+                    $previousFiles = Arr::where($previousFiles, function($value, $key) use ($previousFile) {
38 38
                         return $value != $previousFile;
39 39
                     });
40 40
                 }
41 41
             }
42 42
         }
43 43
 
44
-        if (! is_array($value)) {
44
+        if (!is_array($value)) {
45 45
             $value = [];
46 46
         }
47 47
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Update.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
         $item = $this->model->findOrFail($id);
28 28
 
29 29
         [$directInputs, $relationInputs] = $this->splitInputIntoDirectAndRelations($input);
30
-        if($this->get('update.useDatabaseTransactions')) {
30
+        if ($this->get('update.useDatabaseTransactions')) {
31 31
             return DB::transaction(fn() => $this->updateModelAndRelations($item, $directInputs, $relationInputs));
32 32
         }
33 33
         
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
         }
57 57
 
58 58
         // always have a hidden input for the entry id
59
-        if (! array_key_exists('id', $fields)) {
59
+        if (!array_key_exists('id', $fields)) {
60 60
             $fields['id'] = [
61 61
                 'name'  => $entry->getKeyName(),
62 62
                 'value' => $entry->getKey(),
@@ -81,12 +81,12 @@  discard block
 block discarded – undo
81 81
         $fieldEntity = $field['entity'] ?? false;
82 82
         $fakeField = $field['fake'] ?? false;
83 83
 
84
-        if ($fieldEntity && ! $fakeField) {
84
+        if ($fieldEntity && !$fakeField) {
85 85
             return $this->getModelAttributeValueFromRelationship($model, $field);
86 86
         }
87 87
 
88 88
         if ($this->holdsMultipleInputs($field['name'])) {
89
-            $result = array_map(function ($item) use ($model) {
89
+            $result = array_map(function($item) use ($model) {
90 90
                 return $model->{$item};
91 91
             }, explode(',', $field['name']));
92 92
 
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
     {
109 109
         [$relatedModel, $relationMethod] = $this->getModelAndMethodFromEntity($model, $field);
110 110
 
111
-        if (! method_exists($relatedModel, $relationMethod)) {
111
+        if (!method_exists($relatedModel, $relationMethod)) {
112 112
             return $relatedModel->{$relationMethod};
113 113
         }
114 114
 
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
                     $model = $this->setupRelatedModelLocale($model);
128 128
                     // when subfields are NOT set we don't need to get any more values
129 129
                     // we just return the plain models as we only need the ids
130
-                    if (! isset($field['subfields'])) {
130
+                    if (!isset($field['subfields'])) {
131 131
                         $result->push($model);
132 132
 
133 133
                         continue;
@@ -155,13 +155,13 @@  discard block
 block discarded – undo
155 155
                 break;
156 156
             case 'HasOne':
157 157
             case 'MorphOne':
158
-                if (! method_exists($relatedModel, $relationMethod)) {
158
+                if (!method_exists($relatedModel, $relationMethod)) {
159 159
                     return;
160 160
                 }
161 161
 
162 162
                 $model = $relatedModel->{$relationMethod};
163 163
 
164
-                if (! $model) {
164
+                if (!$model) {
165 165
                     return;
166 166
                 }
167 167
 
@@ -242,7 +242,7 @@  discard block
 block discarded – undo
242 242
 
243 243
         $relationArray = explode('.', $relationEntity);
244 244
 
245
-        $relatedModel = array_reduce(array_splice($relationArray, 0, -1), function ($obj, $method) {
245
+        $relatedModel = array_reduce(array_splice($relationArray, 0, -1), function($obj, $method) {
246 246
             // if the string ends with `_id` we strip it out
247 247
             $method = Str::endsWith($method, '_id') ? Str::replaceLast('_id', '', $method) : $method;
248 248
 
@@ -269,7 +269,7 @@  discard block
 block discarded – undo
269 269
             // if the subfield name does not contain a dot we just need to check
270 270
             // if it has subfields and return the result accordingly.
271 271
             foreach ((array) $subfield['name'] as $name) {
272
-                if (! Str::contains($name, '.')) {
272
+                if (!Str::contains($name, '.')) {
273 273
                     // when subfields are present, $relatedModel->{$name} returns a model instance
274 274
                     // otherwise returns the model attribute.
275 275
                     if ($relatedModel->{$name}) {
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Create.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
     {
25 25
         [$directInputs, $relationInputs] = $this->splitInputIntoDirectAndRelations($input);
26 26
 
27
-        if($this->get('create.useDatabaseTransactions')) {
27
+        if ($this->get('create.useDatabaseTransactions')) {
28 28
             return DB::transaction(fn()  => $this->createModelAndRelations($directInputs, $relationInputs));
29 29
         }
30 30
         
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
                     // - a single dimensional array: [1,2,3]
121 121
                     // - an array of arrays: [[1][2][3]]
122 122
                     // if is as single dimensional array we can only attach.
123
-                    if ($relationValues === null || ! is_multidimensional_array($relationValues)) {
123
+                    if ($relationValues === null || !is_multidimensional_array($relationValues)) {
124 124
                         $this->attachManyRelation($item, $relation, $relationDetails, $relationValues);
125 125
                     } else {
126 126
                         $this->createManyEntries($item, $relation, $relationMethod, $relationDetails);
@@ -284,7 +284,7 @@  discard block
 block discarded – undo
284 284
 
285 285
         // if column is not nullable in database, and there is no column default (null),
286 286
         // we will delete the entry from the database, otherwise it will throw and ugly DB error.
287
-        if (! $relationColumnIsNullable && $dbColumnDefault === null) {
287
+        if (!$relationColumnIsNullable && $dbColumnDefault === null) {
288 288
             return $removedEntries->lazy()->each->delete();
289 289
         }
290 290
 
@@ -329,7 +329,7 @@  discard block
 block discarded – undo
329 329
         }
330 330
 
331 331
         // use the collection of sent ids to match against database ids, delete the ones not found in the submitted ids.
332
-        if (! empty($relatedItemsSent)) {
332
+        if (!empty($relatedItemsSent)) {
333 333
             // we perform the cleanup of removed database items
334 334
             $entry->{$relationMethod}()->whereNotIn($relatedModelLocalKey, $relatedItemsSent)->lazy()->each->delete();
335 335
         }
Please login to merge, or discard this patch.