Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Push — add-uploaders-tests ( da2694...443f98 )
by Pedro
21:48 queued 06:41
created
src/app/Models/Traits/HasIdentifiableAttribute.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@
 block discarded – undo
53 53
         // we get the first column from database
54 54
         // that is NOT indexed (usually primary, foreign keys)
55 55
         foreach ($columnNames as $columnName) {
56
-            if (! in_array($columnName, $indexes)) {
56
+            if (!in_array($columnName, $indexes)) {
57 57
                 //check for convention "field<_id>" in case developer didn't add foreign key constraints.
58 58
                 if (strpos($columnName, '_id') !== false) {
59 59
                     continue;
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/AutoSet.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -14,8 +14,8 @@  discard block
 block discarded – undo
14 14
     {
15 15
         $this->getDbColumnTypes();
16 16
 
17
-        array_map(function ($field) use ($setFields, $setColumns) {
18
-            if ($setFields && ! isset($this->getCleanStateFields()[$field])) {
17
+        array_map(function($field) use ($setFields, $setColumns) {
18
+            if ($setFields && !isset($this->getCleanStateFields()[$field])) {
19 19
                 $this->addField([
20 20
                     'name' => $field,
21 21
                     'label' => $this->makeLabel($field),
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
                 ]);
29 29
             }
30 30
 
31
-            if ($setColumns && ! in_array($field, $this->model->getHidden()) && ! isset($this->columns()[$field])) {
31
+            if ($setColumns && !in_array($field, $this->model->getHidden()) && !isset($this->columns()[$field])) {
32 32
                 $this->addColumn([
33 33
                     'name' => $field,
34 34
                     'label' => $this->makeLabel($field),
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
     {
51 51
         $dbColumnTypes = [];
52 52
 
53
-        if (! $this->driverIsSql()) {
53
+        if (!$this->driverIsSql()) {
54 54
             return $dbColumnTypes;
55 55
         }
56 56
         $dbColumns = $this->getDbTableColumns();
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
 
116 116
         $dbColumnTypes = $this->getDbColumnTypes();
117 117
 
118
-        if (! isset($dbColumnTypes[$fieldName])) {
118
+        if (!isset($dbColumnTypes[$fieldName])) {
119 119
             return 'text';
120 120
         }
121 121
 
@@ -210,12 +210,12 @@  discard block
 block discarded – undo
210 210
     {
211 211
         $fillable = $this->model->getFillable();
212 212
 
213
-        if (! $this->driverIsSql()) {
213
+        if (!$this->driverIsSql()) {
214 214
             $columns = $fillable;
215 215
         } else {
216 216
             // Automatically-set columns should be both in the database, and in the $fillable variable on the Eloquent Model
217 217
             $columns = $this->model::getDbTableSchema()->getColumnsNames();
218
-            if (! empty($fillable)) {
218
+            if (!empty($fillable)) {
219 219
                 $columns = array_intersect($columns, $fillable);
220 220
             }
221 221
         }
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelAutoSetTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -848,7 +848,7 @@
 block discarded – undo
848 848
 
849 849
     public function testSetDoctrineTypesMapping()
850 850
     {
851
-        if (! method_exists($this->crudPanel->getModel()->getConnection(), 'getDoctrineConnection')) {
851
+        if (!method_exists($this->crudPanel->getModel()->getConnection(), 'getDoctrineConnection')) {
852 852
             $this->markTestSkipped('This test is only for Laravel 10, Laravel 11 does not have dbal as a dependency anymore');
853 853
         }
854 854
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Create.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
                     // - a single dimensional array: [1,2,3]
123 123
                     // - an array of arrays: [[1][2][3]]
124 124
                     // if is as single dimensional array we can only attach.
125
-                    if ($relationValues === null || ! is_multidimensional_array($relationValues)) {
125
+                    if ($relationValues === null || !is_multidimensional_array($relationValues)) {
126 126
                         $this->attachManyRelation($item, $relation, $relationDetails, $relationValues);
127 127
                     } else {
128 128
                         $this->createManyEntries($item, $relation, $relationMethod, $relationDetails);
@@ -293,7 +293,7 @@  discard block
 block discarded – undo
293 293
         }
294 294
         // if column is not nullable in database, and there is no column default (null),
295 295
         // we will delete the entry from the database, otherwise it will throw and ugly DB error.
296
-        if (! $relationColumnIsNullable && $dbColumnDefault === null) {
296
+        if (!$relationColumnIsNullable && $dbColumnDefault === null) {
297 297
             return $removedEntries->lazy()->each->delete();
298 298
         }
299 299
 
@@ -338,7 +338,7 @@  discard block
 block discarded – undo
338 338
         }
339 339
 
340 340
         // use the collection of sent ids to match against database ids, delete the ones not found in the submitted ids.
341
-        if (! empty($relatedItemsSent)) {
341
+        if (!empty($relatedItemsSent)) {
342 342
             // we perform the cleanup of removed database items
343 343
             $entry->{$relationMethod}()->whereNotIn($relatedModelLocalKey, $relatedItemsSent)->lazy()->each->delete();
344 344
         }
Please login to merge, or discard this patch.
src/app/Models/Traits/HasRelationshipFields.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
     {
23 23
         $connection = DB::connection($this->getConnectionName());
24 24
 
25
-        if (! method_exists($connection, 'getDoctrineSchemaManager')) {
25
+        if (!method_exists($connection, 'getDoctrineSchemaManager')) {
26 26
             return $connection;
27 27
         }
28 28
 
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
         if (self::isSqlConnection()) {
36 36
             $platform = $connection->getDoctrineSchemaManager()->getDatabasePlatform();
37 37
             foreach ($types as $type_key => $type_value) {
38
-                if (! $platform->hasDoctrineTypeMappingFor($type_key)) {
38
+                if (!$platform->hasDoctrineTypeMappingFor($type_key)) {
39 39
                     $platform->registerDoctrineTypeMapping($type_key, $type_value);
40 40
                 }
41 41
             }
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
      */
66 66
     public function getColumnType($columnName)
67 67
     {
68
-        if (! self::isSqlConnection()) {
68
+        if (!self::isSqlConnection()) {
69 69
             return 'text';
70 70
         }
71 71
 
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
      */
81 81
     public static function isColumnNullable($columnName)
82 82
     {
83
-        if (! self::isSqlConnection()) {
83
+        if (!self::isSqlConnection()) {
84 84
             return true;
85 85
         }
86 86
 
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
      */
96 96
     public static function dbColumnHasDefault($columnName)
97 97
     {
98
-        if (! self::isSqlConnection()) {
98
+        if (!self::isSqlConnection()) {
99 99
             return false;
100 100
         }
101 101
 
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
      */
111 111
     public static function getDbColumnDefault($columnName)
112 112
     {
113
-        if (! self::isSqlConnection()) {
113
+        if (!self::isSqlConnection()) {
114 114
             return false;
115 115
         }
116 116
 
Please login to merge, or discard this patch.
src/app/Library/Widget.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
         // if that widget name already exists in the widgets collection
38 38
         // then pick up all widget attributes from that entry
39 39
         // and overwrite them with the ones passed in $attributes
40
-        if ($existingItem = self::collection()->filter(function ($item) use ($attributes) {
40
+        if ($existingItem = self::collection()->filter(function($item) use ($attributes) {
41 41
             return $item->attributes['name'] === $attributes['name'];
42 42
         })->first()) {
43 43
             $attributes = array_merge($existingItem->attributes, $attributes);
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
             }
160 160
         }
161 161
         $type = $this->attributes['type'];
162
-        $paths = array_map(function ($item) use ($type) {
162
+        $paths = array_map(function($item) use ($type) {
163 163
             return $item.'.'.$type;
164 164
         }, ViewNamespaces::getWithFallbackFor('widgets', 'backpack.ui.component_view_namespaces.widgets'));
165 165
 
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
169 169
             }
170 170
         }
171 171
         // if no view exists, in any of the directories above... no bueno
172
-        if (! backpack_pro()) {
172
+        if (!backpack_pro()) {
173 173
             throw new BackpackProRequiredException('Cannot find the widget view: '.$this->attributes['type'].'. Please check for typos.'.(backpack_pro() ? '' : ' If you are trying to use a PRO widget, please first purchase and install the backpack/pro addon from backpackforlaravel.com'), 1);
174 174
         }
175 175
         abort(500, 'Cannot find the view for «'.$this->attributes['type'].'» widget type. Please check for typos.');
@@ -253,10 +253,10 @@  discard block
 block discarded – undo
253 253
      */
254 254
     private function save()
255 255
     {
256
-        $itemExists = $this->collection()->filter(function ($item) {
256
+        $itemExists = $this->collection()->filter(function($item) {
257 257
             return $item->attributes['name'] === $this->attributes['name'];
258 258
         })->isNotEmpty();
259
-        if (! $itemExists) {
259
+        if (!$itemExists) {
260 260
             $this->collection()->put($this->attributes['name'], $this);
261 261
         } else {
262 262
             $this->collection()[$this->attributes['name']] = $this;
Please login to merge, or discard this patch.
src/app/Library/Database/DatabaseSchema.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
      */
54 54
     private static function generateDatabaseSchema(string $connection)
55 55
     {
56
-        if (! isset(self::$schema[$connection])) {
56
+        if (!isset(self::$schema[$connection])) {
57 57
             self::$schema[$connection] = self::mapTables($connection);
58 58
         }
59 59
     }
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
      */
67 67
     private static function mapTables(string $connection)
68 68
     {
69
-        return LazyCollection::make(self::getCreateSchema($connection)->getTables())->mapWithKeys(function ($table, $key) use ($connection) {
69
+        return LazyCollection::make(self::getCreateSchema($connection)->getTables())->mapWithKeys(function($table, $key) use ($connection) {
70 70
             $tableName = is_array($table) ? $table['name'] : $table->getName();
71 71
 
72 72
             if (self::$schema[$connection][$tableName] ?? false) {
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
         $schemaManager = self::getSchemaManager($connection);
87 87
         $indexes = method_exists($schemaManager, 'listTableIndexes') ? $schemaManager->listTableIndexes($table) : $schemaManager->getIndexes($table);
88 88
 
89
-        $indexes = array_map(function ($index) {
89
+        $indexes = array_map(function($index) {
90 90
             return is_array($index) ? $index['columns'] : $index->getColumns();
91 91
         }, $indexes);
92 92
 
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
     {
100 100
         $indexedColumns = self::getIndexColumnNames($connection, $table);
101 101
 
102
-        return LazyCollection::make(self::getSchemaManager($connection)->getColumns($table))->mapWithKeys(function ($column, $key) use ($indexedColumns) {
102
+        return LazyCollection::make(self::getSchemaManager($connection)->getColumns($table))->mapWithKeys(function($column, $key) use ($indexedColumns) {
103 103
             $column['index'] = array_key_exists($column['name'], $indexedColumns) ? true : false;
104 104
 
105 105
             return [$column['name'] => $column];
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/ListOperation.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
             'operation' => 'list',
28 28
         ]);
29 29
 
30
-        if (! isset($this->setupDetailsRowRoute) || $this->setupDetailsRowRoute === true) {
30
+        if (!isset($this->setupDetailsRowRoute) || $this->setupDetailsRowRoute === true) {
31 31
             Route::get($segment.'/{id}/details', [
32 32
                 'as' => $routeName.'.showDetailsRow',
33 33
                 'uses' => $controller.'@showDetailsRow',
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
     {
44 44
         $this->crud->allowAccess('list');
45 45
 
46
-        $this->crud->operation('list', function () {
46
+        $this->crud->operation('list', function() {
47 47
             $this->crud->loadDefaultOperationSettingsFromConfig();
48 48
         });
49 49
     }
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
         $search = request()->input('search');
81 81
 
82 82
         // check if length is allowed by developer
83
-        if ($length && ! in_array($length, $this->crud->getPageLengthMenu()[0])) {
83
+        if ($length && !in_array($length, $this->crud->getPageLengthMenu()[0])) {
84 84
             return response()->json([
85 85
                 'error' => 'Unknown page length.',
86 86
             ], 400);
Please login to merge, or discard this patch.
src/app/Library/Validation/Rules/BackpackCustomRule.php 1 patch
Spacing   +15 added lines, -16 removed lines patch added patch discarded remove patch
@@ -29,13 +29,13 @@  discard block
 block discarded – undo
29 29
 
30 30
     public bool $implicit = true;
31 31
 
32
-    public static function field(string|array|ValidationRule|Rule $rules = []): self
32
+    public static function field(string | array | ValidationRule | Rule $rules = []): self
33 33
     {
34 34
         $instance = new static();
35 35
         $instance->fieldRules = self::getRulesAsArray($rules);
36 36
 
37 37
         if ($instance->validatesArrays()) {
38
-            if (! in_array('array', $instance->getFieldRules())) {
38
+            if (!in_array('array', $instance->getFieldRules())) {
39 39
                 $instance->fieldRules[] = 'array';
40 40
             }
41 41
         }
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
 
96 96
     public function getFieldRules(): array
97 97
     {
98
-        return tap($this->fieldRules, function ($rule) {
98
+        return tap($this->fieldRules, function($rule) {
99 99
             if (is_a($rule, BackpackCustomRule::class, true)) {
100 100
                 $rule = $rule->getFieldRules();
101 101
             }
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
             $rules = explode('|', $rules);
111 111
         }
112 112
 
113
-        if (! is_array($rules)) {
113
+        if (!is_array($rules)) {
114 114
             $rules = [$rules];
115 115
         }
116 116
 
@@ -119,10 +119,10 @@  discard block
 block discarded – undo
119 119
 
120 120
     protected function ensureValueIsValid($value)
121 121
     {
122
-        if ($this->validatesArrays() && ! is_array($value)) {
122
+        if ($this->validatesArrays() && !is_array($value)) {
123 123
             try {
124 124
                 $value = json_decode($value, true) ?? [];
125
-            } catch(\Exception $e) {
125
+            } catch (\Exception $e) {
126 126
                 return false;
127 127
             }
128 128
         }
@@ -141,12 +141,12 @@  discard block
 block discarded – undo
141 141
             $attribute => $rules,
142 142
         ], $this->validator->customMessages, $this->getValidatorCustomAttributes($attribute));
143 143
 
144
-        return $validator->errors()->messages()[$attribute] ?? (! empty($validator->errors()->messages()) ? current($validator->errors()->messages()) : []);
144
+        return $validator->errors()->messages()[$attribute] ?? (!empty($validator->errors()->messages()) ? current($validator->errors()->messages()) : []);
145 145
     }
146 146
 
147 147
     private function getValidatorCustomAttributes(string $attribute): array
148 148
     {
149
-        if (! is_a($this, ValidGenericAjaxEndpoint::class) && ! Str::contains($attribute, '.*.')) {
149
+        if (!is_a($this, ValidGenericAjaxEndpoint::class) && !Str::contains($attribute, '.*.')) {
150 150
             return $this->validator->customAttributes;
151 151
         }
152 152
 
@@ -157,8 +157,7 @@  discard block
 block discarded – undo
157 157
     protected function getValidationAttributeString(string $attribute)
158 158
     {
159 159
         return Str::substrCount($attribute, '.') > 1 ?
160
-                Str::before($attribute, '.').'.*.'.Str::afterLast($attribute, '.') :
161
-                $attribute;
160
+                Str::before($attribute, '.').'.*.'.Str::afterLast($attribute, '.') : $attribute;
162 161
     }
163 162
 
164 163
     protected function validateOnSubmit(string $attribute, mixed $value): array
@@ -166,7 +165,7 @@  discard block
 block discarded – undo
166 165
         return $this->validateRules($attribute, $value);
167 166
     }
168 167
 
169
-    protected function validateFieldAndFile(string $attribute, null|array $data = null, array|null $customRules = null): array
168
+    protected function validateFieldAndFile(string $attribute, null | array $data = null, array | null $customRules = null): array
170 169
     {
171 170
         $fieldErrors = $this->validateFieldRules($attribute, $data, $customRules);
172 171
 
@@ -178,7 +177,7 @@  discard block
 block discarded – undo
178 177
     /**
179 178
      * Implementation.
180 179
      */
181
-    public function validateFieldRules(string $attribute, null|array|string|UploadedFile $data = null, array|null $customRules = null): array
180
+    public function validateFieldRules(string $attribute, null | array | string | UploadedFile $data = null, array | null $customRules = null): array
182 181
     {
183 182
         $data = $data ?? $this->data;
184 183
         $validationRuleAttribute = $this->getValidationAttributeString($attribute);
@@ -187,16 +186,16 @@  discard block
 block discarded – undo
187 186
         return $this->validateAndGetErrors($validationRuleAttribute, $data, $customRules ?? $this->getFieldRules());
188 187
     }
189 188
 
190
-    protected function prepareValidatorData(array|string|UploadedFile $data, string $attribute): array
189
+    protected function prepareValidatorData(array | string | UploadedFile $data, string $attribute): array
191 190
     {
192
-        if ($this->validatesArrays() && is_array($data) && ! Str::contains($attribute, '.')) {
191
+        if ($this->validatesArrays() && is_array($data) && !Str::contains($attribute, '.')) {
193 192
             return Arr::has($data, $attribute) ? $data : [$attribute => $data];
194 193
         }
195 194
 
196 195
         if (Str::contains($attribute, '.')) {
197 196
             $validData = [];
198 197
 
199
-            Arr::set($validData, $attribute, ! is_array($data) ? $data : Arr::get($data, $attribute));
198
+            Arr::set($validData, $attribute, !is_array($data) ? $data : Arr::get($data, $attribute));
200 199
 
201 200
             return $validData;
202 201
         }
@@ -211,7 +210,7 @@  discard block
 block discarded – undo
211 210
         $validationRuleAttribute = $this->getValidationAttributeString($attribute);
212 211
 
213 212
         $filesToValidate = Arr::get($items, $attribute);
214
-        $filesToValidate = is_array($filesToValidate) ? array_filter($filesToValidate, function ($item) {
213
+        $filesToValidate = is_array($filesToValidate) ? array_filter($filesToValidate, function($item) {
215 214
             return $item instanceof UploadedFile;
216 215
         }) : (is_a($filesToValidate, UploadedFile::class, true) ? [$filesToValidate] : []);
217 216
 
Please login to merge, or discard this patch.