Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Push — crud-column-support-array ( c4d6a0 )
by Pedro
19:29
created
src/app/Library/CrudPanel/Traits/Columns.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
      */
115 115
     public function makeFirstColumn()
116 116
     {
117
-        if (! $this->columns()) {
117
+        if (!$this->columns()) {
118 118
             return false;
119 119
         }
120 120
 
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
      */
160 160
     public function removeColumns($columns)
161 161
     {
162
-        if (! empty($columns)) {
162
+        if (!empty($columns)) {
163 163
             foreach ($columns as $columnKey) {
164 164
                 $this->removeColumn($columnKey);
165 165
             }
@@ -252,8 +252,8 @@  discard block
 block discarded – undo
252 252
     {
253 253
         $columns = $this->columns();
254 254
 
255
-        return collect($columns)->pluck('entity')->reject(function ($value, $key) {
256
-            return ! $value;
255
+        return collect($columns)->pluck('entity')->reject(function($value, $key) {
256
+            return !$value;
257 257
         })->toArray();
258 258
     }
259 259
 
@@ -329,7 +329,7 @@  discard block
 block discarded – undo
329 329
      */
330 330
     public function hasColumnWhere($attribute, $value)
331 331
     {
332
-        $match = Arr::first($this->columns(), function ($column, $columnKey) use ($attribute, $value) {
332
+        $match = Arr::first($this->columns(), function($column, $columnKey) use ($attribute, $value) {
333 333
             return isset($column[$attribute]) && $column[$attribute] == $value;
334 334
         });
335 335
 
@@ -345,7 +345,7 @@  discard block
 block discarded – undo
345 345
      */
346 346
     public function firstColumnWhere($attribute, $value)
347 347
     {
348
-        return Arr::first($this->columns(), function ($column, $columnKey) use ($attribute, $value) {
348
+        return Arr::first($this->columns(), function($column, $columnKey) use ($attribute, $value) {
349 349
             return isset($column[$attribute]) && $column[$attribute] == $value;
350 350
         });
351 351
     }
@@ -395,8 +395,8 @@  discard block
 block discarded – undo
395 395
      */
396 396
     public function countColumnsWithoutActions()
397 397
     {
398
-        return collect($this->columns())->filter(function ($column, $key) {
399
-            return ! isset($column['hasActions']) || $column['hasActions'] == false;
398
+        return collect($this->columns())->filter(function($column, $key) {
399
+            return !isset($column['hasActions']) || $column['hasActions'] == false;
400 400
         })->count();
401 401
     }
402 402
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/ColumnsProtectedMethods.php 1 patch
Spacing   +7 added lines, -8 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
             $column = ['name' => $column];
50 50
         }
51 51
 
52
-        if (is_array($column) && ! isset($column['name'])) {
52
+        if (is_array($column) && !isset($column['name'])) {
53 53
             $column['name'] = 'anonymous_column_'.Str::random(5);
54 54
         }
55 55
 
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
      */
66 66
     protected function makeSureColumnHasLabel($column)
67 67
     {
68
-        if (! isset($column['label'])) {
68
+        if (!isset($column['label'])) {
69 69
             $column['label'] = mb_ucfirst($this->makeLabel($column['name']));
70 70
         }
71 71
 
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
      */
147 147
     protected function makeSureColumnHasKey($column)
148 148
     {
149
-        if (! isset($column['key'])) {
149
+        if (!isset($column['key'])) {
150 150
             $column['key'] = str_replace('.', '__', $column['name']);
151 151
         }
152 152
 
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
      */
165 165
     protected function makeSureColumnHasWrapper($column)
166 166
     {
167
-        if (! isset($column['wrapper'])) {
167
+        if (!isset($column['wrapper'])) {
168 168
             $column['wrapper'] = [];
169 169
         }
170 170
 
@@ -255,7 +255,7 @@  discard block
 block discarded – undo
255 255
     {
256 256
         // if this is a relation type field and no corresponding model was specified,
257 257
         // get it from the relation method defined in the main model
258
-        if (isset($column['entity']) && $column['entity'] !== false && ! isset($column['model'])) {
258
+        if (isset($column['entity']) && $column['entity'] !== false && !isset($column['model'])) {
259 259
             $column['model'] = $this->getRelationModel($column['entity']);
260 260
         }
261 261
 
@@ -276,8 +276,7 @@  discard block
 block discarded – undo
276 276
         $columnsArray = $this->columns();
277 277
 
278 278
         if (array_key_exists($targetColumnName, $columnsArray)) {
279
-            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) :
280
-                array_search($targetColumnName, array_keys($columnsArray)) + 1;
279
+            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) : array_search($targetColumnName, array_keys($columnsArray)) + 1;
281 280
 
282 281
             $element = array_pop($columnsArray);
283 282
             $beginningPart = array_slice($columnsArray, 0, $targetColumnPosition, true);
@@ -299,7 +298,7 @@  discard block
 block discarded – undo
299 298
     {
300 299
         static $cache = [];
301 300
 
302
-        if (! $this->driverIsSql()) {
301
+        if (!$this->driverIsSql()) {
303 302
             return true;
304 303
         }
305 304
 
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/ShowOperation.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -30,25 +30,25 @@
 block discarded – undo
30 30
         $this->crud->allowAccess('show');
31 31
         $this->crud->setOperationSetting('setFromDb', true);
32 32
 
33
-        $this->crud->operation('show', function () {
33
+        $this->crud->operation('show', function() {
34 34
             $this->crud->loadDefaultOperationSettingsFromConfig();
35 35
 
36
-            if (! method_exists($this, 'setupShowOperation')) {
36
+            if (!method_exists($this, 'setupShowOperation')) {
37 37
                 $this->autoSetupShowOperation();
38 38
             }
39 39
         });
40 40
 
41
-        $this->crud->operation('list', function () {
41
+        $this->crud->operation('list', function() {
42 42
             $this->crud->addButton('line', 'show', 'view', 'crud::buttons.show', 'beginning');
43 43
         });
44 44
 
45
-        $this->crud->operation(['create', 'update'], function () {
45
+        $this->crud->operation(['create', 'update'], function() {
46 46
             $this->crud->addSaveAction([
47 47
                 'name' => 'save_and_preview',
48
-                'visible' => function ($crud) {
48
+                'visible' => function($crud) {
49 49
                     return $crud->hasAccess('show');
50 50
                 },
51
-                'redirect' => function ($crud, $request, $itemId = null) {
51
+                'redirect' => function($crud, $request, $itemId = null) {
52 52
                     $itemId = $itemId ?: $request->input('id');
53 53
                     $redirectUrl = $crud->route.'/'.$itemId.'/show';
54 54
                     if ($request->has('_locale')) {
Please login to merge, or discard this patch.
database/migrations/2020_03_31_114745_create_pivotable_relations_tables.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -13,14 +13,14 @@  discard block
 block discarded – undo
13 13
      */
14 14
     public function up()
15 15
     {
16
-        Schema::create('comments', function (Blueprint $table) {
16
+        Schema::create('comments', function(Blueprint $table) {
17 17
             $table->bigIncrements('id');
18 18
             $table->string('text')->nullable();
19 19
             $table->morphs('commentable');
20 20
             $table->timestamps();
21 21
         });
22 22
 
23
-        Schema::create('recommendables', function (Blueprint $table) {
23
+        Schema::create('recommendables', function(Blueprint $table) {
24 24
             $table->bigIncrements('id');
25 25
             $table->string('text')->nullable();
26 26
             $table->morphs('recommendable');
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
             $table->timestamps();
29 29
         });
30 30
 
31
-        Schema::create('billables', function (Blueprint $table) {
31
+        Schema::create('billables', function(Blueprint $table) {
32 32
             $table->bigIncrements('id');
33 33
             $table->string('text')->nullable();
34 34
             $table->morphs('billable');
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
             $table->timestamps();
37 37
         });
38 38
 
39
-        Schema::create('articles_user', function (Blueprint $table) {
39
+        Schema::create('articles_user', function(Blueprint $table) {
40 40
             $table->increments('id');
41 41
             $table->integer('article_id')->unsigned();
42 42
             $table->integer('user_id')->unsigned();
@@ -46,26 +46,26 @@  discard block
 block discarded – undo
46 46
             $table->nullableTimestamps();
47 47
         });
48 48
 
49
-        Schema::create('recommends', function (Blueprint $table) {
49
+        Schema::create('recommends', function(Blueprint $table) {
50 50
             $table->bigIncrements('id');
51 51
             $table->string('title')->nullable();
52 52
             $table->timestamps();
53 53
         });
54 54
 
55
-        Schema::create('bills', function (Blueprint $table) {
55
+        Schema::create('bills', function(Blueprint $table) {
56 56
             $table->bigIncrements('id');
57 57
             $table->string('title')->nullable();
58 58
             $table->timestamps();
59 59
         });
60 60
 
61
-        Schema::create('stars', function (Blueprint $table) {
61
+        Schema::create('stars', function(Blueprint $table) {
62 62
             $table->bigIncrements('id');
63 63
             $table->string('starable_type');
64 64
             $table->bigInteger('starable_id');
65 65
             $table->string('title')->nullable();
66 66
         });
67 67
 
68
-        Schema::create('universes', function (Blueprint $table) {
68
+        Schema::create('universes', function(Blueprint $table) {
69 69
             $table->bigIncrements('id');
70 70
             $table->bigInteger('user_id');
71 71
             $table->string('title')->nullable();
@@ -73,13 +73,13 @@  discard block
 block discarded – undo
73 73
             $table->date('end_date')->nullable();
74 74
         });
75 75
 
76
-        Schema::create('planets', function (Blueprint $table) {
76
+        Schema::create('planets', function(Blueprint $table) {
77 77
             $table->bigIncrements('id');
78 78
             $table->bigInteger('user_id')->nullable();
79 79
             $table->string('title')->nullable();
80 80
         });
81 81
 
82
-        Schema::create('transactions', function (Blueprint $table) {
82
+        Schema::create('transactions', function(Blueprint $table) {
83 83
             $table->bigIncrements('id')->unique();
84 84
             $table->bigInteger('user_id');
85 85
             $table->string('label')->nullable();
@@ -87,29 +87,29 @@  discard block
 block discarded – undo
87 87
             $table->string('type');
88 88
         });
89 89
 
90
-        Schema::create('planets_non_nullable', function (Blueprint $table) {
90
+        Schema::create('planets_non_nullable', function(Blueprint $table) {
91 91
             $table->bigIncrements('id');
92 92
             $table->bigInteger('user_id');
93 93
             $table->string('title')->nullable();
94 94
         });
95 95
 
96
-        Schema::create('comets', function (Blueprint $table) {
96
+        Schema::create('comets', function(Blueprint $table) {
97 97
             $table->bigIncrements('id');
98 98
             $table->bigInteger('user_id')->default(0);
99 99
         });
100 100
 
101
-        Schema::create('bangs', function (Blueprint $table) {
101
+        Schema::create('bangs', function(Blueprint $table) {
102 102
             $table->bigIncrements('id');
103 103
             $table->string('name');
104 104
         });
105 105
 
106
-        Schema::create('account_details_bang', function (Blueprint $table) {
106
+        Schema::create('account_details_bang', function(Blueprint $table) {
107 107
             $table->bigIncrements('id');
108 108
             $table->bigInteger('account_details_id');
109 109
             $table->bigInteger('bang_id');
110 110
         });
111 111
 
112
-        Schema::create('account_details_bangs_pivot', function (Blueprint $table) {
112
+        Schema::create('account_details_bangs_pivot', function(Blueprint $table) {
113 113
             $table->bigIncrements('id');
114 114
             $table->bigInteger('account_details_id');
115 115
             $table->bigInteger('bang_id');
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelReadTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -284,7 +284,7 @@  discard block
 block discarded – undo
284 284
 
285 285
     public function testEnableDetailsRow()
286 286
     {
287
-        if (! backpack_pro()) {
287
+        if (!backpack_pro()) {
288 288
             $this->expectException(\Backpack\CRUD\app\Exceptions\BackpackProRequiredException::class);
289 289
         }
290 290
 
@@ -319,7 +319,7 @@  discard block
 block discarded – undo
319 319
 
320 320
     public function testEnableExportButtons()
321 321
     {
322
-        if (! backpack_pro()) {
322
+        if (!backpack_pro()) {
323 323
             $this->expectException(\Backpack\CRUD\app\Exceptions\BackpackProRequiredException::class);
324 324
         }
325 325
 
Please login to merge, or discard this patch.
src/app/Console/Commands/Traits/PrettyCommandOutput.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
         $command = is_string($command) ? explode(' ', $command) : $command;
27 27
 
28 28
         $process = new Process($command, null, null, null, $this->option('timeout'));
29
-        $process->run(function ($type, $buffer) {
29
+        $process->run(function($type, $buffer) {
30 30
             if (Process::ERR === $type) {
31 31
                 $this->echo('comment', $buffer);
32 32
             } else {
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
         });
36 36
 
37 37
         // executes after the command finishes
38
-        if (! $process->isSuccessful()) {
38
+        if (!$process->isSuccessful()) {
39 39
             throw new ProcessFailedException($process);
40 40
         }
41 41
 
@@ -246,7 +246,7 @@  discard block
 block discarded – undo
246 246
     public function askHint(string $question, array $hints, string $default)
247 247
     {
248 248
         $hints = collect($hints)
249
-            ->map(function ($hint) {
249
+            ->map(function($hint) {
250 250
                 return " <fg=gray>│ $hint</>";
251 251
             })
252 252
             ->join(PHP_EOL);
Please login to merge, or discard this patch.
src/app/Console/Commands/Traits/AddonsHelper.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
 
21 21
         $details = null;
22 22
         $process = new Process(['composer', 'config', 'repositories']);
23
-        $process->run(function ($type, $buffer) use (&$details) {
23
+        $process->run(function($type, $buffer) use (&$details) {
24 24
             if ($type !== Process::ERR && $buffer !== '') {
25 25
                 $details = json_decode($buffer);
26 26
             } else {
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
         $this->progressBlock('Creating repositories entry in composer.json');
40 40
 
41 41
         $process = new Process(['composer', 'config', 'repositories.backpack', 'composer', $backpackRepo]);
42
-        $process->run(function ($type, $buffer) use ($backpackRepo) {
42
+        $process->run(function($type, $buffer) use ($backpackRepo) {
43 43
             if ($type === Process::ERR) {
44 44
                 // Fallback
45 45
                 $composerJson = Str::of(File::get('composer.json'));
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
         // Check if auth exists
79 79
         $details = null;
80 80
         $process = new Process(['composer', 'config', 'http-basic.backpackforlaravel.com']);
81
-        $process->run(function ($type, $buffer) use (&$details) {
81
+        $process->run(function($type, $buffer) use (&$details) {
82 82
             if ($type !== Process::ERR && $buffer !== '') {
83 83
                 $details = json_decode($buffer);
84 84
             } elseif (File::exists('auth.json')) {
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
         $this->progressBlock('Creating auth.json file with your authentication token');
106 106
 
107 107
         $process = new Process(['composer', 'config', 'http-basic.backpackforlaravel.com', $username, $password]);
108
-        $process->run(function ($type, $buffer) use ($username, $password) {
108
+        $process->run(function($type, $buffer) use ($username, $password) {
109 109
             if ($type === Process::ERR) {
110 110
                 // Fallback
111 111
                 $authFile = [
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
 
120 120
                 if (File::exists('auth.json')) {
121 121
                     $currentFile = json_decode(File::get('auth.json'), true);
122
-                    if (! ($currentFile['http-basic']['backpackforlaravel.com'] ?? false)) {
122
+                    if (!($currentFile['http-basic']['backpackforlaravel.com'] ?? false)) {
123 123
                         $authFile = array_merge_recursive($authFile, $currentFile);
124 124
                     }
125 125
                 }
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
         // Require package
159 159
         $process = new Process(array_merge(['composer', 'require'], $options, [$package]));
160 160
         $process->setTimeout(300);
161
-        $process->run(function ($type, $buffer) use ($process) {
161
+        $process->run(function($type, $buffer) use ($process) {
162 162
             if ($type === Process::ERR) {
163 163
                 \Log::error($buffer);
164 164
             }
Please login to merge, or discard this patch.
src/app/Console/Commands/Fix.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -47,20 +47,20 @@
 block discarded – undo
47 47
         $this->line('Checking error views...');
48 48
 
49 49
         // check if the `resources/views/errors` directory exists
50
-        if (! is_dir($errorsDirectory)) {
50
+        if (!is_dir($errorsDirectory)) {
51 51
             $this->info('Your error views are not vulnerable. Nothing to do here.');
52 52
 
53 53
             return;
54 54
         }
55 55
 
56 56
         $views = scandir($errorsDirectory);
57
-        $views = array_filter($views, function ($file) {
57
+        $views = array_filter($views, function($file) {
58 58
             // eliminate ".", ".." and any hidden files like .gitignore or .gitkeep
59 59
             return substr($file, 0, 1) != '.';
60 60
         });
61 61
 
62 62
         // check if there are actually views inside the directory
63
-        if (! count($views)) {
63
+        if (!count($views)) {
64 64
             $this->info('Your error views are not vulnerable. Nothing to do here.');
65 65
 
66 66
             return;
Please login to merge, or discard this patch.
src/app/Console/Commands/AddCustomRouteContent.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
         $this->progressBlock("Adding route to <fg=blue>$path</>");
51 51
 
52 52
         // Validate file exists
53
-        if (! $disk->exists($path)) {
53
+        if (!$disk->exists($path)) {
54 54
             Artisan::call('vendor:publish', ['--provider' => \Backpack\CRUD\BackpackServiceProvider::class, '--tag' => 'custom_routes']);
55 55
             $this->handle();
56 56
 
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
         $file_lines[$end_line_number] = '    '.$code;
74 74
         $new_file_content = implode(PHP_EOL, $file_lines);
75 75
 
76
-        if (! $disk->put($path, $new_file_content)) {
76
+        if (!$disk->put($path, $new_file_content)) {
77 77
             $this->errorProgressBlock();
78 78
             $this->note('Could not write to file.', 'red');
79 79
 
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
 
95 95
         // otherwise, in case the last line HAS been modified
96 96
         // return the last line that has an ending in it
97
-        $possible_end_lines = array_filter($file_lines, function ($k) {
97
+        $possible_end_lines = array_filter($file_lines, function($k) {
98 98
             return strpos($k, '});') === 0;
99 99
         });
100 100
 
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
      */
116 116
     private function getLastLineNumberThatContains($needle, $haystack)
117 117
     {
118
-        $matchingLines = array_filter($haystack, function ($k) use ($needle) {
118
+        $matchingLines = array_filter($haystack, function($k) use ($needle) {
119 119
             return strpos($k, $needle) !== false;
120 120
         });
121 121
 
Please login to merge, or discard this patch.