Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Push — fix-uploaders ( aaafdb...975ef8 )
by Pedro
12:39
created
tests/Unit/CrudPanel/CrudPanelCreateTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -605,7 +605,7 @@  discard block
 block discarded – undo
605 605
 
606 606
     public function testCreateBelongsToFake()
607 607
     {
608
-        $belongsToField = [   // select_grouped
608
+        $belongsToField = [// select_grouped
609 609
             'label' => 'Select_grouped',
610 610
             'type' => 'select_grouped', //https://github.com/Laravel-Backpack/CRUD/issues/502
611 611
             'name' => 'bang_relation_field',
@@ -741,7 +741,7 @@  discard block
 block discarded – undo
741 741
                 'nickname' => 'i_have_has_one',
742 742
                 'profile_picture' => 'ohh my picture 1.jpg',
743 743
                 'article' => 1,
744
-                'addresses' => [ // HasOne is tested in other test function
744
+                'addresses' => [// HasOne is tested in other test function
745 745
                     [
746 746
                         'city' => 2,
747 747
                         'street' => 'test',
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelValidationTest.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
             'password' => 'test',
46 46
         ]);
47 47
 
48
-        $request->setRouteResolver(function () use ($request) {
48
+        $request->setRouteResolver(function() use ($request) {
49 49
             return (new Route('POST', 'users', ['Backpack\CRUD\Tests\Config\Http\Controllers\UserCrudController', 'create']))->bind($request);
50 50
         });
51 51
 
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
             'email' => '',
86 86
         ]);
87 87
 
88
-        $request->setRouteResolver(function () use ($request) {
88
+        $request->setRouteResolver(function() use ($request) {
89 89
             return (new Route('POST', 'users', ['Backpack\CRUD\Tests\Config\Http\Controllers\UserCrudController', 'create']))->bind($request);
90 90
         });
91 91
 
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
             'password' => 'test',
126 126
         ]);
127 127
 
128
-        $request->setRouteResolver(function () use ($request) {
128
+        $request->setRouteResolver(function() use ($request) {
129 129
             return (new Route('POST', 'users', ['Backpack\CRUD\Tests\Config\Http\Controllers\UserCrudController', 'create']))->bind($request);
130 130
         });
131 131
 
@@ -247,7 +247,7 @@  discard block
 block discarded – undo
247 247
             'name' => 'test',
248 248
         ]);
249 249
 
250
-        $request->setRouteResolver(function () use ($request) {
250
+        $request->setRouteResolver(function() use ($request) {
251 251
             return (new Route('POST', 'users', ['Backpack\CRUD\Tests\Config\Http\Controllers\UserCrudController', 'create']))->bind($request);
252 252
         });
253 253
 
Please login to merge, or discard this patch.
src/app/Library/Uploaders/SingleBase64Image.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@  discard block
 block discarded – undo
14 14
         $value = $value ?? CRUD::getRequest()->get($this->getName());
15 15
         $previousImage = $this->getPreviousFiles($entry);
16 16
 
17
-        if (! $value && $previousImage) {
17
+        if (!$value && $previousImage) {
18 18
             Storage::disk($this->getDisk())->delete($previousImage);
19 19
 
20 20
             return null;
@@ -67,6 +67,6 @@  discard block
 block discarded – undo
67 67
 
68 68
     protected function shouldKeepPreviousValueUnchanged(Model $entry, $entryValue): bool
69 69
     {
70
-        return $entry->exists && is_string($entryValue) && ! Str::startsWith($entryValue, 'data:image');
70
+        return $entry->exists && is_string($entryValue) && !Str::startsWith($entryValue, 'data:image');
71 71
     }
72 72
 }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/FieldsProtectedMethods.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
             return ['name' => Str::replace(' ', '', $field)];
116 116
         }
117 117
 
118
-        if (is_array($field) && ! isset($field['name'])) {
118
+        if (is_array($field) && !isset($field['name'])) {
119 119
             abort(500, 'All fields must have their name defined');
120 120
         }
121 121
 
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
189 189
         }
190 190
         // if there's a model defined, but no attribute
191 191
         // guess an attribute using the identifiableAttribute functionality in CrudTrait
192
-        if (isset($field['model']) && ! isset($field['attribute']) && method_exists($field['model'], 'identifiableAttribute')) {
192
+        if (isset($field['model']) && !isset($field['attribute']) && method_exists($field['model'], 'identifiableAttribute')) {
193 193
             $field['attribute'] = (new $field['model']())->identifiableAttribute();
194 194
         }
195 195
 
@@ -205,7 +205,7 @@  discard block
 block discarded – undo
205 205
      */
206 206
     protected function makeSureFieldHasLabel($field)
207 207
     {
208
-        if (! isset($field['label'])) {
208
+        if (!isset($field['label'])) {
209 209
             $name = str_replace(',', ' ', $field['name']);
210 210
             $name = str_replace('_id', '', $name);
211 211
             $field['label'] = mb_ucfirst(str_replace('_', ' ', $name));
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
223 223
      */
224 224
     protected function makeSureFieldHasType($field)
225 225
     {
226
-        if (! isset($field['type'])) {
226
+        if (!isset($field['type'])) {
227 227
             $field['type'] = isset($field['relation_type']) ? $this->inferFieldTypeFromRelationType($field['relation_type']) : $this->inferFieldTypeFromDbColumnType($field['name']);
228 228
         }
229 229
 
@@ -256,16 +256,16 @@  discard block
 block discarded – undo
256 256
      */
257 257
     protected function makeSureSubfieldsHaveNecessaryAttributes($field)
258 258
     {
259
-        if (! isset($field['subfields']) || ! is_array($field['subfields'])) {
259
+        if (!isset($field['subfields']) || !is_array($field['subfields'])) {
260 260
             return $field;
261 261
         }
262 262
 
263
-        if (! is_multidimensional_array($field['subfields'], true)) {
263
+        if (!is_multidimensional_array($field['subfields'], true)) {
264 264
             abort(500, 'Subfields of «'.$field['name'].'» are malformed. Make sure you provide an array of subfields.');
265 265
         }
266 266
 
267 267
         foreach ($field['subfields'] as $key => $subfield) {
268
-            if (empty($subfield) || ! isset($subfield['name'])) {
268
+            if (empty($subfield) || !isset($subfield['name'])) {
269 269
                 abort(500, 'A subfield of «'.$field['name'].'» is malformed. Subfield attribute name can\'t be empty.');
270 270
             }
271 271
 
@@ -280,7 +280,7 @@  discard block
 block discarded – undo
280 280
             $subfield['baseFieldName'] = is_array($subfield['name']) ? implode(',', $subfield['name']) : $subfield['name'];
281 281
             $subfield['baseFieldName'] = Str::afterLast($subfield['baseFieldName'], '.');
282 282
 
283
-            if (! isset($field['model'])) {
283
+            if (!isset($field['model'])) {
284 284
                 // we're inside a simple 'repeatable' with no model/relationship, so
285 285
                 // we assume all subfields are supposed to be text fields
286 286
                 $subfield['type'] = $subfield['type'] ?? 'text';
@@ -305,11 +305,11 @@  discard block
 block discarded – undo
305 305
                 case 'BelongsToMany':
306 306
                     $pivotSelectorField = static::getPivotFieldStructure($field);
307 307
 
308
-                    $pivot = Arr::where($field['subfields'], function ($item) use ($pivotSelectorField) {
308
+                    $pivot = Arr::where($field['subfields'], function($item) use ($pivotSelectorField) {
309 309
                         return $item['name'] === $pivotSelectorField['name'];
310 310
                     });
311 311
 
312
-                    if (! empty($pivot)) {
312
+                    if (!empty($pivot)) {
313 313
                         break;
314 314
                     }
315 315
 
@@ -322,11 +322,11 @@  discard block
 block discarded – undo
322 322
                     $entity = isset($field['baseEntity']) ? $field['baseEntity'].'.'.$field['entity'] : $field['entity'];
323 323
                     $relationInstance = $this->getRelationInstance(['entity' => $entity]);
324 324
 
325
-                    $localKeyField = Arr::where($field['subfields'], function ($item) use ($relationInstance) {
325
+                    $localKeyField = Arr::where($field['subfields'], function($item) use ($relationInstance) {
326 326
                         return $item['name'] === $relationInstance->getRelated()->getKeyName();
327 327
                     });
328 328
 
329
-                    if (! empty($localKeyField)) {
329
+                    if (!empty($localKeyField)) {
330 330
                         break;
331 331
                     }
332 332
 
@@ -351,7 +351,7 @@  discard block
 block discarded – undo
351 351
     {
352 352
         // if a tab was mentioned, we should enable it
353 353
         if (isset($field['tab'])) {
354
-            if (! $this->tabsEnabled()) {
354
+            if (!$this->tabsEnabled()) {
355 355
                 $this->enableTabs();
356 356
             }
357 357
         }
Please login to merge, or discard this patch.
src/ThemeServiceProvider.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@  discard block
 block discarded – undo
14 14
     protected string $packageName = 'theme-name';
15 15
     protected array $commands = [];
16 16
     protected bool $theme = true;
17
-    protected null|string $componentsNamespace = null;
17
+    protected null | string $componentsNamespace = null;
18 18
 
19 19
     /**
20 20
      * -------------------------
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
         }
146 146
 
147 147
         // Registering package commands.
148
-        if (! empty($this->commands)) {
148
+        if (!empty($this->commands)) {
149 149
             $this->commands($this->commands);
150 150
         }
151 151
     }
@@ -240,7 +240,7 @@  discard block
 block discarded – undo
240 240
     protected function packageDirectoryExistsAndIsNotEmpty($name)
241 241
     {
242 242
         // check if directory exists
243
-        if (! is_dir($this->getPath().'/'.$name)) {
243
+        if (!is_dir($this->getPath().'/'.$name)) {
244 244
             return false;
245 245
         }
246 246
 
@@ -265,7 +265,7 @@  discard block
 block discarded – undo
265 265
     public function registerPackageBladeComponents()
266 266
     {
267 267
         if ($this->componentsNamespace) {
268
-            $this->app->afterResolving(BladeCompiler::class, function () {
268
+            $this->app->afterResolving(BladeCompiler::class, function() {
269 269
                 Blade::componentNamespace($this->componentsNamespace, $this->packageName);
270 270
             });
271 271
         }
Please login to merge, or discard this patch.
src/app/Library/Database/Table.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@
 block discarded – undo
22 22
 
23 23
                 public function getNotnull()
24 24
                 {
25
-                    return ! $this->column['nullable'];
25
+                    return !$this->column['nullable'];
26 26
                 }
27 27
 
28 28
                 public function getDefault()
Please login to merge, or discard this patch.
src/app/Models/Traits/HasIdentifiableAttribute.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@
 block discarded – undo
53 53
         // we get the first column from database
54 54
         // that is NOT indexed (usually primary, foreign keys)
55 55
         foreach ($columnNames as $columnName) {
56
-            if (! in_array($columnName, $indexes)) {
56
+            if (!in_array($columnName, $indexes)) {
57 57
                 //check for convention "field<_id>" in case developer didn't add foreign key constraints.
58 58
                 if (strpos($columnName, '_id') !== false) {
59 59
                     continue;
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/AutoSet.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -14,8 +14,8 @@  discard block
 block discarded – undo
14 14
     {
15 15
         $this->getDbColumnTypes();
16 16
 
17
-        array_map(function ($field) use ($setFields, $setColumns) {
18
-            if ($setFields && ! isset($this->getCleanStateFields()[$field])) {
17
+        array_map(function($field) use ($setFields, $setColumns) {
18
+            if ($setFields && !isset($this->getCleanStateFields()[$field])) {
19 19
                 $this->addField([
20 20
                     'name' => $field,
21 21
                     'label' => $this->makeLabel($field),
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
                 ]);
29 29
             }
30 30
 
31
-            if ($setColumns && ! in_array($field, $this->model->getHidden()) && ! isset($this->columns()[$field])) {
31
+            if ($setColumns && !in_array($field, $this->model->getHidden()) && !isset($this->columns()[$field])) {
32 32
                 $this->addColumn([
33 33
                     'name' => $field,
34 34
                     'label' => $this->makeLabel($field),
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
     {
51 51
         $dbColumnTypes = [];
52 52
 
53
-        if (! $this->driverIsSql()) {
53
+        if (!$this->driverIsSql()) {
54 54
             return $dbColumnTypes;
55 55
         }
56 56
         $dbColumns = $this->getDbTableColumns();
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
 
116 116
         $dbColumnTypes = $this->getDbColumnTypes();
117 117
 
118
-        if (! isset($dbColumnTypes[$fieldName])) {
118
+        if (!isset($dbColumnTypes[$fieldName])) {
119 119
             return 'text';
120 120
         }
121 121
 
@@ -210,12 +210,12 @@  discard block
 block discarded – undo
210 210
     {
211 211
         $fillable = $this->model->getFillable();
212 212
 
213
-        if (! $this->driverIsSql()) {
213
+        if (!$this->driverIsSql()) {
214 214
             $columns = $fillable;
215 215
         } else {
216 216
             // Automatically-set columns should be both in the database, and in the $fillable variable on the Eloquent Model
217 217
             $columns = $this->model::getDbTableSchema()->getColumnsNames();
218
-            if (! empty($fillable)) {
218
+            if (!empty($fillable)) {
219 219
                 $columns = array_intersect($columns, $fillable);
220 220
             }
221 221
         }
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelAutoSetTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -848,7 +848,7 @@
 block discarded – undo
848 848
 
849 849
     public function testSetDoctrineTypesMapping()
850 850
     {
851
-        if (! method_exists($this->crudPanel->getModel()->getConnection(), 'getDoctrineConnection')) {
851
+        if (!method_exists($this->crudPanel->getModel()->getConnection(), 'getDoctrineConnection')) {
852 852
             $this->markTestSkipped('This test is only for Laravel 10, Laravel 11 does not have dbal as a dependency anymore');
853 853
         }
854 854
 
Please login to merge, or discard this patch.