Laravel-Backpack / CRUD

src/CrudPanel.php

Spacing +13 added lines, -13 removed lines

@@ -90,11 +90,11 @@ 
      */
     public function setModel($model_namespace)
     {
-        if (! class_exists($model_namespace)) {
+        if (!class_exists($model_namespace)) {
             throw new \Exception('The model does not exist.', 500);
         }
 
-        if (! method_exists($model_namespace, 'hasCrudTrait')) {
+        if (!method_exists($model_namespace, 'hasCrudTrait')) {
             throw new \Exception('Please use CrudTrait on the model.', 500);
         }
 
@@ -147,7 +147,7 @@ 
     {
         $complete_route = $route.'.index';
 
-        if (! \Route::has($complete_route)) {
+        if (!\Route::has($complete_route)) {
             throw new \Exception('There are no routes for this route name.', 404);
         }
 
@@ -248,7 +248,7 @@ 
      */
     public function getFirstOfItsTypeInArray($type, $array)
     {
-        return array_first($array, function ($item) use ($type) {
+        return array_first($array, function($item) use ($type) {
             return $item['type'] == $type;
         });
     }
@@ -265,8 +265,8 @@ 
 
     public function sync($type, $fields, $attributes)
     {
-        if (! empty($this->{$type})) {
-            $this->{$type} = array_map(function ($field) use ($fields, $attributes) {
+        if (!empty($this->{$type})) {
+            $this->{$type} = array_map(function($field) use ($fields, $attributes) {
                 if (in_array($field['name'], (array) $fields)) {
                     $field = array_merge($field, $attributes);
                 }
@@ -298,8 +298,8 @@ 
                 }
             }
 
-            return $this->{$items} = array_merge($elements, array_filter($this->{$items}, function ($item) use ($items) {
-                return ! in_array($item['name'], $this->sort[$items]);
+            return $this->{$items} = array_merge($elements, array_filter($this->{$items}, function($item) use ($items) {
+                return !in_array($item['name'], $this->sort[$items]);
             }));
         }
 
@@ -328,15 +328,15 @@ 
     {
         $relationArray = explode('.', $relationString);
 
-        if (! isset($length)) {
+        if (!isset($length)) {
             $length = count($relationArray);
         }
 
-        if (! isset($model)) {
+        if (!isset($model)) {
             $model = $this->model;
         }
 
-        $result = array_reduce(array_splice($relationArray, 0, $length), function ($obj, $method) {
+        $result = array_reduce(array_splice($relationArray, 0, $length), function($obj, $method) {
             return $obj->$method()->getRelated();
         }, $model);
 
@@ -386,7 +386,7 @@ 
         $relation = $model->{$firstRelationName};
 
         $results = [];
-        if (! empty($relation)) {
+        if (!empty($relation)) {
             if ($relation instanceof Collection) {
                 $currentResults = $relation->toArray();
             } else {
@@ -395,7 +395,7 @@ 
 
             array_shift($relationArray);
 
-            if (! empty($relationArray)) {
+            if (!empty($relationArray)) {
                 foreach ($currentResults as $currentResult) {
                     $results = array_merge($results, $this->getRelationModelInstances($currentResult, implode('.', $relationArray)));
                 }

Unused Use Statements +15 added lines, -15 removed lines

@@ -2,31 +2,31 @@
 
 namespace Backpack\CRUD;
 
-use Backpack\CRUD\PanelTraits\Read;
-use Backpack\CRUD\PanelTraits\Tabs;
-use Backpack\CRUD\PanelTraits\Query;
-use Backpack\CRUD\PanelTraits\Views;
 use Backpack\CRUD\PanelTraits\Access;
+use Backpack\CRUD\PanelTraits\AutoFocus;
+use Backpack\CRUD\PanelTraits\AutoSet;
+use Backpack\CRUD\PanelTraits\Buttons;
+use Backpack\CRUD\PanelTraits\Columns;
 use Backpack\CRUD\PanelTraits\Create;
 use Backpack\CRUD\PanelTraits\Delete;
 use Backpack\CRUD\PanelTraits\Errors;
+use Backpack\CRUD\PanelTraits\FakeColumns;
+use Backpack\CRUD\PanelTraits\FakeFields;
 use Backpack\CRUD\PanelTraits\Fields;
-use Backpack\CRUD\PanelTraits\Search;
-use Backpack\CRUD\PanelTraits\Update;
-use Backpack\CRUD\PanelTraits\AutoSet;
-use Backpack\CRUD\PanelTraits\Buttons;
-use Backpack\CRUD\PanelTraits\Columns;
 use Backpack\CRUD\PanelTraits\Filters;
-use Backpack\CRUD\PanelTraits\Reorder;
-use Backpack\CRUD\PanelTraits\AutoFocus;
+use Backpack\CRUD\PanelTraits\HeadingsAndTitle;
 use Backpack\CRUD\PanelTraits\Macroable;
-use Backpack\CRUD\PanelTraits\FakeFields;
 use Backpack\CRUD\PanelTraits\Operations;
-use Backpack\CRUD\PanelTraits\FakeColumns;
-use Illuminate\Database\Eloquent\Collection;
+use Backpack\CRUD\PanelTraits\Query;
+use Backpack\CRUD\PanelTraits\Read;
+use Backpack\CRUD\PanelTraits\Reorder;
 use Backpack\CRUD\PanelTraits\RequiredFields;
-use Backpack\CRUD\PanelTraits\HeadingsAndTitle;
+use Backpack\CRUD\PanelTraits\Search;
+use Backpack\CRUD\PanelTraits\Tabs;
+use Backpack\CRUD\PanelTraits\Update;
+use Backpack\CRUD\PanelTraits\Views;
 use Backpack\CRUD\PanelTraits\ViewsAndRestoresRevisions;
+use Illuminate\Database\Eloquent\Collection;
 
 class CrudPanel
 {

src/PanelTraits/Views.php

Doc Comments +7 added lines, -1 removed lines

@@ -157,7 +157,7 @@ 
 
     /**
      * Sets the edit content class.
-     * @param string $editContentClass content class
+     * @param string $showContentClass content class
      */
     public function setShowContentClass(string $showContentClass)
     {
@@ -332,6 +332,9 @@ 
         return $this->getShowView();
     }
 
+    /**
+     * @param string $view
+     */
     public function setPreviewView($view)
     {
         return $this->setShowView($view);
@@ -342,6 +345,9 @@ 
         return $this->getEditView();
     }
 
+    /**
+     * @param string $view
+     */
     public function setUpdateView($view)
     {
         return $this->setEditView($view);

src/PanelTraits/Query.php

Doc Comments +1 added lines, -1 removed lines

@@ -62,7 +62,7 @@
      * Order results of the query in a custom way.
      *
      * @param  array $column           Column array with all attributes
-     * @param  string $column_direction ASC or DESC
+     * @param  string $columnDirection ASC or DESC
      *
      * @return \Illuminate\Database\Eloquent\Builder
      */

Spacing +1 added lines, -1 removed lines

@@ -68,7 +68,7 @@
      */
     public function customOrderBy($column, $columnDirection = 'asc')
     {
-        if (! isset($column['orderLogic'])) {
+        if (!isset($column['orderLogic'])) {
             return $this->query;
         }
 

src/app/Http/Controllers/Operations/CloneOperation.php

Doc Comments +1 added lines, -2 removed lines

@@ -9,7 +9,7 @@ 
      *
      * @param int $id
      *
-     * @return Response
+     * @return string
      */
     public function clone($id)
     {
@@ -23,7 +23,6 @@ 
     /**
      * Create duplicates of multiple entries in the datatabase.
      *
-     * @param int $id
      *
      * @return Response
      */

src/app/Http/Controllers/Operations/ReorderOperation.php

Spacing +1 added lines, -1 removed lines

@@ -16,7 +16,7 @@
         $this->crud->hasAccessOrFail('reorder');
         $this->crud->setOperation('reorder');
 
-        if (! $this->crud->isReorderEnabled()) {
+        if (!$this->crud->isReorderEnabled()) {
             abort(403, 'Reorder is disabled.');
         }
 

src/app/Http/Controllers/Operations/RevisionsOperation.php

Spacing +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
         $this->crud->setOperation('revisions');
 
         $revisionId = \Request::input('revision_id', false);
-        if (! $revisionId) {
+        if (!$revisionId) {
             abort(500, 'Can\'t restore revision without revision_id');
         } else {
             $this->crud->restoreRevision($id, $revisionId); // do the update

src/PanelTraits/Buttons.php

Spacing +5 added lines, -5 removed lines

@@ -108,7 +108,7 @@ 
          */
         $button = $this->buttons()->firstWhere('name', $name);
 
-        if (! $button) {
+        if (!$button) {
             abort(500, 'CRUD Button "'.$name.'" not found. Please check the button exists before you modify it.');
         }
 
@@ -129,7 +129,7 @@ 
      */
     public function removeButton($name, $stack = null)
     {
-        $this->buttons = $this->buttons->reject(function ($button) use ($name, $stack) {
+        $this->buttons = $this->buttons->reject(function($button) use ($name, $stack) {
             return $stack == null ? $button->name == $name : ($button->stack == $stack) && ($button->name == $name);
         });
     }
@@ -140,7 +140,7 @@ 
      */
     public function removeButtons($names, $stack = null)
     {
-        if (! empty($names)) {
+        if (!empty($names)) {
             foreach ($names as $name) {
                 $this->removeButton($name, $stack);
             }
@@ -154,14 +154,14 @@ 
 
     public function removeAllButtonsFromStack($stack)
     {
-        $this->buttons = $this->buttons->reject(function ($button) use ($stack) {
+        $this->buttons = $this->buttons->reject(function($button) use ($stack) {
             return $button->stack == $stack;
         });
     }
 
     public function removeButtonFromStack($name, $stack)
     {
-        $this->buttons = $this->buttons->reject(function ($button) use ($name, $stack) {
+        $this->buttons = $this->buttons->reject(function($button) use ($name, $stack) {
             return $button->name == $name && $button->stack == $stack;
         });
     }

Doc Comments +12 added lines

@@ -62,6 +62,9 @@ 
         $this->addButton($stack, $name, 'model_function', $model_function_name, $position);
     }
 
+    /**
+     * @param string $view
+     */
     public function addButtonFromView($stack, $name, $view, $position = false)
     {
         $view = 'crud::buttons.'.$view;
@@ -139,6 +142,9 @@ 
         $this->buttons = collect([]);
     }
 
+    /**
+     * @param string $stack
+     */
     public function removeAllButtonsFromStack($stack)
     {
         $this->buttons = $this->buttons->reject(function ($button) use ($stack) {
@@ -161,6 +167,12 @@ 
     public $type = 'view';
     public $content;
 
+    /**
+     * @param string $stack
+     * @param string $name
+     * @param string $type
+     * @param string $content
+     */
     public function __construct($stack, $name, $type, $content)
     {
         $this->stack = $stack;

src/helpers.php

Spacing +2 added lines, -2 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-if (! function_exists('square_brackets_to_dots')) {
+if (!function_exists('square_brackets_to_dots')) {
     /**
      * Turns a string from bracket-type array to dot-notation array.
      * Ex: array[0][property] turns into array.0.property.
@@ -17,7 +17,7 @@ 
     }
 }
 
-if (! function_exists('is_countable')) {
+if (!function_exists('is_countable')) {
     /**
      * We need this because is_countable was only introduced in PHP 7.3,
      * and in PHP 7.2 you should check if count() argument is really countable.

src/PanelTraits/AutoSet.php

Spacing +8 added lines, -8 removed lines

@@ -17,12 +17,12 @@ 
      */
     public function setFromDb()
     {
-        if (! $this->driverIsMongoDb()) {
+        if (!$this->driverIsMongoDb()) {
             $this->setDoctrineTypesMapping();
             $this->getDbColumnTypes();
         }
 
-        array_map(function ($field) {
+        array_map(function($field) {
             $new_field = [
                 'name'       => $field,
                 'label'      => $this->makeLabel($field),
@@ -33,14 +33,14 @@ 
                 'attributes' => [],
                 'autoset'    => true,
             ];
-            if (! isset($this->create_fields[$field])) {
+            if (!isset($this->create_fields[$field])) {
                 $this->create_fields[$field] = $new_field;
             }
-            if (! isset($this->update_fields[$field])) {
+            if (!isset($this->update_fields[$field])) {
                 $this->update_fields[$field] = $new_field;
             }
 
-            if (! in_array($field, $this->model->getHidden()) && ! isset($this->columns[$field])) {
+            if (!in_array($field, $this->model->getHidden()) && !isset($this->columns[$field])) {
                 $this->addColumn([
                     'name'  => $field,
                     'label' => $this->makeLabel($field),
@@ -96,7 +96,7 @@ 
      */
     public function getFieldTypeFromDbColumnType($field)
     {
-        if (! array_key_exists($field, $this->db_column_types)) {
+        if (!array_key_exists($field, $this->db_column_types)) {
             return 'text';
         }
 
@@ -162,7 +162,7 @@ 
         $types = ['enum' => 'string'];
         $platform = $this->getSchema()->getConnection()->getDoctrineConnection()->getDatabasePlatform();
         foreach ($types as $type_key => $type_value) {
-            if (! $platform->hasDoctrineTypeMappingFor($type_key)) {
+            if (!$platform->hasDoctrineTypeMappingFor($type_key)) {
                 $platform->registerDoctrineTypeMapping($type_key, $type_value);
             }
         }
@@ -221,7 +221,7 @@ 
             // Automatically-set columns should be both in the database, and in the $fillable variable on the Eloquent Model
             $columns = $this->model->getConnection()->getSchemaBuilder()->getColumnListing($this->model->getTable());
 
-            if (! empty($fillable)) {
+            if (!empty($fillable)) {
                 $columns = array_intersect($columns, $fillable);
             }
         }