Backpack\CRUD\app\Library\Validation\Rules\ValidUploadMultiple::validate()

Complexity

Conditions	8
Paths	25

Size

Total Lines	44
Code Lines	23

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	ValidUploadMultiple::allFiles()	0	9	3

<?php

namespace Backpack\CRUD\app\Library\Validation\Rules;

use Backpack\CRUD\app\Library\CrudPanel\CrudPanelFacade;
use Backpack\CRUD\app\Library\Validation\Rules\Support\ValidateArrayContract;
use Illuminate\Support\Arr;
use Illuminate\Support\Str;

class ValidUploadMultiple extends BackpackCustomRule implements ValidateArrayContract
{
    public function validateRules(string $attribute, mixed $value): array
    {
        $entry = CrudPanelFacade::getCurrentEntry() !== false ? CrudPanelFacade::getCurrentEntry() : null;

The method getCurrentEntry() does not exist on Backpack\CRUD\app\Library\CrudPanel\CrudPanelFacade. Since you implemented __callStatic, consider adding a @method annotation.

        $data = $this->data;
        // `upload_multiple` sends [[0 => null]] when user doesn't upload anything
        // assume that nothing changed on field so nothing is sent on the request.
        if (count($value) === 1 && empty($value[0])) {
            Arr::set($data, $attribute, []);
            $value = [];
        }

        $previousValues = str_contains($attribute, '.') ?
                            (Arr::get($entry?->{Str::before($attribute, '.')} ?? [], Str::after($attribute, '.')) ?? []) :
                            ($entry?->{$attribute} ?? []);

        if (is_string($previousValues)) {
            $previousValues = json_decode($previousValues, true) ?? [];
        }

        Arr::set($data, $attribute, array_merge($previousValues, $value));

        if ($entry) {
            $filesDeleted = CrudPanelFacade::getRequest()->input('clear_'.$attribute) ?? [];

The method getRequest() does not exist on Backpack\CRUD\app\Library\CrudPanel\CrudPanelFacade. Since you implemented __callStatic, consider adding a @method annotation.

            Arr::set($data, $attribute, array_diff(Arr::get($data, $attribute), $filesDeleted));

It seems like Illuminate\Support\Arr::get($data, $attribute) can also be of type null; however, parameter $array of array_diff() does only seem to accept array, maybe add an additional type check?

            return $this->validateFieldAndFile($attribute, $data);
        }

        // if there is no entry, the values we are going to validate need to be files
        // the request was tampered so we will set the attribute to null
        if (! $entry && ! empty(Arr::get($data, $attribute)) && ! $this->allFiles(Arr::get($data, $attribute))) {

It seems like Illuminate\Support\Arr::get($data, $attribute) can also be of type null; however, parameter $values of Backpack\CRUD\app\Library\Validation\Rules\ValidUploadMultiple::allFiles() does only seem to accept array, maybe add an additional type check?

            Arr::set($data, $attribute, null);
        }

        return $this->validateFieldAndFile($attribute, $data);
    }

    private function allFiles(array $values): bool
    {
        foreach ($values as $value) {
            if (! $value instanceof \Illuminate\Http\UploadedFile) {
                return false;
            }
        }

        return true;
    }
}