BaseServiceProvider::boot() - Code Metrics - Inspection of "cleaned up service provider class" - Laravel-Backpack/Base - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 14966f...181c1c )

by Cristian

created 2017-02-05 07:00 UTC

BaseServiceProvider::boot() A

↳ Parent: BaseServiceProvider

Complexity

Conditions	1
Paths	1

Size

Total Lines	19
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	1	Features	0

Metric	Value
c	3
b	1
f	0
dl	0
loc	19
rs	9.4285
cc	1
eloc	9
nc	1
nop	1

<?php

namespace Backpack\Base;

use Illuminate\Routing\Router;
use Illuminate\Support\ServiceProvider;
use Route;

class BaseServiceProvider extends ServiceProvider
{
    /**
     * Indicates if loading of the provider is deferred.
     *
     * @var bool
     */
    protected $defer = false;

    /**
     * Perform post-registration booting of services.
     *
     * @return void
     */
    public function boot(\Illuminate\Routing\Router $router)

    {
        // LOAD THE VIEWS
        // - first the published views (in case they have any changes)
        $this->loadViewsFrom(resource_path('views/vendor/backpack/base'), 'backpack');
        // - then the stock views that come with the package, in case a published view might be missing
        $this->loadViewsFrom(realpath(__DIR__.'/resources/views'), 'backpack');

        $this->loadTranslationsFrom(realpath(__DIR__.'/resources/lang'), 'backpack');

        // use the vendor configuration file as fallback
        $this->mergeConfigFrom(
            __DIR__.'/config/backpack/base.php', 'backpack.base'
        );

        $this->registerAdminMiddleware($this->app->router);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $this->setupRoutes($this->app->router);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $this->publishFiles();
    }

    /**
     * Define the routes for the application.
     *
     * @param \Illuminate\Routing\Router $router
     *
     * @return void
     */
    public function setupRoutes(Router $router)

    {
        Route::group(
        [
            'namespace'  => 'Backpack\Base\app\Http\Controllers',
            'middleware' => 'web',
            'prefix'     => config('backpack.base.route_prefix'),
        ],
        function () {
            // if not otherwise configured, setup the auth routes
            if (config('backpack.base.setup_auth_routes')) {
                Route::auth();
                Route::get('logout', 'Auth\LoginController@logout');
            }

            // if not otherwise configured, setup the dashboard routes
            if (config('backpack.base.setup_dashboard_routes')) {
                Route::get('dashboard', 'AdminController@dashboard');
                Route::get('/', 'AdminController@redirect');
            }
        });
    }

    /**
     * Register any package services.
     *
     * @return void
     */
    public function register()
    {
        // register the current package
        $this->app->bind('base', function ($app) {
            return new Base($app);
        });

        // register its dependencies
        $this->app->register(\Jenssegers\Date\DateServiceProvider::class);
        $this->app->register(\Prologue\Alerts\AlertsServiceProvider::class);

        // register their aliases
        $loader = \Illuminate\Foundation\AliasLoader::getInstance();
        $loader->alias('Alert', \Prologue\Alerts\Facades\Alert::class);
        $loader->alias('Date', \Jenssegers\Date\Date::class);

        // register the services that are only used for development
        if ($this->app->environment() == 'local') {
            if (class_exists('Laracasts\Generators\GeneratorsServiceProvider')) {
                $this->app->register('Laracasts\Generators\GeneratorsServiceProvider');
            }
            if (class_exists('Backpack\Generators\GeneratorsServiceProvider')) {
                $this->app->register('Backpack\Generators\GeneratorsServiceProvider');
            }
        }
    }

    public function registerAdminMiddleware(Router $router)
    {
        // in Laravel 5.4
        if (method_exists($router, 'aliasMiddleware'))
        {
            Route::aliasMiddleware('admin', \Backpack\Base\app\Http\Middleware\Admin::class);
        }
        // in Laravel 5.3 and below
        else
        {
            Route::middleware('admin', \Backpack\Base\app\Http\Middleware\Admin::class);

        }
    }

    public function publishFiles()
    {
        // publish config file
        $this->publishes([__DIR__.'/config' => config_path()], 'config');

        // publish lang files
        $this->publishes([__DIR__.'/resources/lang' => resource_path('lang/vendor/backpack')], 'lang');

        // publish views
        $this->publishes([__DIR__.'/resources/views' => resource_path('views/vendor/backpack/base')], 'views');

        // publish error views
        $this->publishes([__DIR__.'/resources/error_views' => resource_path('views/errors')], 'errors');

        // publish public Backpack assets
        $this->publishes([__DIR__.'/public' => public_path('vendor/backpack')], 'public');

        // publish public AdminLTE assets
        $this->publishes([base_path('vendor/almasaeed2010/adminlte') => public_path('vendor/adminlte')], 'adminlte');
    }
}


1			<?php
2
3			namespace Backpack\Base;
4
5			use Illuminate\Routing\Router;
6			use Illuminate\Support\ServiceProvider;
7			use Route;
8
9			class BaseServiceProvider extends ServiceProvider
10			{
11			/**
12			* Indicates if loading of the provider is deferred.
13			*
14			* @var bool
15			*/
16			protected $defer = false;
17
18			/**
19			* Perform post-registration booting of services.
20			*
21			* @return void
22			*/
23			public function boot(\Illuminate\Routing\Router $router)
			0 ignored issues – show Unused Code introduced 2016-06-02 12:21 UTC by Report Bug Copy Issue Report The parameter `$router` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
24			{
25			// LOAD THE VIEWS
26			// - first the published views (in case they have any changes)
27			$this->loadViewsFrom(resource_path('views/vendor/backpack/base'), 'backpack');
28			// - then the stock views that come with the package, in case a published view might be missing
29			$this->loadViewsFrom(realpath(__DIR__.'/resources/views'), 'backpack');
30
31			$this->loadTranslationsFrom(realpath(__DIR__.'/resources/lang'), 'backpack');
32
33			// use the vendor configuration file as fallback
34			$this->mergeConfigFrom(
35			__DIR__.'/config/backpack/base.php', 'backpack.base'
36			);
37
38			$this->registerAdminMiddleware($this->app->router);
			0 ignored issues – show Bug introduced 2017-02-05 07:02 UTC by Report Bug Copy Issue Report Accessing `router` on the interface `Illuminate\Contracts\Foundation\Application` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
39			$this->setupRoutes($this->app->router);
			0 ignored issues – show Bug introduced 2016-03-16 20:56 UTC by Report Bug Copy Issue Report Accessing `router` on the interface `Illuminate\Contracts\Foundation\Application` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
40			$this->publishFiles();
41			}
42
43			/**
44			* Define the routes for the application.
45			*
46			* @param \Illuminate\Routing\Router $router
47			*
48			* @return void
49			*/
50			public function setupRoutes(Router $router)
			0 ignored issues – show Unused Code introduced 2017-02-03 07:35 UTC by Report Bug Copy Issue Report The parameter `$router` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
51			{
52			Route::group(
53			[
54			'namespace' => 'Backpack\Base\app\Http\Controllers',
55			'middleware' => 'web',
56			'prefix' => config('backpack.base.route_prefix'),
57			],
58			function () {
59			// if not otherwise configured, setup the auth routes
60			if (config('backpack.base.setup_auth_routes')) {
61			Route::auth();
62			Route::get('logout', 'Auth\LoginController@logout');
63			}
64
65			// if not otherwise configured, setup the dashboard routes
66			if (config('backpack.base.setup_dashboard_routes')) {
67			Route::get('dashboard', 'AdminController@dashboard');
68			Route::get('/', 'AdminController@redirect');
69			}
70			});
71			}
72
73			/**
74			* Register any package services.
75			*
76			* @return void
77			*/
78			public function register()
79			{
80			// register the current package
81			$this->app->bind('base', function ($app) {
82			return new Base($app);
83			});
84
85			// register its dependencies
86			$this->app->register(\Jenssegers\Date\DateServiceProvider::class);
87			$this->app->register(\Prologue\Alerts\AlertsServiceProvider::class);
88
89			// register their aliases
90			$loader = \Illuminate\Foundation\AliasLoader::getInstance();
91			$loader->alias('Alert', \Prologue\Alerts\Facades\Alert::class);
92			$loader->alias('Date', \Jenssegers\Date\Date::class);
93
94			// register the services that are only used for development
95			if ($this->app->environment() == 'local') {
96			if (class_exists('Laracasts\Generators\GeneratorsServiceProvider')) {
97			$this->app->register('Laracasts\Generators\GeneratorsServiceProvider');
98			}
99			if (class_exists('Backpack\Generators\GeneratorsServiceProvider')) {
100			$this->app->register('Backpack\Generators\GeneratorsServiceProvider');
101			}
102			}
103			}
104
105			public function registerAdminMiddleware(Router $router)
106			{
107			// in Laravel 5.4
108			if (method_exists($router, 'aliasMiddleware'))
109			{
110			Route::aliasMiddleware('admin', \Backpack\Base\app\Http\Middleware\Admin::class);
111			}
112			// in Laravel 5.3 and below
113			else
114			{
115			Route::middleware('admin', \Backpack\Base\app\Http\Middleware\Admin::class);
			0 ignored issues – show Bug introduced 2017-02-03 07:35 UTC by Report Bug Copy Issue Report The method `middleware()` does not exist on `Illuminate\Routing\Router`. Did you maybe mean `aliasMiddleware()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
116			}
117			}
118
119			public function publishFiles()
120			{
121			// publish config file
122			$this->publishes([__DIR__.'/config' => config_path()], 'config');
123
124			// publish lang files
125			$this->publishes([__DIR__.'/resources/lang' => resource_path('lang/vendor/backpack')], 'lang');
126
127			// publish views
128			$this->publishes([__DIR__.'/resources/views' => resource_path('views/vendor/backpack/base')], 'views');
129
130			// publish error views
131			$this->publishes([__DIR__.'/resources/error_views' => resource_path('views/errors')], 'errors');
132
133			// publish public Backpack assets
134			$this->publishes([__DIR__.'/public' => public_path('vendor/backpack')], 'public');
135
136			// publish public AdminLTE assets
137			$this->publishes([base_path('vendor/almasaeed2010/adminlte') => public_path('vendor/adminlte')], 'adminlte');
138			}
139			}
140

Laravel-Backpack / Base

Push — master ( 14966f...181c1c )

BaseServiceProvider::boot() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like