ResetPasswordController::__construct() - Code Metrics - Inspection of "remove php 5.5 from travis" - Laravel-Backpack/Base - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 953ae8...6664e0 )

by Cristian

created 2016-08-31 17:17 UTC

ResetPasswordController::__construct() A

↳ Parent: ResetPasswordController

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	0

<?php

namespace Backpack\Base\app\Http\Controllers\Auth;

use Backpack\Base\app\Http\Controllers\Controller;
use Illuminate\Foundation\Auth\ResetsPasswords;
use Illuminate\Http\Request;

class ResetPasswordController extends Controller
{
    protected $data = []; // the information we send to the view

    /*
    |--------------------------------------------------------------------------
    | Password Reset Controller
    |--------------------------------------------------------------------------
    |
    | This controller is responsible for handling password reset requests
    | and uses a simple trait to include this behavior. You're free to
    | explore this trait and override any methods you wish to tweak.
    |
    */

    use ResetsPasswords;

    // where to redirect after password was reset
    protected $redirectTo = 'admin/dashboard';

    /**
     * Create a new controller instance.
     *
     * @return void

     */
    public function __construct()
    {
        $this->middleware('guest');
    }

    // -------------------------------------------------------
    // Laravel overwrites for loading backpack views
    // -------------------------------------------------------

    /**
     * Display the password reset view for the given token.
     *
     * If no token is present, display the link request form.
     *
     * @param \Illuminate\Http\Request $request
     * @param string|null              $token
     *
     * @return \Illuminate\Http\Response
     */
    public function showResetForm(Request $request, $token = null)
    {
        $this->data['title'] = trans('backpack::base.reset_password'); // set the page title

        return view('backpack::auth.passwords.reset', $this->data)->with(
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ['token' => $token, 'email' => $request->email]
        );
    }
}


1			<?php
2
3			namespace Backpack\Base\app\Http\Controllers\Auth;
4
5			use Backpack\Base\app\Http\Controllers\Controller;
6			use Illuminate\Foundation\Auth\ResetsPasswords;
7			use Illuminate\Http\Request;
8
9			class ResetPasswordController extends Controller
10			{
11			protected $data = []; // the information we send to the view
12
13			/*
14			\|--------------------------------------------------------------------------
15			\| Password Reset Controller
16			\|--------------------------------------------------------------------------
17			\|
18			\| This controller is responsible for handling password reset requests
19			\| and uses a simple trait to include this behavior. You're free to
20			\| explore this trait and override any methods you wish to tweak.
21			\|
22			*/
23
24			use ResetsPasswords;
25
26			// where to redirect after password was reset
27			protected $redirectTo = 'admin/dashboard';
28
29			/**
30			* Create a new controller instance.
31			*
32			* @return void
			0 ignored issues – show Comprehensibility Best Practice introduced 2016-03-16 20:56 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
33			*/
34			public function __construct()
35			{
36			$this->middleware('guest');
37			}
38
39			// -------------------------------------------------------
40			// Laravel overwrites for loading backpack views
41			// -------------------------------------------------------
42
43			/**
44			* Display the password reset view for the given token.
45			*
46			* If no token is present, display the link request form.
47			*
48			* @param \Illuminate\Http\Request $request
49			* @param string\|null $token
50			*
51			* @return \Illuminate\Http\Response
52			*/
53			public function showResetForm(Request $request, $token = null)
54			{
55			$this->data['title'] = trans('backpack::base.reset_password'); // set the page title
56
57			return view('backpack::auth.passwords.reset', $this->data)->with(
			0 ignored issues – show Bug introduced 2016-08-31 17:22 UTC by Report Bug Copy Issue Report The method `with` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
58			['token' => $token, 'email' => $request->email]
59			);
60			}
61			}
62

Laravel-Backpack / Base

Push — master ( 953ae8...6664e0 )

ResetPasswordController::__construct() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like