Version::handle() - Code Metrics - Inspection of "Added version command" - Laravel-Backpack/Base - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#300)

by Cristian

created 2018-07-16 16:28 UTC

Version::handle() A

↳ Parent: Version

Complexity

Conditions	3
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
nc	2
nop	0
dl	0
loc	18
rs	9.6666
c	0
b	0
f	0

<?php

namespace Backpack\Base\app\Console\Commands;

use Illuminate\Console\Command;
use Symfony\Component\Process\Exception\ProcessFailedException;
use Symfony\Component\Process\Process;

class Version extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'backpack:base:version';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Show the version of PHP and Backpack packages.';

    /**
     * Create a new command instance.
     *
     * @return void

     */
    public function __construct()
    {
        parent::__construct();
    }

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function handle()
    {
        // $this->line(' Installing backpack/generators');

        $command = 'php -v && composer show | grep "backpack\|laravel/framework" && mysql --version';
        $process = new Process($command, null, null, null, 60, null);

        $process->run(function ($type, $buffer) {
            if (Process::ERR === $type) {
                $this->line($buffer);
            } else {
                $this->line($buffer);
            }
        });

        // executes after the command finishes
        if (!$process->isSuccessful()) {
            throw new ProcessFailedException($process);
        }
    }
}


1			<?php
2
3			namespace Backpack\Base\app\Console\Commands;
4
5			use Illuminate\Console\Command;
6			use Symfony\Component\Process\Exception\ProcessFailedException;
7			use Symfony\Component\Process\Process;
8
9			class Version extends Command
10			{
11			/**
12			* The name and signature of the console command.
13			*
14			* @var string
15			*/
16			protected $signature = 'backpack:base:version';
17
18			/**
19			* The console command description.
20			*
21			* @var string
22			*/
23			protected $description = 'Show the version of PHP and Backpack packages.';
24
25			/**
26			* Create a new command instance.
27			*
28			* @return void
			0 ignored issues – show Comprehensibility Best Practice introduced 2017-05-02 12:00 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
29			*/
30			public function __construct()
31			{
32			parent::__construct();
33			}
34
35			/**
36			* Execute the console command.
37			*
38			* @return mixed
39			*/
40			public function handle()
41			{
42			// $this->line(' Installing backpack/generators');
			0 ignored issues – show Unused Code Comprehensibility introduced 2018-07-16 16:30 UTC by Report Bug Copy Issue Report `75%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
43			$command = 'php -v && composer show \| grep "backpack\\|laravel/framework" && mysql --version';
44			$process = new Process($command, null, null, null, 60, null);
			0 ignored issues – show Unused Code introduced 2018-07-16 16:30 UTC by Report Bug Copy Issue Report The call to `Process::__construct()` has too many arguments starting with `null`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
45			$process->run(function ($type, $buffer) {
46			if (Process::ERR === $type) {
47			$this->line($buffer);
48			} else {
49			$this->line($buffer);
50			}
51			});
52
53			// executes after the command finishes
54			if (!$process->isSuccessful()) {
55			throw new ProcessFailedException($process);
56			}
57			}
58			}
59

Laravel-Backpack / Base

Pull Request — master (#300)

Version::handle() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like