MakeCrud::__construct() - Code Metrics - Inspection of "MakeCrud command" - Laravel-Backpack/Base - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#336)

unknown

created 2018-11-17 16:45 UTC

MakeCrud::__construct() A

↳ Parent: MakeCrud

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	0
dl	0
loc	4
rs	10
c	0
b	0
f	0

<?php

namespace App\Console\Commands;

use Artisan;
use Illuminate\Console\Command;

class MakeCrud extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'make:crud {name}';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Creates a new backpack crud';

    /**
     * Create a new command instance.
     *
     * @return void

     */
    public function __construct()
    {
        parent::__construct();
    }

    /**
     * Execute the console command.
     */
    public function handle()
    {
        $argument  = str_singular($this->argument('name'));

        $plural    = title_case(str_plural($argument));
        $snakeName = snake_case($argument);
        $camelName = camel_case($argument);

        $routeArgument   = sprintf("CRUD::resource('%s', '%sCrudController');", $snakeName, $camelName);
        $sidebarArgument = sprintf(
            "<li><a href='{{ backpack_url('%s') }}'><i class='fa fa-question-circle'></i> <span>%s</span></a></li>",
            $argument,
            $plural
        );

        Artisan::call('backpack:crud', ['name' => $snakeName]);
        Artisan::call('backpack:base:add-custom-route', ['code' => $routeArgument]);
        Artisan::call('backpack:base:add-sidebar-content', ['code' => $sidebarArgument]);
    }
}


1			<?php
2
3			namespace App\Console\Commands;
4
5			use Artisan;
6			use Illuminate\Console\Command;
7
8			class MakeCrud extends Command
9			{
10			/**
11			* The name and signature of the console command.
12			*
13			* @var string
14			*/
15			protected $signature = 'make:crud {name}';
16
17			/**
18			* The console command description.
19			*
20			* @var string
21			*/
22			protected $description = 'Creates a new backpack crud';
23
24			/**
25			* Create a new command instance.
26			*
27			* @return void
			0 ignored issues – show Comprehensibility Best Practice introduced 2016-03-16 20:56 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
28			*/
29			public function __construct()
30			{
31			parent::__construct();
32			}
33
34			/**
35			* Execute the console command.
36			*/
37			public function handle()
38			{
39			$argument = str_singular($this->argument('name'));
			0 ignored issues – show Bug introduced 2018-11-17 16:47 UTC by Report Bug Copy Issue Report It seems like `$this->argument('name')` targeting `Illuminate\Console\Command::argument()` can also be of type `array` or `null`; however, `str_singular()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
40			$plural = title_case(str_plural($argument));
41			$snakeName = snake_case($argument);
42			$camelName = camel_case($argument);
43
44			$routeArgument = sprintf("CRUD::resource('%s', '%sCrudController');", $snakeName, $camelName);
45			$sidebarArgument = sprintf(
46			"<li><a href='{{ backpack_url('%s') }}'><i class='fa fa-question-circle'></i> <span>%s</span></a></li>",
47			$argument,
48			$plural
49			);
50
51			Artisan::call('backpack:crud', ['name' => $snakeName]);
52			Artisan::call('backpack:base:add-custom-route', ['code' => $routeArgument]);
53			Artisan::call('backpack:base:add-sidebar-content', ['code' => $sidebarArgument]);
54			}
55			}
56

Laravel-Backpack / Base

Pull Request — master (#336)

MakeCrud::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like