Version::runConsoleCommand() - Code Metrics - Inspection of "[WIP] Laravel 6 support for Backpack v3" - Laravel-Backpack/Base - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#403)

by Cristian

created 2019-09-04 06:16 UTC

Version::runConsoleCommand() A

↳ Parent: Version

Complexity

Conditions	3
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
nc	2
nop	1
dl	0
loc	16
rs	9.7333
c	0
b	0
f	0

<?php

namespace Backpack\Base\app\Console\Commands;

use Illuminate\Console\Command;
use Symfony\Component\Process\Exception\ProcessFailedException;
use Symfony\Component\Process\Process;

class Version extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'backpack:base:version';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Show the version of PHP and Backpack packages.';

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function handle()
    {
        $this->comment('### PHP VERSION:');
        $this->runConsoleCommand('php -v');

        $this->comment('### BACKPACK PACKAGES VERSION:');
        $this->runConsoleCommand('composer show | grep "backpack\|laravel/framework"');

        $this->comment('### MYSQL VERSION:');
        $this->runConsoleCommand('mysql --version');
    }

    /**
     * Run a shell command in a separate process.
     *
     * @param string $command Text to be executed.
     *
     * @return void
     */
    private function runConsoleCommand($command)
    {
        $process = new Process($command, null, null, null, 60, null);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $process->run(function ($type, $buffer) {
            if (Process::ERR === $type) {
                $this->line($buffer);
            } else {
                $this->line($buffer);
            }
        });

        // executes after the command finishes
        if (!$process->isSuccessful()) {
            throw new ProcessFailedException($process);
        }
    }
}


1			<?php
2
3			namespace Backpack\Base\app\Console\Commands;
4
5			use Illuminate\Console\Command;
6			use Symfony\Component\Process\Exception\ProcessFailedException;
7			use Symfony\Component\Process\Process;
8
9			class Version extends Command
10			{
11			/**
12			* The name and signature of the console command.
13			*
14			* @var string
15			*/
16			protected $signature = 'backpack:base:version';
17
18			/**
19			* The console command description.
20			*
21			* @var string
22			*/
23			protected $description = 'Show the version of PHP and Backpack packages.';
24
25			/**
26			* Execute the console command.
27			*
28			* @return mixed
29			*/
30			public function handle()
31			{
32			$this->comment('### PHP VERSION:');
33			$this->runConsoleCommand('php -v');
34
35			$this->comment('### BACKPACK PACKAGES VERSION:');
36			$this->runConsoleCommand('composer show \| grep "backpack\\|laravel/framework"');
37
38			$this->comment('### MYSQL VERSION:');
39			$this->runConsoleCommand('mysql --version');
40			}
41
42			/**
43			* Run a shell command in a separate process.
44			*
45			* @param string $command Text to be executed.
46			*
47			* @return void
48			*/
49			private function runConsoleCommand($command)
50			{
51			$process = new Process($command, null, null, null, 60, null);
			0 ignored issues – show Documentation introduced 2019-02-09 14:31 UTC by Report Bug Copy Issue Report `$command` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Unused Code introduced 2018-07-16 16:30 UTC by Report Bug Copy Issue Report The call to `Process::__construct()` has too many arguments starting with `null`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
52			$process->run(function ($type, $buffer) {
53			if (Process::ERR === $type) {
54			$this->line($buffer);
55			} else {
56			$this->line($buffer);
57			}
58			});
59
60			// executes after the command finishes
61			if (!$process->isSuccessful()) {
62			throw new ProcessFailedException($process);
63			}
64			}
65			}
66

Laravel-Backpack / Base

Pull Request — master (#403)

Version::runConsoleCommand() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like