Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
7 | class PublishBackpackMiddleware extends GeneratorCommand |
||
8 | { |
||
9 | /** |
||
10 | * The name and signature of the console command. |
||
11 | * |
||
12 | * @var string |
||
13 | */ |
||
14 | protected $signature = 'backpack:base:publish-middleware'; |
||
15 | |||
16 | /** |
||
17 | * The console command description. |
||
18 | * |
||
19 | * @var string |
||
20 | */ |
||
21 | protected $description = 'Publish the CheckIfAdmin middleware to App\Http\Middleware\CheckIfAdmin'; |
||
22 | |||
23 | /** |
||
24 | * Get the stub file for the generator. |
||
25 | * |
||
26 | * @return string |
||
27 | */ |
||
28 | protected function getStub() |
||
32 | |||
33 | /** |
||
34 | * Execute the console command. |
||
35 | * |
||
36 | * @return bool|null |
||
37 | */ |
||
38 | View Code Duplication | public function handle() |
|
54 | |||
55 | /** |
||
56 | * Build the class. Replace Backpack namespace with App one. |
||
57 | * |
||
58 | * @param string $name |
||
59 | * |
||
60 | * @return string |
||
61 | */ |
||
62 | protected function buildClass($name = false) |
||
68 | |||
69 | /** |
||
70 | * Replace the namespace for the given stub. |
||
71 | * Replace the User model, if it was moved to App\Models\User. |
||
72 | * |
||
73 | * @param string $stub |
||
74 | * @param string $name |
||
75 | * |
||
76 | * @return $this |
||
77 | */ |
||
78 | protected function makeReplacements(&$stub) |
||
84 | } |
||
85 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.