Backpack\Base\BaseServiceProvider

Complexity

Total Complexity

5

Size/Duplication

Total Lines	108
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	17
Bugs	6	Features	5

3 Methods

Rating	Name	Duplication	Size	Complexity
B	boot()	0	33	1
B	setupRoutes()	0	30	3
A	register()	0	16	1

<?php

namespace Backpack\Base;

use Illuminate\Routing\Router;
use Illuminate\Support\ServiceProvider;
use Route;

class BaseServiceProvider extends ServiceProvider
{
    /**
     * Indicates if loading of the provider is deferred.
     *
     * @var bool
     */
    protected $defer = false;

    /**
     * Perform post-registration booting of services.
     *
     * @return void
     */
    public function boot(\Illuminate\Routing\Router $router)

The parameter $router is not used and could be removed.

    {
        // LOAD THE VIEWS
        // - first the published views (in case they have any changes)
        $this->loadViewsFrom(resource_path('views/vendor/backpack/base'), 'backpack');
        // - then the stock views that come with the package, in case a published view might be missing
        $this->loadViewsFrom(realpath(__DIR__.'/resources/views'), 'backpack');

        $this->loadTranslationsFrom(realpath(__DIR__.'/resources/lang'), 'backpack');

        // use the vendor configuration file as fallback
        $this->mergeConfigFrom(
            __DIR__.'/config/backpack/base.php', 'backpack.base'
        );

        $this->setupRoutes($this->app->router);

Accessing router on the interface Illuminate\Contracts\Foundation\Application suggest that you code against a concrete implementation. How about adding an instanceof check?

        // -------------
        // PUBLISH FILES
        // -------------
        // publish config file
        $this->publishes([__DIR__.'/config' => config_path()], 'config');
        // publish lang files
        $this->publishes([__DIR__.'/resources/lang' => resource_path('lang/vendor/backpack')], 'lang');
        // publish views
        $this->publishes([__DIR__.'/resources/views' => resource_path('views/vendor/backpack/base')], 'views');
        // publish error views
        $this->publishes([__DIR__.'/resources/error_views' => resource_path('views/errors')], 'errors');
        // publish public Backpack assets
        $this->publishes([__DIR__.'/public' => public_path('vendor/backpack')], 'public');
        // publish public AdminLTE assets
        $this->publishes([base_path('vendor/almasaeed2010/adminlte') => public_path('vendor/adminlte')], 'adminlte');
    }

    /**
     * Define the routes for the application.
     *
     * @param \Illuminate\Routing\Router $router
     *
     * @return void
     */
    public function setupRoutes(Router $router)
    {
        // register the 'admin' middleware
        $router->middleware('admin', app\Http\Middleware\Admin::class);

        // if not otherwise configured, setup the auth routes
        if (config('backpack.base.setup_auth_routes')) {
            $router->group(['namespace' => 'Backpack\Base\app\Http\Controllers'], function ($router) {

The parameter $router is not used and could be removed.

                Route::group(['middleware' => 'web', 'prefix' => config('backpack.base.route_prefix')], function () {
                    // Admin authentication routes
                    Route::auth();
                });
            });
        }

        // if not otherwise configured, setup the base routes
        if (config('backpack.base.setup_base_routes')) {
            $router->group(['namespace' => 'Backpack\Base\app\Http\Controllers'], function ($router) {

The parameter $router is not used and could be removed.

                Route::group(['middleware' => 'web', 'prefix' => config('backpack.base.route_prefix')], function () {

                    // Admin dashboard routes
                    Route::get('dashboard', 'AdminController@dashboard');
                    Route::get('/', function () {
                        // The '/admin' route is not to be used as a page, because it breaks the menu's active state.
                        return redirect(config('backpack.base.route_prefix').'/dashboard');
                    });
                });
            });
        }
    }

    /**
     * Register any package services.
     *
     * @return void
     */
    public function register()
    {
        // register the current package
        $this->app->bind('base', function ($app) {
            return new Base($app);
        });

        // register its dependencies
        $this->app->register(\Jenssegers\Date\DateServiceProvider::class);
        $this->app->register(\Prologue\Alerts\AlertsServiceProvider::class);

        // register their aliases
        $loader = \Illuminate\Foundation\AliasLoader::getInstance();
        $loader->alias('Alert', \Prologue\Alerts\Facades\Alert::class);
        $loader->alias('Date', \Jenssegers\Date\Date::class);
    }
}