ResetPasswordController::showResetForm() - Code Metrics - Inspection of "Custom auth guard" - Laravel-Backpack/Base - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#165)

by Cristian

created 2018-03-05 13:00 UTC

ResetPasswordController::showResetForm() A

↳ Parent: ResetPasswordController

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	8
rs	9.4285
cc	1
eloc	4
nc	1
nop	2

<?php

namespace Backpack\Base\app\Http\Controllers\Auth;

use Auth;
use Backpack\Base\app\Http\Controllers\Controller;
use Illuminate\Foundation\Auth\ResetsPasswords;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Password;

class ResetPasswordController extends Controller
{
    protected $data = []; // the information we send to the view

    /*
    |--------------------------------------------------------------------------
    | Password Reset Controller
    |--------------------------------------------------------------------------
    |
    | This controller is responsible for handling password reset requests
    | and uses a simple trait to include this behavior. You're free to
    | explore this trait and override any methods you wish to tweak.
    |
    */

    use ResetsPasswords;

    /**
     * Create a new controller instance.
     *
     * @return void

     */
    public function __construct()

    {
        $guard = backpack_guard_name();

        $this->middleware("guest:$guard");

        // where to redirect after password was reset
        $this->redirectTo = property_exists($this, 'redirectTo') ? $this->redirectTo : config('backpack.base.route_prefix', 'admin').'/dashboard';
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    // -------------------------------------------------------
    // Laravel overwrites for loading backpack views
    // -------------------------------------------------------

    /**
     * Display the password reset view for the given token.
     *
     * If no token is present, display the link request form.
     *
     * @param \Illuminate\Http\Request $request
     * @param string|null              $token
     *
     * @return \Illuminate\Http\Response
     */
    public function showResetForm(Request $request, $token = null)
    {
        $this->data['title'] = trans('backpack::base.reset_password'); // set the page title

        return view('backpack::auth.passwords.reset', $this->data)->with(
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ['token' => $token, 'email' => $request->email]
        );
    }

    /**
     * Get the broker to be used during password reset.
     *
     * @return \Illuminate\Contracts\Auth\PasswordBroker
     */
    public function broker()
    {
        $passwords = config('backpack.base.passwords', config('auth.defaults.passwords'));

        return Password::broker($passwords);
    }

    /**
     * Get the guard to be used during password reset.
     *
     * @return \Illuminate\Contracts\Auth\StatefulGuard
     */
    protected function guard()
    {
        return backpack_auth();
    }
}


1		<?php
2
3		namespace Backpack\Base\app\Http\Controllers\Auth;
4
5		use Auth;
6		use Backpack\Base\app\Http\Controllers\Controller;
7		use Illuminate\Foundation\Auth\ResetsPasswords;
8		use Illuminate\Http\Request;
9		use Illuminate\Support\Facades\Password;
10
11		class ResetPasswordController extends Controller
12		{
13		protected $data = []; // the information we send to the view
14
15		/*
16		\|--------------------------------------------------------------------------
17		\| Password Reset Controller
18		\|--------------------------------------------------------------------------
19		\|
20		\| This controller is responsible for handling password reset requests
21		\| and uses a simple trait to include this behavior. You're free to
22		\| explore this trait and override any methods you wish to tweak.
23		\|
24		*/
25
26		use ResetsPasswords;
27
28		/**
29		* Create a new controller instance.
30		*
31		* @return void
		0 ignored issues – show Comprehensibility Best Practice introduced 2017-05-02 12:00 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
32		*/
33	View Code Duplication	public function __construct()
		0 ignored issues – show Duplication introduced 2018-03-05 13:02 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
34		{
35		$guard = backpack_guard_name();
36
37		$this->middleware("guest:$guard");
38
39		// where to redirect after password was reset
40		$this->redirectTo = property_exists($this, 'redirectTo') ? $this->redirectTo : config('backpack.base.route_prefix', 'admin').'/dashboard';
		0 ignored issues – show Bug introduced 2017-04-18 09:43 UTC by Report Bug Copy Issue Report The property `redirectTo` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
41		}
42
43		// -------------------------------------------------------
44		// Laravel overwrites for loading backpack views
45		// -------------------------------------------------------
46
47		/**
48		* Display the password reset view for the given token.
49		*
50		* If no token is present, display the link request form.
51		*
52		* @param \Illuminate\Http\Request $request
53		* @param string\|null $token
54		*
55		* @return \Illuminate\Http\Response
56		*/
57		public function showResetForm(Request $request, $token = null)
58		{
59		$this->data['title'] = trans('backpack::base.reset_password'); // set the page title
60
61		return view('backpack::auth.passwords.reset', $this->data)->with(
		0 ignored issues – show Bug introduced 2016-08-31 17:22 UTC by Report Bug Copy Issue Report The method `with` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
62		['token' => $token, 'email' => $request->email]
63		);
64		}
65
66		/**
67		* Get the broker to be used during password reset.
68		*
69		* @return \Illuminate\Contracts\Auth\PasswordBroker
70		*/
71		public function broker()
72		{
73		$passwords = config('backpack.base.passwords', config('auth.defaults.passwords'));
74
75		return Password::broker($passwords);
76		}
77
78		/**
79		* Get the guard to be used during password reset.
80		*
81		* @return \Illuminate\Contracts\Auth\StatefulGuard
82		*/
83		protected function guard()
84		{
85		return backpack_auth();
86		}
87		}
88

Laravel-Backpack / Base

Pull Request — master (#165)

ResetPasswordController::showResetForm() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like