AttributeValueRepository::findProductAttributes() - Code Metrics - Inspection of "Merge branch 'develop'" - Laracommerce/laracom - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Retried Inspection

Push — master ( 55431f...64d5a8 )

by Jeff

created 2018-03-17 08:32 UTC

AttributeValueRepository::findProductAttributes() A

↳ Parent: AttributeValueRepository

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	0
dl	0
loc	3
rs	10
c	0
b	0
f	0

<?php

namespace App\Shop\AttributeValues\Repositories;

use App\Shop\Attributes\Attribute;
use App\Shop\AttributeValues\AttributeValue;
use App\Shop\Base\BaseRepository;
use Illuminate\Support\Collection;

class AttributeValueRepository extends BaseRepository implements AttributeValueRepositoryInterface
{
    /**
     * AttributeValueRepository constructor.
     * @param AttributeValue $attributeValue
     */
    public function __construct(AttributeValue $attributeValue)
    {
        parent::__construct($attributeValue);
        $this->model = $attributeValue;
    }

    /**
     * @param Attribute $attribute
     * @param array $data
     * @return AttributeValue
     */
    public function createAttributeValue(Attribute $attribute, array $data) : AttributeValue
    {
        $attributeValue = new AttributeValue($data);
        $attributeValue->attribute()->associate($attribute);
        $attributeValue->save();
        return $attributeValue;
    }

    /**
     * Create the attribute value and associate to the attribute
     *
     * @param Attribute $attribute
     * @return AttributeValue
     */
    public function associateToAttribute(Attribute $attribute) : AttributeValue
    {
        $this->model->attribute()->associate($attribute);
        $this->model->save();
        return $this->model;

    }

    /**
     * Remove association from the attribute
     */
    public function dissociateFromAttribute() : bool
    {
        return $this->model->delete();

    }

    /**
     * @return Collection
     */
    public function findProductAttributes() : Collection
    {
        return $this->model->productAttributes()->get();
    }
}


1			<?php
2
3			namespace App\Shop\AttributeValues\Repositories;
4
5			use App\Shop\Attributes\Attribute;
6			use App\Shop\AttributeValues\AttributeValue;
7			use App\Shop\Base\BaseRepository;
8			use Illuminate\Support\Collection;
9
10			class AttributeValueRepository extends BaseRepository implements AttributeValueRepositoryInterface
11			{
12			/**
13			* AttributeValueRepository constructor.
14			* @param AttributeValue $attributeValue
15			*/
16			public function __construct(AttributeValue $attributeValue)
17			{
18			parent::__construct($attributeValue);
19			$this->model = $attributeValue;
20			}
21
22			/**
23			* @param Attribute $attribute
24			* @param array $data
25			* @return AttributeValue
26			*/
27			public function createAttributeValue(Attribute $attribute, array $data) : AttributeValue
28			{
29			$attributeValue = new AttributeValue($data);
30			$attributeValue->attribute()->associate($attribute);
31			$attributeValue->save();
32			return $attributeValue;
33			}
34
35			/**
36			* Create the attribute value and associate to the attribute
37			*
38			* @param Attribute $attribute
39			* @return AttributeValue
40			*/
41			public function associateToAttribute(Attribute $attribute) : AttributeValue
42			{
43			$this->model->attribute()->associate($attribute);
44			$this->model->save();
45			return $this->model;
			0 ignored issues – show Bug Best Practice introduced 2018-03-17 08:26 UTC by Report Bug Copy Issue Report The expression `return $this->model` returns the type `Illuminate\Database\Eloquent\Model` which includes types incompatible with the type-hinted return `App\Shop\AttributeValues\AttributeValue`. Loading history...
46			}
47
48			/**
49			* Remove association from the attribute
50			*/
51			public function dissociateFromAttribute() : bool
52			{
53			return $this->model->delete();
			0 ignored issues – show Bug Best Practice introduced 2018-03-17 08:26 UTC by Report Bug Copy Issue Report The expression `return $this->model->delete()` could return the type `null` which is incompatible with the type-hinted return `boolean`. Consider adding an additional type-check to rule them out. Loading history...
54			}
55
56			/**
57			* @return Collection
58			*/
59			public function findProductAttributes() : Collection
60			{
61			return $this->model->productAttributes()->get();
62			}
63			}
64

Laracommerce / laracom

Push — master ( 55431f...64d5a8 )

AttributeValueRepository::findProductAttributes() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like