ShortenCommand::handle() - Code Metrics - Inspection of "master" - LaraCrafts/laravel-url-shortener - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#16)

by Raed

created 2019-04-28 17:50 UTC

ShortenCommand::handle() A

↳ Parent: ShortenCommand

Complexity

Conditions	2
Paths	2

Size

Total Lines	14
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	7
nc	2
nop	0
dl	0
loc	14
rs	10
c	0
b	0
f	0

<?php

namespace LaraCrafts\UrlShortener\Console\Commands;

use Illuminate\Console\Command;
use LaraCrafts\UrlShortener\UrlShortenerManager;

class ShortenCommand extends Command
{
    /**
     * The console command name.
     *
     * @var string
     */
    protected $signature = 'url:shorten
                            {url? : The URL to shorten}
                            {--D|driver= : The driver to use to shorten the URL.}';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Shorten a given URL';

    /**
     * The URL Shortener instance.
     *
     * @var \LaraCrafts\UrlShortener\UrlShortenerManager
     */
    protected $shortener;

    /**
     * Create a new ShortenCommand instance.
     *
     * @param \LaraCrafts\UrlShortener\UrlShortenerManager $shortener
     */
    public function __construct(UrlShortenerManager $shortener)
    {
        parent::__construct();

        $this->shortener = $shortener;
    }

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function handle()
    {
        $url = $this->argument('url') ?? $this->ask('Please enter the URL to shorten');

        if (!$url) {
            return $this->error('Aborted: No URL was given.');
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        }

        $driver = $this->shortener->driver($this->option('driver'));

        $shortUrl = $driver->shorten($url);

        $this->info('URL shortened successfully.');
        $this->info("Your short URL is: $shortUrl");
    }
}


1			<?php
2
3			namespace LaraCrafts\UrlShortener\Console\Commands;
4
5			use Illuminate\Console\Command;
6			use LaraCrafts\UrlShortener\UrlShortenerManager;
7
8			class ShortenCommand extends Command
9			{
10			/**
11			* The console command name.
12			*
13			* @var string
14			*/
15			protected $signature = 'url:shorten
16			{url? : The URL to shorten}
17			{--D\|driver= : The driver to use to shorten the URL.}';
18
19			/**
20			* The console command description.
21			*
22			* @var string
23			*/
24			protected $description = 'Shorten a given URL';
25
26			/**
27			* The URL Shortener instance.
28			*
29			* @var \LaraCrafts\UrlShortener\UrlShortenerManager
30			*/
31			protected $shortener;
32
33			/**
34			* Create a new ShortenCommand instance.
35			*
36			* @param \LaraCrafts\UrlShortener\UrlShortenerManager $shortener
37			*/
38			public function __construct(UrlShortenerManager $shortener)
39			{
40			parent::__construct();
41
42			$this->shortener = $shortener;
43			}
44
45			/**
46			* Execute the console command.
47			*
48			* @return mixed
49			*/
50			public function handle()
51			{
52			$url = $this->argument('url') ?? $this->ask('Please enter the URL to shorten');
53
54			if (!$url) {
55			return $this->error('Aborted: No URL was given.');
			0 ignored issues – show Bug introduced 2019-04-28 18:09 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->error('Aborted: No URL was given.')` targeting `Illuminate\Console\Command::error()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
56			}
57
58			$driver = $this->shortener->driver($this->option('driver'));
59
60			$shortUrl = $driver->shorten($url);
61
62			$this->info('URL shortened successfully.');
63			$this->info("Your short URL is: $shortUrl");
64			}
65			}
66

LaraCrafts / laravel-url-shortener

GitHub Access Token became invalid

Pull Request — master (#16)

ShortenCommand::handle() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like