LaraCrafts / laravel-geo-routes

src/DeterminesGeoAccess.php

<?php

namespace LaraCrafts\GeoRoutes;

use Stevebauman\Location\Facades\Location;

trait DeterminesGeoAccess
{
    /**
     * Determine if the request should be allowed through.
     *
     * @param array $countries
     * @param string $strategy
     * @return bool
     */
    protected function shouldHaveAccess(array $countries, string $strategy)
    {
        if (!$countries) {

The expression $countries of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            return $strategy !== 'allow';
        }

        $requestCountry = Location::get()->countryCode;

        if ($strategy === 'allow') {
            return in_array($requestCountry, $countries);
        }

        return !in_array($requestCountry, $countries);
    }
}