LaraCrafts\GeoRoutes\DeterminesGeoAccess

Complexity

Total Complexity

3

Size/Duplication

Total Lines	23
Duplicated Lines	0 %

Test Coverage

Coverage

85.71%

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	shouldHaveAccess()	0	13	3

<?php

namespace LaraCrafts\GeoRoutes;

use Illuminate\Http\Request;
use Stevebauman\Location\Facades\Location;

trait DeterminesGeoAccess
{
    /**
     * Determine if the request should be allowed through.
     *
     * @param \Illuminate\Http\Request $request
     * @param array $countries
     * @param string $strategy
     * @return bool
     */
    protected function shouldHaveAccess(Request $request, array $countries, string $strategy)
    {
        if (!$countries) {

The expression $countries of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            return $strategy !== 'allow';
        }

        $requestCountry = Location::get($request->ip())->countryCode;

        if ($strategy === 'allow') {
            return in_array($requestCountry, $countries);
        }

        return !in_array($requestCountry, $countries);
    }
}