GeoRoutesMiddleware::handle() - Code Metrics - Inspection of "Add the `geo` attribute." - LaraCrafts/laravel-geo-routes - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#29)

by Raed

created 2019-09-15 19:01 UTC

GeoRoutesMiddleware::handle() A

↳ Parent: GeoRoutesMiddleware

Complexity

Conditions	6
Paths	5

Size

Total Lines	30
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	13
CRAP Score	6.0131

Importance

Changes	5
Bugs	0	Features	0

Metric	Value
cc	6
eloc	15
c	5
b	0
f	0
nc	5
nop	2
dl	0
loc	30
ccs	13
cts	14
cp	0.9286
crap	6.0131
rs	9.2222

<?php

namespace LaraCrafts\GeoRoutes\Http\Middleware;

use Closure;
use Exception;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Validator;
use LaraCrafts\GeoRoutes\DeterminesGeoAccess;

class GeoRoutesMiddleware
{
    use DeterminesGeoAccess;


    /**
     * Handle an incoming request.
     *
     * @param \Illuminate\Http\Request $request
     * @param \Closure $next
     * @param string $strategy
     * @param string $countries
     * @param string|null $callback
     *
     * @return mixed
     */
    public function handle(Request $request, Closure $next)
    {
        $route = $request->route();

        if (!$route) {
            #TODO: Invoke the default callback.
            return abort(401);
        }

        $constraint = $route->getAction('geo') ?? [];

        $validator = Validator::make($constraint, [
            'countries' => 'required|array|min:1',
            'countries.*' => 'string|min:2|max:2',
            'strategy' => 'required|in:allow,deny',
        ]);

        if ($validator->fails()) {
            throw new Exception("The GeoRoute constraint is invalid.");
        }

        if ($this->shouldHaveAccess((array)$constraint['countries'], $constraint['strategy'])) {
            return $next($request);
        }

        if (array_key_exists('callback', $constraint) && $callback = $constraint['callback']) {
            return call_user_func_array($callback[0], $callback[1]);
        }

        return abort(401);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
    }
}


1		<?php
2
3		namespace LaraCrafts\GeoRoutes\Http\Middleware;
4
5		use Closure;
6		use Exception;
7		use Illuminate\Http\Request;
8		use Illuminate\Support\Facades\Validator;
9		use LaraCrafts\GeoRoutes\DeterminesGeoAccess;
10
11		class GeoRoutesMiddleware
12		{
13		use DeterminesGeoAccess;
		0 ignored issues – show Bug introduced 2019-01-26 19:47 UTC by Report Bug Copy Issue Report The trait `LaraCrafts\GeoRoutes\DeterminesGeoAccess` requires the property `$countryCode` which is not provided by `LaraCrafts\GeoRoutes\Htt...are\GeoRoutesMiddleware`. Loading history...
14
15		/**
16		* Handle an incoming request.
17		*
18		* @param \Illuminate\Http\Request $request
19		* @param \Closure $next
20		* @param string $strategy
21		* @param string $countries
22		* @param string\|null $callback
23		*
24		* @return mixed
25		*/
26	84	public function handle(Request $request, Closure $next)
27		{
28	84	$route = $request->route();
29
30	84	if (!$route) {
31		#TODO: Invoke the default callback.
32		return abort(401);
33		}
34
35	84	$constraint = $route->getAction('geo') ?? [];
36
37	84	$validator = Validator::make($constraint, [
38	84	'countries' => 'required\|array\|min:1',
39		'countries.*' => 'string\|min:2\|max:2',
40		'strategy' => 'required\|in:allow,deny',
41		]);
42
43	84	if ($validator->fails()) {
44	12	throw new Exception("The GeoRoute constraint is invalid.");
45		}
46
47	72	if ($this->shouldHaveAccess((array)$constraint['countries'], $constraint['strategy'])) {
48	12	return $next($request);
49		}
50
51	60	if (array_key_exists('callback', $constraint) && $callback = $constraint['callback']) {
52	36	return call_user_func_array($callback[0], $callback[1]);
53		}
54
55	24	return abort(401);
		0 ignored issues – show Bug introduced 2019-01-17 22:17 UTC by Report Bug Copy Issue Report Are you sure the usage of `abort(401)` is correct as it seems to always return `null`. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
56		}
57		}
58

LaraCrafts / laravel-geo-routes

Pull Request — master (#29)

GeoRoutesMiddleware::handle() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like