DeterminesGeoAccess::shouldHaveAccess() - Code Metrics - Inspection of "Global middleware" - LaraCrafts/laravel-geo-routes - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#19)

by Choraimy

created 2019-01-26 18:35 UTC

DeterminesGeoAccess::shouldHaveAccess() A

↳ Parent: DeterminesGeoAccess

Complexity

Conditions	3
Paths	3

Size

Total Lines	16
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	8
nc	3
nop	1
dl	0
loc	16
rs	10
c	0
b	0
f	0

<?php

namespace LaraCrafts\GeoRoutes;

use Illuminate\Http\Request;
use Stevebauman\Location\Facades\Location;

trait DeterminesGeoAccess
{
    /**
     * Get the countries.
     *
     * @return string[]
     */
    abstract public function getCountries();

    /**
     * Get the strategy.
     *
     * @return string
     */
    abstract public function getStrategy();

    /**
     * Determine if the request should be allowed through.
     *
     * @param \Illuminate\Http\Request $request
     * @return bool
     */
    public function shouldHaveAccess(Request $request)
    {
        $countries = $this->getCountries();
        $strategy = $this->getStrategy();

        if (!$countries) {

            return $strategy !== 'allow';
        }

        $requestCountry = Location::get($request->ip())->countryCode;

        if ($strategy === 'allow') {
            return in_array($requestCountry, $countries);
        }

        return !in_array($requestCountry, $countries);
    }
}


1			<?php
2
3			namespace LaraCrafts\GeoRoutes;
4
5			use Illuminate\Http\Request;
6			use Stevebauman\Location\Facades\Location;
7
8			trait DeterminesGeoAccess
9			{
10			/**
11			* Get the countries.
12			*
13			* @return string[]
14			*/
15			abstract public function getCountries();
16
17			/**
18			* Get the strategy.
19			*
20			* @return string
21			*/
22			abstract public function getStrategy();
23
24			/**
25			* Determine if the request should be allowed through.
26			*
27			* @param \Illuminate\Http\Request $request
28			* @return bool
29			*/
30			public function shouldHaveAccess(Request $request)
31			{
32			$countries = $this->getCountries();
33			$strategy = $this->getStrategy();
34
35			if (!$countries) {
			0 ignored issues – show Bug Best Practice introduced 2019-01-26 18:57 UTC by Report Bug Copy Issue Report The expression `$countries` of type `string[]` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
36			return $strategy !== 'allow';
37			}
38
39			$requestCountry = Location::get($request->ip())->countryCode;
40
41			if ($strategy === 'allow') {
42			return in_array($requestCountry, $countries);
43			}
44
45			return !in_array($requestCountry, $countries);
46			}
47			}
48

LaraCrafts / laravel-geo-routes

Pull Request — master (#19)

DeterminesGeoAccess::shouldHaveAccess() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like