LaraCrafts\GeoRoutes\GeoRoute

Complexity

Total Complexity

5

Size/Duplication

Total Lines	83
Duplicated Lines	0 %

Test Coverage

Coverage

94.74%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__destruct()	0	3	1
A	applyConstraint()	0	12	3
A	__construct()	0	9	1

<?php

namespace LaraCrafts\GeoRoutes;

use Illuminate\Routing\Route;

/**
 * @mixin \Illuminate\Routing\Route
 */
class GeoRoute
{
    use CallbacksHandler;

    /**
     * Rule is applied.
     *
     * @var bool
     */
    protected $applied;

    /**
     * The countries to apply the rule for.
     *
     * @var array
     */
    protected $countries;

    /**
     * The route.
     *
     * @var \Illuminate\Routing\Route
     */
    protected $route;

    /**
     * Determine if the requests are
     * allowed from the given countries
     *
     * @var boolean
     */
    protected $allowed;

    /**
     * The geo-constraint
     *
     * @var \LaraCrafts\GeoRoutes\GeoConstraint
     */
    protected $constraint;

    /**
     * Create a new GeoRoute instance.
     *
     * @param \Illuminate\Routing\Route $route
     * @param array $countries
     * @param boolean $allowed
     */
    public function __construct(Route $route, array $countries, bool $allowed)
    {
        $this->applied = false;
        $this->countries = $countries;
        $this->route = $route;
        $this->constraint = new GeoConstraint($allowed, $countries);
        $this->constraint->setAccess($allowed);

        CallbacksRegistrar::init();
    }

    /**
     * Destruct the GeoRoute instance and apply the middleware.
     */
    public function __destruct()
    {
        $this->applyConstraint();
    }

    /**
     * Apply the GeoConstraint
     *
     * @return void
     */
    protected function applyConstraint()
    {
        if ($this->applied || !$this->countries) {

The expression $this->countries of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            return;
        }

        $action = $this->route->getAction();
        $action['middleware'][] = 'geo';

        $this->applied = true;
        $this->route->setAction($action);

It seems like $action can also be of type null; however, parameter $action of Illuminate\Routing\Route::setAction() does only seem to accept array, maybe add an additional type check?

        $this->route->GeoConstraint = $this->constraint;

The property GeoConstraint does not seem to exist on Illuminate\Routing\Route.

    }
}