DomainTest::domainProvider() - Code Metrics - Inspection of "Merge branch 'develop'" - Lansoweb/LosDomain - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( da7651...84ea09 )

by Leandro

created 2017-09-07 17:12 UTC

DomainTest::domainProvider() A

↳ Parent: DomainTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	9
rs	9.6666
c	0
b	0
f	0
cc	1
eloc	6
nc	1
nop	0

<?php
namespace LosDomainTest;

use LosDomain\Domain;
use PHPUnit\Framework\TestCase;

class DomainTest extends TestCase
{
    /**
     * @param $httpHost
     * @param $serverName
     * @param $serverPort
     *
     * @dataProvider domainProvider
     */
    public function testDomain($httpHost, $serverName, $serverPort, $expected)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        unset($_SERVER['HTTP_HOST']);
        unset($_SERVER['SERVER_NAME']);
        unset($_SERVER['SERVER_PORT']);
        if (! empty($httpHost)) {
            $_SERVER['HTTP_HOST'] = $httpHost;
        }
        if (! empty($serverName)) {
            $_SERVER['SERVER_NAME'] = $serverName;
        }
        if (! empty($serverPort)) {
            $_SERVER['SERVER_PORT'] = $serverPort;
        }
        $domain = new Domain();
        $this->assertSame($expected, $domain->toString());
        $this->assertSame($expected, $domain->domain());
        $this->assertSame($expected, (string)$domain);
    }

    public function domainProvider()
    {
        return [
            'simple domain' => [ 'abc.com', 'abc.com', '', 'abc.com' ],
            'domain with port' => [ 'abc.com:8080', 'abc.com', 8080, 'abc.com' ],
            'only server_name' => [ '', 'abc.com', 80, 'abc.com' ],
            'no domain' => [ '', '', '', Domain::DEFAULT_DOMAIN ],
        ];
    }
}


1			<?php
2			namespace LosDomainTest;
3
4			use LosDomain\Domain;
5			use PHPUnit\Framework\TestCase;
6
7			class DomainTest extends TestCase
8			{
9			/**
10			* @param $httpHost
11			* @param $serverName
12			* @param $serverPort
13			*
14			* @dataProvider domainProvider
15			*/
16			public function testDomain($httpHost, $serverName, $serverPort, $expected)
			1 ignored issue – show Coding Style introduced 2017-09-07 17:16 UTC by Report Bug Copy Issue Report `testDomain` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
17			{
18			unset($_SERVER['HTTP_HOST']);
19			unset($_SERVER['SERVER_NAME']);
20			unset($_SERVER['SERVER_PORT']);
21			if (! empty($httpHost)) {
22			$_SERVER['HTTP_HOST'] = $httpHost;
23			}
24			if (! empty($serverName)) {
25			$_SERVER['SERVER_NAME'] = $serverName;
26			}
27			if (! empty($serverPort)) {
28			$_SERVER['SERVER_PORT'] = $serverPort;
29			}
30			$domain = new Domain();
31			$this->assertSame($expected, $domain->toString());
32			$this->assertSame($expected, $domain->domain());
33			$this->assertSame($expected, (string)$domain);
34			}
35
36			public function domainProvider()
37			{
38			return [
39			'simple domain' => [ 'abc.com', 'abc.com', '', 'abc.com' ],
40			'domain with port' => [ 'abc.com:8080', 'abc.com', 8080, 'abc.com' ],
41			'only server_name' => [ '', 'abc.com', 80, 'abc.com' ],
42			'no domain' => [ '', '', '', Domain::DEFAULT_DOMAIN ],
43			];
44			}
45			}
46

Lansoweb / LosDomain

GitHub Access Token became invalid

Push — master ( da7651...84ea09 )

DomainTest::domainProvider() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like