UpdatePage::getTitle() - Code Metrics - Inspection of "Merge pull request #27 from pamil/tests-namespace" - Lakion/SyliusCmsBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a13c2f...df1c7f )

by Kamil

created 2017-01-13 09:57 UTC

UpdatePage::getTitle() A

↳ Parent: UpdatePage

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	4
Ratio	100 %

Importance

Changes

Metric	Value
dl	4
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0

<?php

namespace Tests\Lakion\SyliusCmsBundle\Behat\Page\Admin\ProductBlock;

use Sylius\Behat\Page\Admin\Crud\UpdatePage as BaseUpdatePage;

class UpdatePage extends BaseUpdatePage implements UpdatePageInterface

{
    /**
     * {@inheritdoc}
     */
    public function changeBodyTo($body)
    {
        $this->getElement('body')->setValue($body);
    }

    /**
     * {@inheritdoc}
     */
    public function changeLinkTo($link)
    {
        $this->getElement('link')->setValue($link);
    }

    /**
     * {@inheritdoc}
     */
    public function changeTitleTo($title)
    {
        $this->getElement('title')->setValue($title);
    }

    /**
     * {@inheritdoc}
     */
    public function changeProductTo($productName)
    {
        $this->getElement('product')->selectOption($productName);
    }

    /**
     * {@inheritdoc}
     */
    public function getBody()
    {
        return $this->getElement('body')->getValue();
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * {@inheritdoc}
     */
    public function getLink()
    {
        return $this->getElement('link')->getValue();
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * {@inheritdoc}
     */
    public function getTitle()
    {
        return $this->getElement('title')->getValue();
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * {@inheritdoc}
     */
    public function getProduct()
    {
        return $this->getElement('product')->find('css', 'option:selected')->getText();
    }

    /**
     * {@inheritdoc}
     */
    protected function getDefinedElements()
    {
        return array_merge(parent::getDefinedElements(), [
            'body' => '#lakion_sylius_cms_product_block_body',
            'link' => '#lakion_sylius_cms_product_block_linkUrl',
            'product' => '#lakion_sylius_cms_product_block_product',
            'title' => '#lakion_sylius_cms_product_block_title',
        ]);
    }
}


1		<?php
2
3		namespace Tests\Lakion\SyliusCmsBundle\Behat\Page\Admin\ProductBlock;
4
5		use Sylius\Behat\Page\Admin\Crud\UpdatePage as BaseUpdatePage;
6
7	View Code Duplication	class UpdatePage extends BaseUpdatePage implements UpdatePageInterface
		0 ignored issues – show Duplication introduced 2017-01-11 12:16 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
8		{
9		/**
10		* {@inheritdoc}
11		*/
12		public function changeBodyTo($body)
13		{
14		$this->getElement('body')->setValue($body);
15		}
16
17		/**
18		* {@inheritdoc}
19		*/
20		public function changeLinkTo($link)
21		{
22		$this->getElement('link')->setValue($link);
23		}
24
25		/**
26		* {@inheritdoc}
27		*/
28		public function changeTitleTo($title)
29		{
30		$this->getElement('title')->setValue($title);
31		}
32
33		/**
34		* {@inheritdoc}
35		*/
36		public function changeProductTo($productName)
37		{
38		$this->getElement('product')->selectOption($productName);
39		}
40
41		/**
42		* {@inheritdoc}
43		*/
44		public function getBody()
45		{
46		return $this->getElement('body')->getValue();
		0 ignored issues – show Bug Best Practice introduced 2017-01-13 09:48 UTC by Report Bug Copy Issue Report The return type of `return $this->getElement('body')->getValue();` (`string\|boolean\|array`) is incompatible with the return type declared by the interface `Tests\Lakion\SyliusCmsBu...ePageInterface::getBody` of type `string`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
47		}
48
49		/**
50		* {@inheritdoc}
51		*/
52		public function getLink()
53		{
54		return $this->getElement('link')->getValue();
		0 ignored issues – show Bug Best Practice introduced 2017-01-13 09:48 UTC by Report Bug Copy Issue Report The return type of `return $this->getElement('link')->getValue();` (`string\|boolean\|array`) is incompatible with the return type declared by the interface `Tests\Lakion\SyliusCmsBu...ePageInterface::getLink` of type `string`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
55		}
56
57		/**
58		* {@inheritdoc}
59		*/
60		public function getTitle()
61		{
62		return $this->getElement('title')->getValue();
		0 ignored issues – show Bug Best Practice introduced 2017-01-13 09:48 UTC by Report Bug Copy Issue Report The return type of `return $this->getElement('title')->getValue();` (`string\|boolean\|array`) is incompatible with the return type declared by the interface `Tests\Lakion\SyliusCmsBu...PageInterface::getTitle` of type `string`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
63		}
64
65		/**
66		* {@inheritdoc}
67		*/
68		public function getProduct()
69		{
70		return $this->getElement('product')->find('css', 'option:selected')->getText();
71		}
72
73		/**
74		* {@inheritdoc}
75		*/
76		protected function getDefinedElements()
77		{
78		return array_merge(parent::getDefinedElements(), [
79		'body' => '#lakion_sylius_cms_product_block_body',
80		'link' => '#lakion_sylius_cms_product_block_linkUrl',
81		'product' => '#lakion_sylius_cms_product_block_product',
82		'title' => '#lakion_sylius_cms_product_block_title',
83		]);
84		}
85		}
86

Lakion / SyliusCmsBundle

Push — master ( a13c2f...df1c7f )

UpdatePage::getTitle() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like