LakionSyliusCmsExtension::load() - Code Metrics - Inspection of "[WIP] Initial bundle" - Lakion/SyliusCmsBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1)

by Kamil

created 2016-12-13 10:53 UTC

LakionSyliusCmsExtension::load() A

↳ Parent: LakionSyliusCmsExtension

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	12
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	7
nc	1
nop	2

<?php

namespace Lakion\SyliusCmsBundle\DependencyInjection;

use Sylius\Bundle\ResourceBundle\DependencyInjection\Extension\AbstractResourceExtension;
use Sylius\Bundle\ResourceBundle\SyliusResourceBundle;
use Symfony\Component\Config\FileLocator;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Loader\XmlFileLoader;
use Symfony\Component\DependencyInjection\Parameter;

final class LakionSyliusCmsExtension extends AbstractResourceExtension
{
    /**
     * {@inheritdoc}
     */
    public function load(array $config, ContainerBuilder $container)
    {
        $config = $this->processConfiguration($this->getConfiguration($config, $container), $config);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $loader = new XmlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));

        $this->registerResources('lakion_sylius_cms', SyliusResourceBundle::DRIVER_DOCTRINE_PHPCR_ODM, $config['resources'], $container);

        $loader->load('services.xml');

        $staticContentRepository = $container->getDefinition('lakion_sylius_cms.repository.static_content');
        $staticContentRepository->addArgument(new Parameter('cmf_content.persistence.phpcr.content_basepath'));
    }
}


1			<?php
2
3			namespace Lakion\SyliusCmsBundle\DependencyInjection;
4
5			use Sylius\Bundle\ResourceBundle\DependencyInjection\Extension\AbstractResourceExtension;
6			use Sylius\Bundle\ResourceBundle\SyliusResourceBundle;
7			use Symfony\Component\Config\FileLocator;
8			use Symfony\Component\DependencyInjection\ContainerBuilder;
9			use Symfony\Component\DependencyInjection\Loader\XmlFileLoader;
10			use Symfony\Component\DependencyInjection\Parameter;
11
12			final class LakionSyliusCmsExtension extends AbstractResourceExtension
13			{
14			/**
15			* {@inheritdoc}
16			*/
17			public function load(array $config, ContainerBuilder $container)
18			{
19			$config = $this->processConfiguration($this->getConfiguration($config, $container), $config);
			0 ignored issues – show Documentation introduced 2016-12-12 20:32 UTC by Report Bug Copy Issue Report `$this->getConfiguration($config, $container)` is of type `object\|null`, but the function expects a `object<Symfony\Component...ConfigurationInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
20			$loader = new XmlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
21
22			$this->registerResources('lakion_sylius_cms', SyliusResourceBundle::DRIVER_DOCTRINE_PHPCR_ODM, $config['resources'], $container);
23
24			$loader->load('services.xml');
25
26			$staticContentRepository = $container->getDefinition('lakion_sylius_cms.repository.static_content');
27			$staticContentRepository->addArgument(new Parameter('cmf_content.persistence.phpcr.content_basepath'));
28			}
29			}
30

Lakion / SyliusCmsBundle

Pull Request — master (#1)

LakionSyliusCmsExtension::load() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like