Lakion\CmsPlugin\Fixture\Factory\StringBlockExampleFactory

Complexity

Total Complexity

2

Size/Duplication

Total Lines	54
Duplicated Lines	20.37 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	18	1
A	create()	11	11	1

<?php

namespace Lakion\CmsPlugin\Fixture\Factory;

use Lakion\CmsPlugin\Document\StringBlock;
use Sylius\Bundle\CoreBundle\Fixture\Factory\ExampleFactoryInterface;
use Sylius\Component\Core\Formatter\StringInflector;
use Sylius\Component\Resource\Factory\FactoryInterface;
use Symfony\Component\OptionsResolver\Options;
use Symfony\Component\OptionsResolver\OptionsResolver;

final class StringBlockExampleFactory implements ExampleFactoryInterface
{
    /**
     * @var FactoryInterface
     */
    private $factory;

    /**
     * @var \Faker\Generator
     */
    private $faker;

    /**
     * @var OptionsResolver
     */
    private $optionsResolver;

    /**
     * @param FactoryInterface $factory
     */
    public function __construct(FactoryInterface $factory)
    {
        $this->factory = $factory;

        $this->faker = \Faker\Factory::create();
        $this->optionsResolver =
            (new OptionsResolver())
                ->setDefault('name', function (Options $options) {

The parameter $options is not used and could be removed.

                    return StringInflector::nameToCode($this->faker->words(3, true));

It seems like $this->faker->words(3, true) targeting Faker\Generator::words() can also be of type array; however, Sylius\Component\Core\Formatter\StringInflector::nameToCode() does only seem to accept string, maybe add an additional type check?

                })
                ->setAllowedTypes('name', 'string')

                ->setDefault('body', function (Options $options) {

The parameter $options is not used and could be removed.

                    return $this->faker->sentence();
                })
                ->setAllowedTypes('body', 'string')
        ;
    }

    /**
     * {@inheritdoc}
     */
    public function create(array $options = [])

This method seems to be duplicated in your project.

    {
        $options = $this->optionsResolver->resolve($options);

        /** @var StringBlock $stringBlock */
        $stringBlock = $this->factory->createNew();
        $stringBlock->setName($options['name']);
        $stringBlock->setBody($options['body']);

        return $stringBlock;
    }
}