Completed
Push — master ( 3182b0...115a8b )
by Arkadiusz
11s
created

StringBlockExampleFactory   A

Complexity

Total Complexity 2

Size/Duplication

Total Lines 54
Duplicated Lines 20.37 %

Coupling/Cohesion

Components 1
Dependencies 6

Importance

Changes 0
Metric Value
wmc 2
c 0
b 0
f 0
lcom 1
cbo 6
dl 11
loc 54
rs 10

2 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 0 18 1
A create() 11 11 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
namespace Lakion\SyliusCmsBundle\Fixture\Factory;
4
5
use Lakion\SyliusCmsBundle\Document\StringBlock;
6
use Sylius\Bundle\CoreBundle\Fixture\Factory\ExampleFactoryInterface;
7
use Sylius\Component\Core\Formatter\StringInflector;
8
use Sylius\Component\Resource\Factory\FactoryInterface;
9
use Symfony\Component\OptionsResolver\Options;
10
use Symfony\Component\OptionsResolver\OptionsResolver;
11
12
final class StringBlockExampleFactory implements ExampleFactoryInterface
13
{
14
    /**
15
     * @var FactoryInterface
16
     */
17
    private $factory;
18
19
    /**
20
     * @var \Faker\Generator
21
     */
22
    private $faker;
23
24
    /**
25
     * @var OptionsResolver
26
     */
27
    private $optionsResolver;
28
29
    /**
30
     * @param FactoryInterface $factory
31
     */
32
    public function __construct(FactoryInterface $factory)
33
    {
34
        $this->factory = $factory;
35
36
        $this->faker = \Faker\Factory::create();
37
        $this->optionsResolver =
38
            (new OptionsResolver())
39
                ->setDefault('name', function (Options $options) {
0 ignored issues
show
Unused Code introduced by
The parameter $options is not used and could be removed.

This check looks from parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
40
                    return StringInflector::nameToCode($this->faker->words(3, true));
0 ignored issues
show
Bug introduced by
It seems like $this->faker->words(3, true) targeting Faker\Generator::words() can also be of type array; however, Sylius\Component\Core\Fo...Inflector::nameToCode() does only seem to accept string, maybe add an additional type check?

This check looks at variables that are passed out again to other methods.

If the outgoing method call has stricter type requirements than the method itself, an issue is raised.

An additional type check may prevent trouble.

Loading history...
41
                })
42
                ->setAllowedTypes('name', 'string')
43
44
                ->setDefault('body', function (Options $options) {
0 ignored issues
show
Unused Code introduced by
The parameter $options is not used and could be removed.

This check looks from parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
45
                    return $this->faker->sentence();
46
                })
47
                ->setAllowedTypes('body', 'string')
48
        ;
49
    }
50
51
    /**
52
     * {@inheritdoc}
53
     */
54 View Code Duplication
    public function create(array $options = [])
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
55
    {
56
        $options = $this->optionsResolver->resolve($options);
57
58
        /** @var StringBlock $stringBlock */
59
        $stringBlock = $this->factory->createNew();
60
        $stringBlock->setName($options['name']);
61
        $stringBlock->setBody($options['body']);
62
63
        return $stringBlock;
64
    }
65
}
66