This class seems to be duplicated in your project.
Duplicated code is one of the most pungent code smells. If you need to duplicate
the same code in three or more different places, we strongly encourage you to
look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.
Loading history...
11
{
12
/**
13
* @var RepositoryInterface
14
*/
15
private $taxonRepository;
16
17
/**
18
* @param RepositoryInterface $taxonRepository
19
*/
20
public function __construct(RepositoryInterface $taxonRepository)
21
{
22
$this->taxonRepository = $taxonRepository;
23
}
24
25
public function postLoad(LifecycleEventArgs $event)
It seems like $taxon defined by $this->taxonRepository->...Block->getTaxonCode())) on line 34 can be null; however, Lakion\CmsPlugin\Document\TaxonBlock::setTaxon() does not accept null, maybe add an additional type check?
Unless you are absolutely sure that the expression can never be null because of
other conditions, we strongly recommend to add an additional type check to your
code:
/** @return stdClass|null */functionmayReturnNull(){}functiondoesNotAcceptNull(stdClass$x){}// With potential error.functionwithoutCheck(){$x=mayReturnNull();doesNotAcceptNull($x);// Potential error here.}// Safe - Alternative 1functionwithCheck1(){$x=mayReturnNull();if(!$xinstanceofstdClass){thrownew\LogicException('$x must be defined.');}doesNotAcceptNull($x);}// Safe - Alternative 2functionwithCheck2(){$x=mayReturnNull();if($xinstanceofstdClass){doesNotAcceptNull($x);}}
Lakion /
CmsPlugin
Loading history...
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.