StringBlockExampleFactory::create() - Code Metrics - Lakion/CmsPlugin - Measure and Improve Code Quality continuously with Scrutinizer

StringBlockExampleFactory::create() A
last analyzed 2017-10-04 14:35 UTC

↳ Parent: StringBlockExampleFactory

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	6

Duplication

Lines	11
Ratio	100 %

Importance

Changes

Metric	Value
dl	11
loc	11
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	6
nc	1
nop	1

<?php

namespace Lakion\CmsPlugin\Fixture\Factory;

use Lakion\CmsPlugin\Document\StringBlock;
use Sylius\Bundle\CoreBundle\Fixture\Factory\ExampleFactoryInterface;
use Sylius\Component\Core\Formatter\StringInflector;
use Sylius\Component\Resource\Factory\FactoryInterface;
use Symfony\Component\OptionsResolver\Options;
use Symfony\Component\OptionsResolver\OptionsResolver;

final class StringBlockExampleFactory implements ExampleFactoryInterface
{
    /**
     * @var FactoryInterface
     */
    private $factory;

    /**
     * @var \Faker\Generator
     */
    private $faker;

    /**
     * @var OptionsResolver
     */
    private $optionsResolver;

    /**
     * @param FactoryInterface $factory
     */
    public function __construct(FactoryInterface $factory)
    {
        $this->factory = $factory;

        $this->faker = \Faker\Factory::create();
        $this->optionsResolver =
            (new OptionsResolver())
                ->setDefault('name', function (Options $options) {

                    return StringInflector::nameToCode($this->faker->words(3, true));

                })
                ->setAllowedTypes('name', 'string')

                ->setDefault('body', function (Options $options) {

                    return $this->faker->sentence();
                })
                ->setAllowedTypes('body', 'string')
        ;
    }

    /**
     * {@inheritdoc}
     */
    public function create(array $options = [])

    {
        $options = $this->optionsResolver->resolve($options);

        /** @var StringBlock $stringBlock */
        $stringBlock = $this->factory->createNew();
        $stringBlock->setName($options['name']);
        $stringBlock->setBody($options['body']);

        return $stringBlock;
    }
}


1		<?php
2
3		namespace Lakion\CmsPlugin\Fixture\Factory;
4
5		use Lakion\CmsPlugin\Document\StringBlock;
6		use Sylius\Bundle\CoreBundle\Fixture\Factory\ExampleFactoryInterface;
7		use Sylius\Component\Core\Formatter\StringInflector;
8		use Sylius\Component\Resource\Factory\FactoryInterface;
9		use Symfony\Component\OptionsResolver\Options;
10		use Symfony\Component\OptionsResolver\OptionsResolver;
11
12		final class StringBlockExampleFactory implements ExampleFactoryInterface
13		{
14		/**
15		* @var FactoryInterface
16		*/
17		private $factory;
18
19		/**
20		* @var \Faker\Generator
21		*/
22		private $faker;
23
24		/**
25		* @var OptionsResolver
26		*/
27		private $optionsResolver;
28
29		/**
30		* @param FactoryInterface $factory
31		*/
32		public function __construct(FactoryInterface $factory)
33		{
34		$this->factory = $factory;
35
36		$this->faker = \Faker\Factory::create();
37		$this->optionsResolver =
38		(new OptionsResolver())
39		->setDefault('name', function (Options $options) {
		0 ignored issues – show Unused Code introduced 2017-04-20 19:25 UTC by Report Bug Copy Issue Report The parameter `$options` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
40		return StringInflector::nameToCode($this->faker->words(3, true));
		0 ignored issues – show Bug introduced 2017-04-20 19:25 UTC by Report Bug Copy Issue Report It seems like `$this->faker->words(3, true)` targeting `Faker\Generator::words()` can also be of type `array`; however, `Sylius\Component\Core\Fo...Inflector::nameToCode()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
41		})
42		->setAllowedTypes('name', 'string')
43
44		->setDefault('body', function (Options $options) {
		0 ignored issues – show Unused Code introduced 2017-04-20 19:25 UTC by Report Bug Copy Issue Report The parameter `$options` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
45		return $this->faker->sentence();
46		})
47		->setAllowedTypes('body', 'string')
48		;
49		}
50
51		/**
52		* {@inheritdoc}
53		*/
54	View Code Duplication	public function create(array $options = [])
		0 ignored issues – show Duplication introduced 2017-08-23 08:41 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
55		{
56		$options = $this->optionsResolver->resolve($options);
57
58		/** @var StringBlock $stringBlock */
59		$stringBlock = $this->factory->createNew();
60		$stringBlock->setName($options['name']);
61		$stringBlock->setBody($options['body']);
62
63		return $stringBlock;
64		}
65		}
66

Lakion / CmsPlugin

StringBlockExampleFactory::create() A last analyzed 2017-10-04 14:35 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

StringBlockExampleFactory::create() A
last analyzed 2017-10-04 14:35 UTC