RouteExampleFactory::create() - Code Metrics - Lakion/CmsPlugin - Measure and Improve Code Quality continuously with Scrutinizer

RouteExampleFactory::create() A
last analyzed 2017-10-04 14:35 UTC

↳ Parent: RouteExampleFactory

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	6

Duplication

Lines	11
Ratio	100 %

Importance

Changes

Metric	Value
dl	11
loc	11
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	6
nc	1
nop	1

<?php

namespace Lakion\CmsPlugin\Fixture\Factory;

use Lakion\CmsPlugin\Document\Route;
use Lakion\CmsPlugin\Document\StaticContent;
use Sylius\Bundle\CoreBundle\Fixture\Factory\ExampleFactoryInterface;
use Sylius\Bundle\CoreBundle\Fixture\OptionsResolver\LazyOption;
use Sylius\Component\Core\Formatter\StringInflector;
use Sylius\Component\Resource\Factory\FactoryInterface;
use Sylius\Component\Resource\Repository\RepositoryInterface;
use Symfony\Component\OptionsResolver\Options;
use Symfony\Component\OptionsResolver\OptionsResolver;

final class RouteExampleFactory implements ExampleFactoryInterface
{
    /**
     * @var FactoryInterface
     */
    private $routeFactory;

    /**
     * @var \Faker\Generator
     */
    private $faker;

    /**
     * @var OptionsResolver
     */
    private $optionsResolver;

    /**
     * @param FactoryInterface $routeFactory
     * @param RepositoryInterface $staticContentRepository
     */
    public function __construct(FactoryInterface $routeFactory, RepositoryInterface $staticContentRepository)
    {
        $this->routeFactory = $routeFactory;

        $this->faker = \Faker\Factory::create();
        $this->optionsResolver =
            (new OptionsResolver())
                ->setDefault('name', function (Options $options) {

                    return StringInflector::nameToCode($this->faker->words(3, true));

                })
                ->setAllowedTypes('name', 'string')

                ->setDefault('content', LazyOption::randomOne($staticContentRepository))
                ->setAllowedTypes('content', ['string', StaticContent::class])
                ->setNormalizer('content', LazyOption::findOneBy($staticContentRepository, 'name'))
        ;
    }

    /**
     * {@inheritdoc}
     */
    public function create(array $options = [])

    {
        $options = $this->optionsResolver->resolve($options);

        /** @var Route $route */
        $route = $this->routeFactory->createNew();
        $route->setName($options['name']);
        $route->setContent($options['content']);

        return $route;
    }
}


1		<?php
2
3		namespace Lakion\CmsPlugin\Fixture\Factory;
4
5		use Lakion\CmsPlugin\Document\Route;
6		use Lakion\CmsPlugin\Document\StaticContent;
7		use Sylius\Bundle\CoreBundle\Fixture\Factory\ExampleFactoryInterface;
8		use Sylius\Bundle\CoreBundle\Fixture\OptionsResolver\LazyOption;
9		use Sylius\Component\Core\Formatter\StringInflector;
10		use Sylius\Component\Resource\Factory\FactoryInterface;
11		use Sylius\Component\Resource\Repository\RepositoryInterface;
12		use Symfony\Component\OptionsResolver\Options;
13		use Symfony\Component\OptionsResolver\OptionsResolver;
14
15		final class RouteExampleFactory implements ExampleFactoryInterface
16		{
17		/**
18		* @var FactoryInterface
19		*/
20		private $routeFactory;
21
22		/**
23		* @var \Faker\Generator
24		*/
25		private $faker;
26
27		/**
28		* @var OptionsResolver
29		*/
30		private $optionsResolver;
31
32		/**
33		* @param FactoryInterface $routeFactory
34		* @param RepositoryInterface $staticContentRepository
35		*/
36		public function __construct(FactoryInterface $routeFactory, RepositoryInterface $staticContentRepository)
37		{
38		$this->routeFactory = $routeFactory;
39
40		$this->faker = \Faker\Factory::create();
41		$this->optionsResolver =
42		(new OptionsResolver())
43		->setDefault('name', function (Options $options) {
		0 ignored issues – show Unused Code introduced 2017-04-20 19:25 UTC by Report Bug Copy Issue Report The parameter `$options` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
44		return StringInflector::nameToCode($this->faker->words(3, true));
		0 ignored issues – show Bug introduced 2017-04-20 19:25 UTC by Report Bug Copy Issue Report It seems like `$this->faker->words(3, true)` targeting `Faker\Generator::words()` can also be of type `array`; however, `Sylius\Component\Core\Fo...Inflector::nameToCode()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
45		})
46		->setAllowedTypes('name', 'string')
47
48		->setDefault('content', LazyOption::randomOne($staticContentRepository))
49		->setAllowedTypes('content', ['string', StaticContent::class])
50		->setNormalizer('content', LazyOption::findOneBy($staticContentRepository, 'name'))
51		;
52		}
53
54		/**
55		* {@inheritdoc}
56		*/
57	View Code Duplication	public function create(array $options = [])
		0 ignored issues – show Duplication introduced 2017-08-23 08:41 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
58		{
59		$options = $this->optionsResolver->resolve($options);
60
61		/** @var Route $route */
62		$route = $this->routeFactory->createNew();
63		$route->setName($options['name']);
64		$route->setContent($options['content']);
65
66		return $route;
67		}
68		}
69

Lakion / CmsPlugin

RouteExampleFactory::create() A last analyzed 2017-10-04 14:35 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

RouteExampleFactory::create() A
last analyzed 2017-10-04 14:35 UTC