net.labymod.serverapi.Addon - Code Metrics - Inspection of "Remove clutter code and add error handling" - LabyMod/labymod-server-api - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#3)

unknown

created 2019-03-09 17:40 UTC

net.labymod.serverapi.Addon A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	34
Duplicated Lines	61.76 %

Importance

Changes	4
Bugs	0	Features	0

Metric	Value
wmc	11
eloc	18
c	4
b	0
f	0
dl	21
loc	34
rs	10

1 Method

Rating	Name	Duplication	Size	Complexity
C	getAddons(JsonObject)	21	21	11

How to fix Duplicated Code

package net.labymod.serverapi;

import com.google.gson.JsonElement;
import com.google.gson.JsonObject;
import lombok.AllArgsConstructor;
import lombok.Getter;

import java.util.ArrayList;
import java.util.Collections;
import java.util.List;
import java.util.UUID;

/**
 * An Addon represents a player's addon
 * The addons are being sent when a user joins the server
 * You can retrieve them by using LabyModPlayerJoinEvent#getAddons()
 *
 * @author Jan
 */
@AllArgsConstructor
@Getter
public class Addon {

    private UUID uuid;
    private String name;

    /**
     * Parses the addons from the INFO plugin message
     *
     * @param jsonObject the json object of the message
     * @return a list containing the message's addons
     */
    @Deprecated

    public static List<Addon> getAddons( JsonObject jsonObject ) {
        if ( !jsonObject.has( "addons" ) || !jsonObject.get( "addons" ).isJsonArray() )
            return Collections.emptyList();

        List<Addon> addons = new ArrayList<>();

        for ( JsonElement arrayElement : jsonObject.get( "addons" ).getAsJsonArray() ) {
            if ( !arrayElement.isJsonObject() )
                continue;

            JsonObject arrayObject = arrayElement.getAsJsonObject();

            if ( !arrayObject.has( "uuid" ) || !arrayObject.get( "uuid" ).isJsonPrimitive() || !arrayObject.get( "uuid" ).getAsJsonPrimitive().isString()
                    || !arrayObject.has( "name" ) || !arrayObject.get( "name" ).isJsonPrimitive() || !arrayObject.get( "name" ).getAsJsonPrimitive().isString() )
            continue;

            addons.add( new Addon( UUID.fromString( arrayObject.get( "uuid" ).getAsString() ), arrayObject.get( "name" ).getAsString() ) );

        }

        return addons;
    }

}


1		package net.labymod.serverapi;
2
3		import com.google.gson.JsonElement;
4		import com.google.gson.JsonObject;
5		import lombok.AllArgsConstructor;
6		import lombok.Getter;
7
8		import java.util.ArrayList;
9		import java.util.Collections;
10		import java.util.List;
11		import java.util.UUID;
12
13		/**
14		* An Addon represents a player's addon
15		* The addons are being sent when a user joins the server
16		* You can retrieve them by using LabyModPlayerJoinEvent#getAddons()
17		*
18		* @author Jan
19		*/
20		@AllArgsConstructor
21		@Getter
22		public class Addon {
23
24		private UUID uuid;
25		private String name;
26
27		/**
28		* Parses the addons from the INFO plugin message
29		*
30		* @param jsonObject the json object of the message
31		* @return a list containing the message's addons
32		*/
33	View Code Duplication	@Deprecated
		0 ignored issues – show Duplication introduced 2019-03-09 17:43 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Loading history...
34		public static List<Addon> getAddons( JsonObject jsonObject ) {
35		if ( !jsonObject.has( "addons" ) \|\| !jsonObject.get( "addons" ).isJsonArray() )
36		return Collections.emptyList();
37
38		List<Addon> addons = new ArrayList<>();
39
40		for ( JsonElement arrayElement : jsonObject.get( "addons" ).getAsJsonArray() ) {
41		if ( !arrayElement.isJsonObject() )
42		continue;
43
44		JsonObject arrayObject = arrayElement.getAsJsonObject();
45
46		if ( !arrayObject.has( "uuid" ) \|\| !arrayObject.get( "uuid" ).isJsonPrimitive() \|\| !arrayObject.get( "uuid" ).getAsJsonPrimitive().isString()
47		\|\| !arrayObject.has( "name" ) \|\| !arrayObject.get( "name" ).isJsonPrimitive() \|\| !arrayObject.get( "name" ).getAsJsonPrimitive().isString() )
48		continue;
49
50		addons.add( new Addon( UUID.fromString( arrayObject.get( "uuid" ).getAsString() ), arrayObject.get( "name" ).getAsString() ) );
		0 ignored issues – show Bug introduced 2019-03-09 17:43 UTC by Report Bug Copy Issue Report This line will not be executed conditionally; only the first line of this 3-line block will be. The rest will execute unconditionally. Even if your block only consists of one line right now, it is good practice to enclose it in curly braces. It makes your code much more readable. Loading history...
51		}
52
53		return addons;
54		}
55
56		}
57

LabyMod / labymod-server-api

Pull Request — master (#3)

net.labymod.serverapi.Addon A

Complexity

Size/Duplication

Importance

1 Method

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like