CaaRecord::validate() - Code Metrics - Inspection of "add CAA record" - LTD-Beget/dns-zone-configurator - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#26)

unknown

created 2018-11-12 16:39 UTC

CaaRecord::validate() B

↳ Parent: CaaRecord

Complexity

Conditions	11
Paths	72

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	37
rs	7.3166
c	0
b	0
f	0
cc	11
nc	72
nop	0

How to fix Complexity

<?php

namespace LTDBeget\dns\configurator\zoneEntities\record;

use LTDBeget\dns\configurator\errors\ValidationError;
use LTDBeget\dns\configurator\validators\Int16Validator;
use LTDBeget\dns\configurator\zoneEntities\Node;
use LTDBeget\dns\configurator\zoneEntities\record\base\Record;
use LTDBeget\dns\enums\eErrorCode;
use LTDBeget\dns\enums\eRecordType;

/**
 * Class CaaRecord
 *
 * @package LTDBeget\dns\configurator\zoneEntities\record
 */
class CaaRecord extends Record
{
    /** @var string explicity authorizes a single certificate authority to issue a certificate (any type) for the hostname */
    const TAG_ISSUE = 'issue';
    /** @var string explicity authorizes a single certificate authority to issue a wildcard certificate (and only wildcard) for the hostname */
    const TAG_ISSUEWILD = 'issuewild';
    /** @var string specifies a URL to which a certificate authority may report policy violations */
    const TAG_IODEF = 'iodef';
    /** @var string  проверка по FQDN */
    const PATTERN_FQDN = '/^([a-zа-яё0-9\_]([a-zа-яё0-9\-]{0,61}[a-zа-яё0-9])?\.)*([a-zа-яё0-9]([a-zа-яё0-9\-]{0,61}[a-zа-яё0-9])?\.)+[a-zа-яё0-9-]{2,30}$/i';

    /**
     * @var Int
     */
    protected $flags;
    /**
     * @var String
     */
    protected $tag;
    /**
     * @var String
     */
    protected $value;

    /**
     * CaaRecord constructor.
     *
     * @param Node   $node
     * @param        $ttl
     * @param int    $flags
     * @param string $tag
     * @param string $value
     */
    public function __construct(Node $node, $ttl, int $flags, string $tag, string $value)
    {
        $this->flags = $flags;
        $this->tag   = $tag;
        $this->value = $this->getFromQuotes($value);
        parent::__construct($node, eRecordType::CAA(), $ttl);
    }

    /**
     * @param $value
     *
     * @return string
     */
    private function getFromQuotes(string $value)
    {
        return str_replace(["\n", '"'], "", $value);
    }

    /**
     * @return string
     */
    public function __toString(): string
    {
        return $this->getMainRecordPart() . " {$this->getFlags()} {$this->getTag()} \"{$this->getValue()}\"";
    }

    /**
     * @return Int
     */
    public function getFlags(): Int
    {
        return $this->flags;
    }

    /**
     * @param Int $flags
     *
     * @return CaaRecord
     */
    public function setFlags(Int $flags): CaaRecord
    {
        return $this->setAttribute('flags', $flags);
    }

    /**
     * @return String
     */
    public function getTag(): String
    {
        return $this->tag;
    }

    /**
     * @param String $tag
     *
     * @return CaaRecord
     */
    public function setTag(String $tag): CaaRecord
    {
        return $this->setAttribute('tag', $tag);
    }

    /**
     * @return String
     */
    public function getValue(): String
    {
        return $this->value;
    }

    /**
     * @param String $value
     *
     * @return CaaRecord
     */
    public function setValue(String $value): CaaRecord
    {
        return $this->setAttribute('value', $value);
    }

    /**
     * @internal
     * @return bool
     */
    public function validate(): bool
    {
        $errorStorage = $this->getNode()->getZone()->getErrorsStore();

        \Yii::error($this->getTag(), 'check');

        if (!in_array($this->tag, [self::TAG_ISSUE, self::TAG_ISSUEWILD, self::TAG_IODEF])) {
            $errorStorage->add(ValidationError::makeRecordError($this, eErrorCode::WRONG_CAA_TAG(), 'tag'));
        }

        if ($this->flags < 0 || $this->flags > 128) {
            $errorStorage->add(ValidationError::makeRecordError($this, eErrorCode::WRONG_CAA_FLAG(), 'flag'));

        }

        if (!Int16Validator::validate($this->getFlags())) {
            $errorStorage->add(ValidationError::makeRecordError($this, eErrorCode::WRONG_INT16(), 'flags'));
        }

        if (in_array($this->getTag(), [self::TAG_ISSUEWILD, self::TAG_ISSUE]) &&
            $this->getValue() !== ';'
        ) {
            $parts = explode(";", $this->getValue());

            if (!preg_match(self::PATTERN_FQDN, $parts[0])) {
                $errorStorage->add(ValidationError::makeRecordError($this, eErrorCode::WRONG_CAA_VALUE(), 'value'));
            }
        }

        if ($this->getTag() == self::TAG_IODEF) {
            if (!filter_var($this->getValue(), FILTER_VALIDATE_EMAIL) && !filter_var($this->getValue(), FILTER_VALIDATE_URL)) {
                $errorStorage->add(ValidationError::makeRecordError($this, eErrorCode::WRONG_CAA_VALUE(), 'value'));
            }
        }

        /** @noinspection PhpInternalEntityUsedInspection */
        return parent::validate();
    }

    /**
     * @return array
     */
    protected function recordDataToArray(): array
    {
        return [
            'FLAGS' => $this->getFlags(),
            'TAG'   => $this->getTag(),
            'VALUE' => $this->getValue()
        ];
    }
}

1			<?php
2
3			namespace LTDBeget\dns\configurator\zoneEntities\record;
4
5			use LTDBeget\dns\configurator\errors\ValidationError;
6			use LTDBeget\dns\configurator\validators\Int16Validator;
7			use LTDBeget\dns\configurator\zoneEntities\Node;
8			use LTDBeget\dns\configurator\zoneEntities\record\base\Record;
9			use LTDBeget\dns\enums\eErrorCode;
10			use LTDBeget\dns\enums\eRecordType;
11
12			/**
13			* Class CaaRecord
14			*
15			* @package LTDBeget\dns\configurator\zoneEntities\record
16			*/
17			class CaaRecord extends Record
18			{
19			/** @var string explicity authorizes a single certificate authority to issue a certificate (any type) for the hostname */
20			const TAG_ISSUE = 'issue';
21			/** @var string explicity authorizes a single certificate authority to issue a wildcard certificate (and only wildcard) for the hostname */
22			const TAG_ISSUEWILD = 'issuewild';
23			/** @var string specifies a URL to which a certificate authority may report policy violations */
24			const TAG_IODEF = 'iodef';
25			/** @var string проверка по FQDN */
26			const PATTERN_FQDN = '/^([a-zа-яё0-9\_]([a-zа-яё0-9\-]{0,61}[a-zа-яё0-9])?\.)*([a-zа-яё0-9]([a-zа-яё0-9\-]{0,61}[a-zа-яё0-9])?\.)+[a-zа-яё0-9-]{2,30}$/i';
27
28			/**
29			* @var Int
30			*/
31			protected $flags;
32			/**
33			* @var String
34			*/
35			protected $tag;
36			/**
37			* @var String
38			*/
39			protected $value;
40
41			/**
42			* CaaRecord constructor.
43			*
44			* @param Node $node
45			* @param $ttl
46			* @param int $flags
47			* @param string $tag
48			* @param string $value
49			*/
50			public function __construct(Node $node, $ttl, int $flags, string $tag, string $value)
51			{
52			$this->flags = $flags;
53			$this->tag = $tag;
54			$this->value = $this->getFromQuotes($value);
55			parent::__construct($node, eRecordType::CAA(), $ttl);
56			}
57
58			/**
59			* @param $value
60			*
61			* @return string
62			*/
63			private function getFromQuotes(string $value)
64			{
65			return str_replace(["\n", '"'], "", $value);
66			}
67
68			/**
69			* @return string
70			*/
71			public function __toString(): string
72			{
73			return $this->getMainRecordPart() . " {$this->getFlags()} {$this->getTag()} \"{$this->getValue()}\"";
74			}
75
76			/**
77			* @return Int
78			*/
79			public function getFlags(): Int
80			{
81			return $this->flags;
82			}
83
84			/**
85			* @param Int $flags
86			*
87			* @return CaaRecord
88			*/
89			public function setFlags(Int $flags): CaaRecord
90			{
91			return $this->setAttribute('flags', $flags);
92			}
93
94			/**
95			* @return String
96			*/
97			public function getTag(): String
98			{
99			return $this->tag;
100			}
101
102			/**
103			* @param String $tag
104			*
105			* @return CaaRecord
106			*/
107			public function setTag(String $tag): CaaRecord
108			{
109			return $this->setAttribute('tag', $tag);
110			}
111
112			/**
113			* @return String
114			*/
115			public function getValue(): String
116			{
117			return $this->value;
118			}
119
120			/**
121			* @param String $value
122			*
123			* @return CaaRecord
124			*/
125			public function setValue(String $value): CaaRecord
126			{
127			return $this->setAttribute('value', $value);
128			}
129
130			/**
131			* @internal
132			* @return bool
133			*/
134			public function validate(): bool
135			{
136			$errorStorage = $this->getNode()->getZone()->getErrorsStore();
137
138			\Yii::error($this->getTag(), 'check');
139
140			if (!in_array($this->tag, [self::TAG_ISSUE, self::TAG_ISSUEWILD, self::TAG_IODEF])) {
141			$errorStorage->add(ValidationError::makeRecordError($this, eErrorCode::WRONG_CAA_TAG(), 'tag'));
142			}
143
144			if ($this->flags < 0 \|\| $this->flags > 128) {
145			$errorStorage->add(ValidationError::makeRecordError($this, eErrorCode::WRONG_CAA_FLAG(), 'flag'));
			0 ignored issues – show Bug introduced 2018-11-12 16:44 UTC by Report Bug Copy Issue Report The method `WRONG_CAA_FLAG()` does not exist on `LTDBeget\dns\enums\eErrorCode`. Did you maybe mean `WRONG_CAA_FLAGS()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
146			}
147
148			if (!Int16Validator::validate($this->getFlags())) {
149			$errorStorage->add(ValidationError::makeRecordError($this, eErrorCode::WRONG_INT16(), 'flags'));
150			}
151
152			if (in_array($this->getTag(), [self::TAG_ISSUEWILD, self::TAG_ISSUE]) &&
153			$this->getValue() !== ';'
154			) {
155			$parts = explode(";", $this->getValue());
156
157			if (!preg_match(self::PATTERN_FQDN, $parts[0])) {
158			$errorStorage->add(ValidationError::makeRecordError($this, eErrorCode::WRONG_CAA_VALUE(), 'value'));
159			}
160			}
161
162			if ($this->getTag() == self::TAG_IODEF) {
163			if (!filter_var($this->getValue(), FILTER_VALIDATE_EMAIL) && !filter_var($this->getValue(), FILTER_VALIDATE_URL)) {
164			$errorStorage->add(ValidationError::makeRecordError($this, eErrorCode::WRONG_CAA_VALUE(), 'value'));
165			}
166			}
167
168			/** @noinspection PhpInternalEntityUsedInspection */
169			return parent::validate();
170			}
171
172			/**
173			* @return array
174			*/
175			protected function recordDataToArray(): array
176			{
177			return [
178			'FLAGS' => $this->getFlags(),
179			'TAG' => $this->getTag(),
180			'VALUE' => $this->getValue()
181			];
182			}
183			}

LTD-Beget / dns-zone-configurator

Pull Request — master (#26)

CaaRecord::validate() B

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like