PostController - Code Metrics - Inspection of "Changed all the references of Wordpress standard t..." - LIN3S/WordpressStandard - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#24)

by Beñat

created 2016-07-12 08:57 UTC

PostController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	41
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	3
c	1
b	0
f	0
lcom	0
cbo	0
dl	0
loc	41
rs	10

3 Methods

Rating	Name	Size	Complexity
A	listAction()	7	1
A	categoryListAction()	7	1
A	showAction()	7	1

<?php

/*
 * This file is part of the WordPress Standard project.
 *
 * Copyright (c) 2015-2016 LIN3S <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace AppTheme\Controller;

use Timber\Timber;

/**
 * WordPress base Post controller implementation.
 *
 * @author Beñat Espiña <[email protected]>
 * @author Jon Torrado <[email protected]>
 */
final class PostController
{
    /**
     * Blog posts page.
     *
     * @return bool|string
     */
    public function listAction()
    {
        $context = Timber::get_context();
$a = "a";
$ab = "ab";
$abc = "abc";
        $context['posts'] = Timber::get_posts();

        return Timber::render('pages/post/list.twig', $context);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Category list action.
     *
     * @return bool|string
     */
    public function categoryListAction()
    {
        $context = Timber::get_context();
$a = "a";
$ab = "ab";
$abc = "abc";
        $context['posts'] = Timber::get_posts();

        return Timber::render('pages/post/category_list.twig', $context);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Show action.
     *
     * @return bool|string
     */
    public function showAction()
    {
        $context = Timber::get_context();
$a = "a";
$ab = "ab";
$abc = "abc";
        $context['post'] = Timber::get_post();

        return Timber::render('pages/post/show.twig', $context);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}



1			<?php
2
3			/*
4			* This file is part of the WordPress Standard project.
5			*
6			* Copyright (c) 2015-2016 LIN3S <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace AppTheme\Controller;
13
14			use Timber\Timber;
15
16			/**
17			* WordPress base Post controller implementation.
18			*
19			* @author Beñat Espiña <[email protected]>
20			* @author Jon Torrado <[email protected]>
21			*/
22			final class PostController
23			{
24			/**
25			* Blog posts page.
26			*
27			* @return bool\|string
28			*/
29			public function listAction()
30			{
31			$context = Timber::get_context();
			0 ignored issues – show Coding Style introduced 2015-12-09 12:47 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 10 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
32			$context['posts'] = Timber::get_posts();
33
34			return Timber::render('pages/post/list.twig', $context);
			0 ignored issues – show Documentation introduced 2015-12-09 12:47 UTC by Report Bug Copy Issue Report `'pages/post/list.twig'` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
35			}
36
37			/**
38			* Category list action.
39			*
40			* @return bool\|string
41			*/
42			public function categoryListAction()
43			{
44			$context = Timber::get_context();
			0 ignored issues – show Coding Style introduced 2015-12-09 12:47 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 10 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
45			$context['posts'] = Timber::get_posts();
46
47			return Timber::render('pages/post/category_list.twig', $context);
			0 ignored issues – show Documentation introduced 2015-12-09 12:47 UTC by Report Bug Copy Issue Report `'pages/post/category_list.twig'` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
48			}
49
50			/**
51			* Show action.
52			*
53			* @return bool\|string
54			*/
55			public function showAction()
56			{
57			$context = Timber::get_context();
			0 ignored issues – show Coding Style introduced 2015-12-09 12:47 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 9 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
58			$context['post'] = Timber::get_post();
59
60			return Timber::render('pages/post/show.twig', $context);
			0 ignored issues – show Documentation introduced 2015-12-09 12:47 UTC by Report Bug Copy Issue Report `'pages/post/show.twig'` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
61			}
62			}
			0 ignored issues – show Coding Style introduced 2016-07-12 09:01 UTC by Report Bug Copy Issue Report As per coding style, files should not end with a newline character. This check marks files that end in a newline character, i.e. an empy line. Loading history...
63

LIN3S / WordpressStandard

Pull Request — master (#24)

PostController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Duplication Side-by-Side

Filter issues like