LIN3S\WPSymfonyForm\Admin\Admin

Complexity

Total Complexity

6

Size/Duplication

Total Lines	183
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	2
Bugs	0	Features	1

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	10	1
B	menu()	0	46	2
A	generalPageScreenOptions()	0	14	1
A	generalPage()	0	22	1
A	logArchivePage()	0	22	1

<?php

namespace LIN3S\WPSymfonyForm\Admin;

use LIN3S\WPSymfonyForm\Admin\Storage\InMemoryStorage;
use LIN3S\WPSymfonyForm\Admin\Storage\YamlStorage;
use LIN3S\WPSymfonyForm\Admin\Views\FormsTable;
use LIN3S\WPSymfonyForm\Admin\Views\LogsTable;
use LIN3S\WPSymfonyForm\Registry\FormWrapperRegistry;

/**
 * Main admin class.
 *
 * @author Beñat Espiña <benatespina@gmail.com>
 */
class Admin
{
    /**
     * The forms table.
     *
     * @var FormsTable
     */
    private $formsTable;

    /**
     * The logs table.
     *
     * @var LogsTable
     */
    public $logsTable;

    /**
     * The form wrapper registry.
     *
     * @var FormWrapperRegistry
     */
    private $formWrapperRegistry;

    /**
     * Array which contains the forms.
     *
     * @var array
     */
    private $forms;

    /**
     * Constructor.
     *
     * @param FormWrapperRegistry $formWrapperRegistry The form wrapper registry
     */
    public function __construct(FormWrapperRegistry $formWrapperRegistry)
    {
        $this->formWrapperRegistry = $formWrapperRegistry;
        $this->forms = [];
        add_filter('set-screen-option', function ($status, $option, $value) {

The call to the function add_filter() seems unnecessary as the function has no side-effects.

            return $value;
        }, 10, 3);

The call to add_filter() has too many arguments starting with 10.

        add_action('admin_menu', [$this, 'menu']);

The call to the function add_action() seems unnecessary as the function has no side-effects.

    }

    /**
     * Loads the menu inside WordPress admin sidebar.
     */
    public function menu()
    {
        $menu = add_menu_page(
            'Symfony Forms',
            'Symfony Forms',
            'manage_options',
            'symfony-form',
            [$this, 'generalPage']
        );
        add_action("load-$menu", [$this, 'generalPageScreenOptions']);

The call to the function add_action() seems unnecessary as the function has no side-effects.

        foreach ($this->formWrapperRegistry->get() as $key => $formWrapper) {

The expression $this->formWrapperRegistry->get() of type array<integer,object<LIN3S\WPSymfonyForm\Wrapper\FormWrapper>>|object<LIN3S\WPSymfonyForm\Wrapper\FormWrapper> is not guaranteed to be traversable. How about adding an additional type check?

            $name = ucfirst($formWrapper->getName());
            $slug = 'wp-symfony-form-' . preg_replace('/\s+/', '', strtolower($formWrapper->getName()));

            $subMenu = add_submenu_page(

$subMenu is not used, you could remove the assignment.

                'symfony-form',
                $name,
                $name,
                'manage_options',
                $slug,
                [$this, 'logArchivePage']
            );

            $this->forms[] = [
                'name' => $name,
                'link' => '<a href="?page=' . $slug . '">/wp-admin/admin.php?page=' . $slug . '</a>',
            ];

//            do_action('wp-symfony-form-load-'. $subMenu, ['name' => $name]);

62% of this comment could be valid code. Did you maybe forget this after debugging?

//            add_action('wp-symfony-form-load-'. $subMenu, [$this, 'logArchivePageScreenOptions']);

//            add_action('wp-symfony-form-load-' . $subMenu, function () use ($name) {

49% of this comment could be valid code. Did you maybe forget this after debugging?

//                add_screen_option('per_page', [
//                    'label'   => 'Logs',
//                    'default' => 10,
//                    'option'  => 'logs_per_page',
//                ]);
//
//                $this->logsTable = new LogsTable(
//                    $name,
//                    new YamlStorage()
//                );
//            });
        }
    }

    /**
     * Adds main form archive page screen options.
     */
    public function generalPageScreenOptions()
    {
        add_screen_option('per_page', [
            'label'   => 'Forms',
            'default' => 10,
            'option'  => 'forms_per_page',
        ]);

        $this->formsTable = new FormsTable(
            new InMemoryStorage(
                $this->forms
            )
        );
    }

//    /**
//     * Adds email log archive page screen options.
//     */
//    public function logArchivePageScreenOptions()
//    {
//        add_screen_option('per_page', [
//            'label'   => 'Logs',
//            'default' => 10,
//            'option'  => 'logs_per_page',
//        ]);
//
//        $this->logsTable = new LogsTable(
//            $
//            new YamlStorage()
//        );
//    }

    /**
     * Renders main form archive page.
     */
    public function generalPage()
    {
        ?>
        <div class="wrap">
            <h2><?php _e('General', \WPSymfonyForm::TRANSLATION_DOMAIN); ?></h2>
            <div id="poststuff">
                <div id="post-body" class="metabox-holder">
                    <div id="post-body-content">
                        <div class="meta-box-sortables ui-sortable">
                            <form method="post">
                                <?php
                                $this->formsTable->prepare_items();
                                $this->formsTable->display(); ?>
                            </form>
                        </div>
                    </div>
                </div>
                <br class="clear">
            </div>
        </div>
        <?php
    }

    /**
     * Renders log archive page.
     */
    public function logArchivePage()
    {
        ?>
        <div class="wrap">
            <h2><?php _e('Sent emails logs', \WPSymfonyForm::TRANSLATION_DOMAIN); ?></h2>
            <div id="poststuff">
                <div id="post-body" class="metabox-holder">
                    <div id="post-body-content">
                        <div class="meta-box-sortables ui-sortable">
                            <form method="post">
                                <?php
                                $this->logsTable->prepare_items();
                                $this->logsTable->display(); ?>
                            </form>
                        </div>
                    </div>
                </div>
                <br class="clear">
            </div>
        </div>
        <?php
    }
}