LIN3S\WPSymfonyForm\Admin\Storage\YamlStorage

Complexity

Total Complexity

19

Size/Duplication

Total Lines	121
Duplicated Lines	40.5 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	3
Bugs	0	Features	1

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	10	3
A	findAll()	13	13	3
B	query()	18	18	5
A	properties()	0	4	2
A	size()	0	4	1
A	paginate()	0	4	1
A	sort()	18	18	4

<?php

/*
 * This file is part of the WPSymfonyForm plugin.
 *
 * Copyright (c) 2015-2016 LIN3S <info@lin3s.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace LIN3S\WPSymfonyForm\Admin\Storage;

use Symfony\Component\Yaml\Yaml;

/**
 * YAML strategy of storage.
 *
 * @author Beñat Espiña <benatespina@gmail.com>
 */
class YamlStorage implements Storage
{
    /**
     * The data collection.
     *
     * @var array
     */
    private $data;

    /**
     * Constructor.
     *
     * @param string $yamlFile The dir path of YAML file

Should the type for parameter $yamlFile not be string|null?

     */
    public function __construct($yamlFile = null)
    {
        if (null === $yamlFile) {
            $yamlFile = __DIR__ . '/../../../../../../../../wp_symfony_form_email_log.yml';

Consider using a different name than the parameter $yamlFile. This often makes code more readable.

        }
        $this->data = Yaml::parse(file_get_contents($yamlFile));

It seems like \Symfony\Component\Yaml\Yaml::parse(file_get_contents($yamlFile)) can also be of type string or object<stdClass>. However, the property $data is declared as type array. Maybe add an additional type check?

        if (null === $this->data) {
            $this->data = [];
        }
    }

    /**
     * {@inheritdoc}
     */
    public function findAll($limit, $offset)

This method seems to be duplicated in your project.

    {
        $data = $this->data;
        foreach ($data as $key => $item) {
            if (array_key_exists('ID', $item)) {
                continue;
            }
            $data[$key]['ID'] = $key;
        }
        usort($data, [$this, 'sort']);

        return $this->paginate($data, $limit, $offset);
    }

    /**
     * {@inheritdoc}
     */
    public function query(array $criteria, $limit, $offset)

This method seems to be duplicated in your project.

    {
        $data = [];
        foreach ($this->data as $key => $item) {
            foreach ($criteria as $name => $singleCriteria) {
                if ($item[$name] === $singleCriteria) {
                    $data[$key] = $item;
                }
            }
            if (array_key_exists('ID', $item)) {
                continue;
            }
            $data[$key]['ID'] = $key;
        }
        usort($data, [$this, 'sort']);

        return $this->paginate($data, $limit, $offset);
    }

    /**
     * {@inheritdoc}
     */
    public function properties()
    {
        return isset($this->data[0]) ? array_keys($this->data[0]) : null;
    }

    /**
     * {@inheritdoc}
     */
    public function size()
    {
        return count($this->data);
    }

    /**
     * Paginates the given collection of data.
     *
     * @param array $data   The collection data
     * @param int   $limit  Logs per page
     * @param int   $offset The number of the page
     *
     * @return array
     */
    private function paginate($data, $limit, $offset)
    {
        return array_slice($data, (($offset - 1) * $limit), $limit);
    }

    /**
     * Compares the given two items.
     *
     * @param mixed $item1 The first item
     * @param mixed $item2 The second item
     *
     * @return int
     */
    private function sort($item1, $item2)

This method seems to be duplicated in your project.

sort uses the super-global variable $_GET which is generally not recommended.

    {
        $orderBy = 'name';
        $order = 'asc';

        if (!empty($_GET['orderby'])) {
            $orderBy = $_GET['orderby'];
        }
        if (!empty($_GET['order'])) {
            $order = $_GET['order'];
        }
        $result = strcmp($item1[$orderBy], $item2[$orderBy]);
        if ('asc' === $order) {
            return $result;
        }

        return -$result;
    }
}