Theme::xmlrpc() - Code Metrics - Inspection of "Added xmlrpc disabling feature" - LIN3S/WPFoundation - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f5cd5b...d3cd2b )

unknown

created 2016-06-01 07:13 UTC

Theme::xmlrpc() A

↳ Parent: Theme

Complexity

Conditions	3
Paths	4

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	7
rs	9.4285
cc	3
eloc	5
nc	4
nop	0

<?php

/*
 * This file is part of the WPFoundation library.
 *
 * Copyright (c) 2015-2016 LIN3S <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace LIN3S\WPFoundation\Configuration\Theme;

use LIN3S\WPFoundation\Configuration\Acf\Wysiwyg;

/**
 * Abstract class of theme that implements the interface.
 * This class avoids the use of callbacks in the constructor.
 *
 * @author Beñat Espiña <[email protected]>
 */
abstract class Theme implements ThemeInterface
{
    /**
     * Constructor.
     */
    public function __construct()
    {
        $this->acf();
        $this->classes();
        $this->templateSelector();
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
        $this->xmlrpc();
        add_theme_support('post-thumbnails');

        add_filter('timber_context', [$this, 'context']);

    }

    /**
     * All about ACF configuration should be instantiated here.
     */
    protected function acf()
    {
        new Wysiwyg([
            'lin3s' => [1 => ['bold', 'italic', 'bullist', 'numlist', 'link', 'unlink']],
        ]);
    }

    /**
     * Filters the selectable templates.
     */
    private function templateSelector()
    {
        $self = $this;
        add_filter('theme_page_templates', function () use ($self) {

            return $self->templates([]);
        });
    }

    /**
     * Enables or disables XML-RPC feature.
     */
    private function xmlrpc()
    {
        $xmlrpc = !defined('XMLRPC_ENABLED') || XMLRPC_ENABLED === true
            ? '__return_true'
            : '__return_false';
        add_filter('xmlrpc_enabled', $xmlrpc);

    }
}


1			<?php
2
3			/*
4			* This file is part of the WPFoundation library.
5			*
6			* Copyright (c) 2015-2016 LIN3S <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace LIN3S\WPFoundation\Configuration\Theme;
13
14			use LIN3S\WPFoundation\Configuration\Acf\Wysiwyg;
15
16			/**
17			* Abstract class of theme that implements the interface.
18			* This class avoids the use of callbacks in the constructor.
19			*
20			* @author Beñat Espiña <[email protected]>
21			*/
22			abstract class Theme implements ThemeInterface
23			{
24			/**
25			* Constructor.
26			*/
27			public function __construct()
28			{
29			$this->acf();
30			$this->classes();
31			$this->templateSelector();
			0 ignored issues – show Unused Code introduced 2016-05-20 08:48 UTC by Report Bug Copy Issue Report The call to the method `LIN3S\WPFoundation\Confi...eme::templateSelector()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
32			$this->xmlrpc();
33			add_theme_support('post-thumbnails');
			0 ignored issues – show Unused Code introduced 2015-11-21 16:59 UTC by Report Bug Copy Issue Report The call to the function `add_theme_support()` seems unnecessary as the function has no side-effects. Loading history...
34			add_filter('timber_context', [$this, 'context']);
			0 ignored issues – show Unused Code introduced 2015-11-21 16:59 UTC by Report Bug Copy Issue Report The call to the function `add_filter()` seems unnecessary as the function has no side-effects. Loading history...
35			}
36
37			/**
38			* All about ACF configuration should be instantiated here.
39			*/
40			protected function acf()
41			{
42			new Wysiwyg([
43			'lin3s' => [1 => ['bold', 'italic', 'bullist', 'numlist', 'link', 'unlink']],
44			]);
45			}
46
47			/**
48			* Filters the selectable templates.
49			*/
50			private function templateSelector()
51			{
52			$self = $this;
53			add_filter('theme_page_templates', function () use ($self) {
			0 ignored issues – show Unused Code introduced 2016-05-20 08:48 UTC by Report Bug Copy Issue Report The call to the function `add_filter()` seems unnecessary as the function has no side-effects. Loading history...
54			return $self->templates([]);
55			});
56			}
57
58			/**
59			* Enables or disables XML-RPC feature.
60			*/
61			private function xmlrpc()
62			{
63			$xmlrpc = !defined('XMLRPC_ENABLED') \|\| XMLRPC_ENABLED === true
64			? '__return_true'
65			: '__return_false';
66			add_filter('xmlrpc_enabled', $xmlrpc);
			0 ignored issues – show Unused Code introduced 2016-06-01 07:15 UTC by Report Bug Copy Issue Report The call to the function `add_filter()` seems unnecessary as the function has no side-effects. Loading history...
67			}
68			}
69

LIN3S / WPFoundation

Push — master ( f5cd5b...d3cd2b )

Theme::xmlrpc() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like