Theme::xmlrpc() - Code Metrics - Inspection of "Decoupled ACF logic from Theme" - LIN3S/WPFoundation - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#11)

by Beñat

created 2016-06-01 08:17 UTC

Theme::xmlrpc() A

↳ Parent: Project

Complexity

Conditions	3
Paths	4

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	7
rs	9.4285
cc	3
eloc	5
nc	4
nop	0

<?php

/*
 * This file is part of the WPFoundation library.
 *
 * Copyright (c) 2015-2016 LIN3S <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace LIN3S\WPFoundation\Configuration\Theme;

/**
 * Abstract class of theme that implements the interface.
 * This class avoids the use of callbacks in the constructor.
 *
 * @author Beñat Espiña <[email protected]>
 */
abstract class Theme implements ThemeInterface
{
    /**
     * Constructor.
     */
    public function __construct()
    {
        $this->classes();
        $this->templateSelector();
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
        add_theme_support('post-thumbnails');

        add_filter('timber_context', [$this, 'context']);


        // @deprecated since version 1.6, will be removed in 2.0. Extend the ACF class in your project and instantiate
        // inside your project Theme.
        $this->acf();
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
    }

    /**
     * Filters the selectable templates.
     */
    private function templateSelector()
    {
        $self = $this;
        add_filter('theme_page_templates', function () use ($self) {

            return $self->templates([]);
        });
    }

    /**
     * @deprecated since version 1.6, will be removed in 2.0. Extend the ACF class in your project and instantiate
     *             inside your project Theme.
     */
    protected function acf()
    {
        $customToolbars = [
            'lin3s' => [1 => ['bold', 'italic', 'bullist', 'numlist', 'link', 'unlink']],
        ];

        add_filter('acf/fields/wysiwyg/toolbars', function (array $toolbars) use ($customToolbars) {

            return array_merge($toolbars, $customToolbars);
        });
    }
}


1			<?php
2
3			/*
4			* This file is part of the WPFoundation library.
5			*
6			* Copyright (c) 2015-2016 LIN3S <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace LIN3S\WPFoundation\Configuration\Theme;
13
14			/**
15			* Abstract class of theme that implements the interface.
16			* This class avoids the use of callbacks in the constructor.
17			*
18			* @author Beñat Espiña <[email protected]>
19			*/
20			abstract class Theme implements ThemeInterface
21			{
22			/**
23			* Constructor.
24			*/
25			public function __construct()
26			{
27			$this->classes();
28			$this->templateSelector();
			0 ignored issues – show Unused Code introduced 2016-05-20 08:48 UTC by Report Bug Copy Issue Report The call to the method `LIN3S\WPFoundation\Confi...eme::templateSelector()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
29			add_theme_support('post-thumbnails');
			0 ignored issues – show Unused Code introduced 2015-11-21 16:59 UTC by Report Bug Copy Issue Report The call to the function `add_theme_support()` seems unnecessary as the function has no side-effects. Loading history...
30			add_filter('timber_context', [$this, 'context']);
			0 ignored issues – show Unused Code introduced 2015-11-21 16:59 UTC by Report Bug Copy Issue Report The call to the function `add_filter()` seems unnecessary as the function has no side-effects. Loading history...
31
32			// @deprecated since version 1.6, will be removed in 2.0. Extend the ACF class in your project and instantiate
33			// inside your project Theme.
34			$this->acf();
			0 ignored issues – show Deprecated Code introduced 2016-06-01 08:20 UTC by Report Bug Copy Issue Report The method `LIN3S\WPFoundation\Confi...tion\Theme\Theme::acf()` has been deprecated with message: since version 1.6, will be removed in 2.0. Extend the ACF class in your project and instantiate inside your project Theme. This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history... Unused Code introduced 2016-06-01 08:20 UTC by Report Bug Copy Issue Report The call to the method `LIN3S\WPFoundation\Confi...tion\Theme\Theme::acf()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
35			}
36
37			/**
38			* Filters the selectable templates.
39			*/
40			private function templateSelector()
41			{
42			$self = $this;
43			add_filter('theme_page_templates', function () use ($self) {
			0 ignored issues – show Unused Code introduced 2016-05-20 08:48 UTC by Report Bug Copy Issue Report The call to the function `add_filter()` seems unnecessary as the function has no side-effects. Loading history...
44			return $self->templates([]);
45			});
46			}
47
48			/**
49			* @deprecated since version 1.6, will be removed in 2.0. Extend the ACF class in your project and instantiate
50			* inside your project Theme.
51			*/
52			protected function acf()
53			{
54			$customToolbars = [
55			'lin3s' => [1 => ['bold', 'italic', 'bullist', 'numlist', 'link', 'unlink']],
56			];
57
58			add_filter('acf/fields/wysiwyg/toolbars', function (array $toolbars) use ($customToolbars) {
			0 ignored issues – show Unused Code introduced 2016-06-01 08:20 UTC by Report Bug Copy Issue Report The call to the function `add_filter()` seems unnecessary as the function has no side-effects. Loading history...
59			return array_merge($toolbars, $customToolbars);
60			});
61			}
62			}
63

LIN3S / WPFoundation

Pull Request — master (#11)

Theme::xmlrpc() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like