DomainEventPublisher - Code Metrics - Inspection of "Added DomainEventPublisher and added Tactician mid..." - LIN3S/SharedKernel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3beeb1...c0c19b )

by Beñat

created 2017-09-18 10:47 UTC

DomainEventPublisher A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	1

Importance

Changes

Metric	Value
wmc	9
lcom	2
cbo	1
dl	0
loc	50
rs	10
c	0
b	0
f	0

6 Methods

Rating	Name	Size	Complexity
A	instance()	8	2
A	__construct()	5	1
A	__clone()	4	1
A	subscribe()	8	1
A	unsubscribe()	4	1
A	publish()	8	3

<?php

/*
 * This file is part of the Shared Kernel library.
 *
 * Copyright (c) 2016-present LIN3S <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace LIN3S\SharedKernel\Domain\Event;

use LIN3S\SharedKernel\Domain\Model\DomainEvent;

/**
 * @author Beñat Espiña <[email protected]>
 */
class DomainEventPublisher

{
    private static $instance;

    private $subscribers;
    private $id;

    public static function instance()
    {
        if (null === static::$instance) {
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
            static::$instance = new self();
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
        }

        return static::$instance;
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
    }

    private function __construct()
    {
        $this->subscribers = [];
        $this->id = 0;
    }

    public function __clone()
    {
        throw new DomainEventPublisherCloningIsNotAllowed();
    }

    public function subscribe(DomainEventSubscriber $domainEventSubscriber)
    {
        $id = $this->id;
        $this->subscribers[$id] = $domainEventSubscriber;
        $this->id++;

        return $id;
    }

    public function unsubscribe($id)
    {
        unset($this->subscribers[$id]);
    }

    public function publish(DomainEvent $domainEvent)
    {
        foreach ($this->subscribers as $aSubscriber) {
            if ($aSubscriber->isSubscribedTo($domainEvent)) {
                $aSubscriber->handle($domainEvent);
            }
        }
    }
}


1			<?php
2
3			/*
4			* This file is part of the Shared Kernel library.
5			*
6			* Copyright (c) 2016-present LIN3S <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace LIN3S\SharedKernel\Domain\Event;
13
14			use LIN3S\SharedKernel\Domain\Model\DomainEvent;
15
16			/**
17			* @author Beñat Espiña <[email protected]>
18			*/
19			class DomainEventPublisher
			0 ignored issues – show Coding Style introduced 2017-09-18 10:49 UTC by Report Bug Copy Issue Report Since you have declared the constructor as private, maybe you should also declare the class as final. Loading history...
20			{
21			private static $instance;
22
23			private $subscribers;
24			private $id;
25
26			public static function instance()
27			{
28			if (null === static::$instance) {
			0 ignored issues – show Bug introduced 2017-09-18 10:49 UTC by Report Bug Copy Issue Report Since `$instance` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$instance` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
29			static::$instance = new self();
			0 ignored issues – show Bug introduced 2017-09-18 10:49 UTC by Report Bug Copy Issue Report Since `$instance` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$instance` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
30			}
31
32			return static::$instance;
			0 ignored issues – show Bug introduced 2017-09-18 10:49 UTC by Report Bug Copy Issue Report Since `$instance` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$instance` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
33			}
34
35			private function __construct()
36			{
37			$this->subscribers = [];
38			$this->id = 0;
39			}
40
41			public function __clone()
42			{
43			throw new DomainEventPublisherCloningIsNotAllowed();
44			}
45
46			public function subscribe(DomainEventSubscriber $domainEventSubscriber)
47			{
48			$id = $this->id;
49			$this->subscribers[$id] = $domainEventSubscriber;
50			$this->id++;
51
52			return $id;
53			}
54
55			public function unsubscribe($id)
56			{
57			unset($this->subscribers[$id]);
58			}
59
60			public function publish(DomainEvent $domainEvent)
61			{
62			foreach ($this->subscribers as $aSubscriber) {
63			if ($aSubscriber->isSubscribedTo($domainEvent)) {
64			$aSubscriber->handle($domainEvent);
65			}
66			}
67			}
68			}
69

LIN3S / SharedKernel

Push — master ( 3beeb1...c0c19b )

DomainEventPublisher A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

6 Methods

Duplication Side-by-Side

Filter issues like