GetEvents::__invoke() - Code Metrics - Inspection of "Made work the stored event's payload denormalizati..." - LIN3S/SharedKernel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4be545...15ae11 )

by Beñat

created 2017-09-21 22:03 UTC

GetEvents::__invoke() A

↳ Parent: GetEvents

Complexity

Conditions	1
Paths	1

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	14
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	8
nc	1
nop	1

<?php

/*
 * This file is part of the Shared Kernel library.
 *
 * Copyright (c) 2016-present LIN3S <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace LIN3S\SharedKernel\Application\Event;

use LIN3S\SharedKernel\Event\EventStore;

/**
 * @author Beñat Espiña <[email protected]>
 */
class GetEvents
{
    private $eventStore;

    public function __construct(EventStore $eventStore)
    {
        $this->eventStore = $eventStore;
    }

    public function __invoke(GetEventsQuery $query) : array
    {
        $page = $query->page();
        $pageSize = $query->pageSize();
        $since = $query->since();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $offset = ($page - 1) * $pageSize;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        return ['data' => ['lala' => 'lalala']];

        $events = $this->eventStore->eventsSince($since, $offset, $pageSize);
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}

        return $this->response->build($events, $page, $pageSize);
    }
}


1			<?php
2
3			/*
4			* This file is part of the Shared Kernel library.
5			*
6			* Copyright (c) 2016-present LIN3S <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			declare(strict_types=1);
13
14			namespace LIN3S\SharedKernel\Application\Event;
15
16			use LIN3S\SharedKernel\Event\EventStore;
17
18			/**
19			* @author Beñat Espiña <[email protected]>
20			*/
21			class GetEvents
22			{
23			private $eventStore;
24
25			public function __construct(EventStore $eventStore)
26			{
27			$this->eventStore = $eventStore;
28			}
29
30			public function __invoke(GetEventsQuery $query) : array
31			{
32			$page = $query->page();
33			$pageSize = $query->pageSize();
34			$since = $query->since();
			0 ignored issues – show Unused Code introduced 2017-09-21 22:05 UTC by Report Bug Copy Issue Report `$since` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
35
36			$offset = ($page - 1) * $pageSize;
			0 ignored issues – show Unused Code introduced 2017-09-21 22:05 UTC by Report Bug Copy Issue Report `$offset` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
37
38			return ['data' => ['lala' => 'lalala']];
39
40			$events = $this->eventStore->eventsSince($since, $offset, $pageSize);
			0 ignored issues – show Unused Code introduced 2017-09-21 22:05 UTC by Report Bug Copy Issue Report `$events = $this->eventSt...e, $offset, $pageSize);` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
41
42			return $this->response->build($events, $page, $pageSize);
43			}
44			}
45

LIN3S / SharedKernel

Push — master ( 4be545...15ae11 )

GetEvents::__invoke() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like