| Conditions | 9 |
| Paths | 9 |
| Total Lines | 87 |
| Code Lines | 63 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 48 | public function trigger(string $name, $data = [], $sender = null): void |
||
| 49 | { |
||
| 50 | switch ($name) |
||
| 51 | { |
||
| 52 | case 'addonxml.created': |
||
| 53 | array_walk($this->languageGenerators, function($generator) use ($data) { |
||
| 54 | $generator |
||
| 55 | ->create() |
||
| 56 | ->addLangvar( |
||
| 57 | LanguageGenerator::getTranslationKey( |
||
| 58 | LangvarTypes::$ADDONS, |
||
| 59 | 'name', |
||
| 60 | $data['addon.id'] |
||
| 61 | ), |
||
| 62 | parse_to_readable($data['addon.id']) |
||
| 63 | ) |
||
| 64 | ->addLangvar( |
||
| 65 | LanguageGenerator::getTranslationKey( |
||
| 66 | LangvarTypes::$ADDONS, |
||
| 67 | 'description', |
||
| 68 | $data['addon.id'] |
||
| 69 | ), |
||
| 70 | parse_to_readable($data['addon.id']) |
||
| 71 | ); |
||
| 72 | }); |
||
| 73 | break; |
||
| 74 | case 'addonxml.setting.updated': |
||
| 75 | case 'addonxml.setting.added': |
||
| 76 | |||
| 77 | array_walk($this->languageGenerators, function($generator) use ($data) { |
||
| 78 | $generator |
||
| 79 | ->removeById($data['id']) |
||
| 80 | ->replaceLangvar( |
||
| 81 | LanguageGenerator::getTranslationKey( |
||
| 82 | LangvarTypes::$SETTINGS_OPTIONS, |
||
| 83 | $data['addon.id'], |
||
| 84 | $data['id'] |
||
| 85 | ), |
||
| 86 | parse_to_readable($data['id']) |
||
| 87 | ) |
||
| 88 | ->replaceLangvar( |
||
| 89 | LanguageGenerator::getTranslationKey( |
||
| 90 | LangvarTypes::$SETTINGS_TOOLTIPS, |
||
| 91 | $data['addon.id'], |
||
| 92 | $data['id'] |
||
| 93 | ), |
||
| 94 | parse_to_readable($data['id']) |
||
| 95 | ); |
||
| 96 | }); |
||
| 97 | if (!empty($data['variants'])) { |
||
| 98 | foreach($data['variants'] as $variation) { |
||
| 99 | array_walk($this->languageGenerators, function($generator) use ($data, $variation) { |
||
| 100 | $generator |
||
| 101 | ->replaceLangvar( |
||
| 102 | LanguageGenerator::getTranslationKey( |
||
| 103 | LangvarTypes::$SETTINGS_VARIANTS, |
||
| 104 | $data['addon.id'], |
||
| 105 | $data['id'], |
||
| 106 | $variation |
||
| 107 | ), |
||
| 108 | parse_to_readable($variation) |
||
| 109 | ); |
||
| 110 | }); |
||
| 111 | } |
||
| 112 | } |
||
| 113 | |||
| 114 | break; |
||
| 115 | case 'addonxml.setting.removed': |
||
| 116 | array_walk($this->languageGenerators, function($generator) use ($data) { |
||
| 117 | $generator |
||
| 118 | ->removeById($data['id']); |
||
| 119 | }); |
||
| 120 | break; |
||
| 121 | case 'addonxml.settingSection.added': |
||
| 122 | case 'addonxml.settingSection.updated': |
||
| 123 | array_walk($this->languageGenerators, function($generator) use ($data) { |
||
| 124 | $generator |
||
| 125 | ->replaceLangvar( |
||
| 126 | LanguageGenerator::getTranslationKey( |
||
| 127 | LangvarTypes::$SETTINGS_SECTIONS, |
||
| 128 | $data['addon.id'], |
||
| 129 | $data['id'] |
||
| 130 | ), |
||
| 131 | parse_to_readable($data['id']) |
||
| 132 | ); |
||
| 133 | }); |
||
| 134 | break; |
||
| 135 | } |
||
| 138 |