| Conditions | 9 |
| Paths | 9 |
| Total Lines | 78 |
| Code Lines | 58 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 63 | public function trigger(string $name, $data = [], $sender = null): void |
||
| 64 | { |
||
| 65 | switch ($name) |
||
| 66 | { |
||
| 67 | case 'addonxml.created': |
||
| 68 | $this->languageGenerator |
||
| 69 | ->create() |
||
| 70 | ->addLangvar( |
||
| 71 | LanguageGenerator::getTranslationKey( |
||
| 72 | LangvarTypes::$ADDONS, |
||
| 73 | 'name', |
||
| 74 | $data['addon.id'] |
||
| 75 | ), |
||
| 76 | parse_to_readable($data['addon.id']) |
||
| 77 | ) |
||
| 78 | ->addLangvar( |
||
| 79 | LanguageGenerator::getTranslationKey( |
||
| 80 | LangvarTypes::$ADDONS, |
||
| 81 | 'description', |
||
| 82 | $data['addon.id'] |
||
| 83 | ), |
||
| 84 | parse_to_readable($data['addon.id']) |
||
| 85 | ); |
||
| 86 | break; |
||
| 87 | case 'addonxml.setting.updated': |
||
| 88 | case 'addonxml.setting.added': |
||
| 89 | |||
| 90 | $this->languageGenerator |
||
| 91 | ->removeById($data['id']) |
||
| 92 | ->replaceLangvar( |
||
| 93 | LanguageGenerator::getTranslationKey( |
||
| 94 | LangvarTypes::$SETTINGS_OPTIONS, |
||
| 95 | $data['addon.id'], |
||
| 96 | $data['id'] |
||
| 97 | ), |
||
| 98 | parse_to_readable($data['id']) |
||
| 99 | ) |
||
| 100 | ->replaceLangvar( |
||
| 101 | LanguageGenerator::getTranslationKey( |
||
| 102 | LangvarTypes::$SETTINGS_TOOLTIPS, |
||
| 103 | $data['addon.id'], |
||
| 104 | $data['id'] |
||
| 105 | ), |
||
| 106 | parse_to_readable($data['id']) |
||
| 107 | ); |
||
| 108 | |||
| 109 | if (!empty($data['variants'])) { |
||
| 110 | foreach($data['variants'] as $variation) { |
||
| 111 | $this->languageGenerator |
||
| 112 | ->replaceLangvar( |
||
| 113 | LanguageGenerator::getTranslationKey( |
||
| 114 | LangvarTypes::$SETTINGS_VARIANTS, |
||
| 115 | $data['addon.id'], |
||
| 116 | $data['id'], |
||
| 117 | $variation |
||
| 118 | ), |
||
| 119 | parse_to_readable($variation) |
||
| 120 | ); |
||
| 121 | } |
||
| 122 | } |
||
| 123 | |||
| 124 | break; |
||
| 125 | case 'addonxml.setting.removed': |
||
| 126 | $this->languageGenerator |
||
| 127 | ->removeById($data['id']); |
||
| 128 | break; |
||
| 129 | case 'addonxml.settingSection.added': |
||
| 130 | case 'addonxml.settingSection.updated': |
||
| 131 | $this->languageGenerator |
||
| 132 | ->replaceLangvar( |
||
| 133 | LanguageGenerator::getTranslationKey( |
||
| 134 | LangvarTypes::$SETTINGS_SECTIONS, |
||
| 135 | $data['addon.id'], |
||
| 136 | $data['id'] |
||
| 137 | ), |
||
| 138 | parse_to_readable($data['id']) |
||
| 139 | ); |
||
| 140 | break; |
||
| 141 | } |
||
| 144 |