TranslatedTrait - Code Metrics - Inspection of "Add getter and setter for $language and $sourceLan..." - LAV45/yii2-translated-behavior - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 91230c...08a41f )

by Loban

created 2016-07-29 01:43 UTC

TranslatedTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes	5
Bugs	2	Features	0

Metric	Value
wmc	4
c	5
b	2
f	0
lcom	0
cbo	0
dl	0
loc	35
ccs	10
cts	10
cp	1
rs	10

3 Methods

Rating	Name	Size	Complexity
A	hasTranslate()	4	1
A	transactions()	6	1
A	isAttributeChanged()	8	2

<?php
/**
 * @link https://github.com/LAV45/yii2-translated-behavior
 * @copyright Copyright (c) 2015 LAV45!
 * @author Alexey Loban <[email protected]>
 * @license http://opensource.org/licenses/BSD-3-Clause
 */

namespace lav45\translate;

use yii\db\ActiveRecord;

/**
 * Class TranslatedTrait
 * @package lav45\translate
 *
 * @mixin TranslatedBehavior
 */
trait TranslatedTrait
{
    public function transactions()
    {
        return [
            ActiveRecord::SCENARIO_DEFAULT => ActiveRecord::OP_ALL,
        ];
    }

    /**
     * @param string $language
     * @return bool
     */
    public function hasTranslate($language)
    {
        return isset($this['hasTranslate'][$language]);
    }

    /**
     * Returns a value indicating whether the named attribute has been changed
     * or attribute has been changed in translation relation model.
     * @param string $name the name of the attribute.
     * @param boolean $identical whether the comparison of new and old value is made for
     * identical values using `===`, defaults to `true`. Otherwise `==` is used for comparison.
     * @return boolean whether the attribute has been changed
     */
    public function isAttributeChanged($name, $identical = true)
    {
        if (parent::isAttributeChanged($name, $identical) === true) {
            return true;
        }
        $attributeName = $this->getTranslateAttributeName($name);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        return $this->getTranslation()->isAttributeChanged($attributeName, $identical);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}

1		<?php
2		/**
3		* @link https://github.com/LAV45/yii2-translated-behavior
4		* @copyright Copyright (c) 2015 LAV45!
5		* @author Alexey Loban <[email protected]>
6		* @license http://opensource.org/licenses/BSD-3-Clause
7		*/
8
9		namespace lav45\translate;
10
11		use yii\db\ActiveRecord;
12
13		/**
14		* Class TranslatedTrait
15		* @package lav45\translate
16		*
17		* @mixin TranslatedBehavior
18		*/
19		trait TranslatedTrait
20		{
21	4	public function transactions()
22		{
23		return [
24	4	ActiveRecord::SCENARIO_DEFAULT => ActiveRecord::OP_ALL,
25	4	];
26		}
27
28		/**
29		* @param string $language
30		* @return bool
31		*/
32	2	public function hasTranslate($language)
33		{
34	2	return isset($this['hasTranslate'][$language]);
35		}
36
37		/**
38		* Returns a value indicating whether the named attribute has been changed
39		* or attribute has been changed in translation relation model.
40		* @param string $name the name of the attribute.
41		* @param boolean $identical whether the comparison of new and old value is made for
42		* identical values using `===`, defaults to `true`. Otherwise `==` is used for comparison.
43		* @return boolean whether the attribute has been changed
44		*/
45	1	public function isAttributeChanged($name, $identical = true)
46		{
47	1	if (parent::isAttributeChanged($name, $identical) === true) {
48	1	return true;
49		}
50	1	$attributeName = $this->getTranslateAttributeName($name);
		0 ignored issues – show Bug introduced 2016-02-27 01:46 UTC by Report Bug Copy Issue Report It seems like `getTranslateAttributeName()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
51	1	return $this->getTranslation()->isAttributeChanged($attributeName, $identical);
		0 ignored issues – show Bug introduced 2016-02-27 01:46 UTC by Report Bug Copy Issue Report It seems like `getTranslation()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
52		}
53		}

LAV45 / yii2-translated-behavior

Push — master ( 91230c...08a41f )

TranslatedTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

3 Methods

Duplication Side-by-Side

Filter issues like