PhpFileStorage::getValue() - Code Metrics - Inspection of "Add PhpFileStorage" - LAV45/yii2-settings - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 68b501...8e644d )

by Loban

created 2017-03-11 23:58 UTC

PhpFileStorage::getValue() A

↳ Parent: PhpFileStorage

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	8
ccs	5
cts	5
cp	1
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	5
nc	2
nop	1
crap	2

<?php
/**
 * @link https://github.com/LAV45/yii2-settings
 * @copyright Copyright (c) 2016 LAV45
 * @author Alexey Loban <[email protected]>
 * @license http://opensource.org/licenses/BSD-3-Clause
 */

namespace lav45\settings\storage;

use yii\helpers\VarDumper;

class PhpFileStorage extends FileStorage
{
    /**
     * @var string settings file suffix. Defaults to '.php'.
     */
    public $fileSuffix = '.php';

    /**
     * @param string $key
     * @return mixed
     */
    public function getValue($key)
    {
        $file = $this->getFile($key);
        if (file_exists($file)) {
            return include $file;
        }
        return false;
    }

    /**
     * @param string $key
     * @param mixed $value
     * @return bool
     */
    public function setValue($key, $value)
    {
        $value = is_string($value) ? "'{$value}'" : VarDumper::export($value);
        $value = "<?php\nreturn {$value};\n";

        $result = parent::setValue($key, $value);

        if (function_exists('opcache_compile_file') && ini_get('opcache.enable')) {
            $file = $this->getFile($key);
            @opcache_compile_file($file);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
        }

        return $result;
    }
}

1		<?php
2		/**
3		* @link https://github.com/LAV45/yii2-settings
4		* @copyright Copyright (c) 2016 LAV45
5		* @author Alexey Loban <[email protected]>
6		* @license http://opensource.org/licenses/BSD-3-Clause
7		*/
8
9		namespace lav45\settings\storage;
10
11		use yii\helpers\VarDumper;
12
13		class PhpFileStorage extends FileStorage
14		{
15		/**
16		* @var string settings file suffix. Defaults to '.php'.
17		*/
18		public $fileSuffix = '.php';
19
20		/**
21		* @param string $key
22		* @return mixed
23		*/
24	3	public function getValue($key)
25		{
26	3	$file = $this->getFile($key);
27	3	if (file_exists($file)) {
28	3	return include $file;
29		}
30	3	return false;
31		}
32
33		/**
34		* @param string $key
35		* @param mixed $value
36		* @return bool
37		*/
38	3	public function setValue($key, $value)
39		{
40	3	$value = is_string($value) ? "'{$value}'" : VarDumper::export($value);
41	3	$value = "<?php\nreturn {$value};\n";
42
43	3	$result = parent::setValue($key, $value);
44
45	3	if (function_exists('opcache_compile_file') && ini_get('opcache.enable')) {
46		$file = $this->getFile($key);
47		@opcache_compile_file($file);
		1 ignored issue – show Security Best Practice introduced 2017-03-12 00:00 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
48		}
49
50	3	return $result;
51		}
52		}

LAV45 / yii2-settings

Push — master ( 68b501...8e644d )

PhpFileStorage::getValue() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like