Issues in Bootstrap3Form.php (master) - Issues in master - Kylob/BootPress - Measure and Improve Code Quality continuously with Scrutinizer

Issues (164)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Bootstrap/Bootstrap3Form.php (6 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace BootPress\Bootstrap;

use BootPress\Form\Component as Form;

class Bootstrap3Form extends Form
{
    use Base;
    
    private $bp;
    private $prompt = array(
        'info' => 'glyphicon glyphicon-question-sign',
    );
    private $input = '';
    private $align = 'form-horizontal';
    private $collapse = 'sm';
    private $indent = 2;
    
    /**
     * {@inheritdoc}
     */
    public function __construct($name = 'form', $method = 'post', Bootstrap3 $bp)
    {
        parent::__construct($name, $method = 'post');
        $this->bp = $bp;
    }
    
    /**
     * A private property getter.
     * 
     * @param string $name 
     * 
     * @return null|string
     */
    public function __get($name)
    {
        switch ($name) {
            case 'prompt':
            case 'input':
            case 'align':
            case 'collapse':
            case 'indent':
                return $this->$name;
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        }
    }
    /**
     * This is to add html tags, or semicolons, or asterisks, or whatever you would like to all of the form's prompts.
     * 
     * @param string      $place    Either '**info**', '**append**', or '**prepend**' to the prompt.  You only have one shot at each.
     * @param string      $html     Whatever you would like to add.  For 'info', this will be the icon class you want to use.
     * @param false|mixed $required If this is anything but (bool) false and $place == 'prepend', the the $html will only be prepended if the field is required per the ``$form->validator``.
     * 
     * ```php
$form->prompt('prepend', '<font color="red">*</font> ', 'required'); // If the field is required it will add a red asterisk to the front.

$form->prompt('append', ':'); // Adds a semicolon to all of the prompts.
     * ```
     */
    public function prompt($place, $html, $required = false)
    {
        switch ($place) {
            case 'info':
            case 'append':
                $this->prompt[$place] = $html;
                break;
            case 'prepend':
                $this->prompt['prepend'] = array('html'=>$html, 'required'=>(bool) $required);
                break;
        }
    }
    
    /**
     * Supersize or undersize your input fields.
     * 
     * @param string $input Either '**lg**' (large), '**md**' (medium - the default), or '**sm**' (small).
     * 
     * ```php
     * $form->size('lg');
     * ```
     */
    public function size($input)
    {
        $this->input = (in_array($input, array('lg', 'sm'))) ? 'input-'.$input : '';
    }

    /**
     * Utilize any Bootstrap form style
     * 
     * @param string  $direction The options are:
     *
     * - '**collapse**' - This will display the form prompt immediately above the field.
     * - '**inline**' - All of the fields will be inline with each other, and the form prompts will be removed.
     * - '**horizontal**' - Vertically aligns all of the fields with the prompt immediately preceding, and right aligned.
     * 
     * @param string  $collapse  Either '**xs**', '**sm**', '**md**', or '**lg**'.  This is the breaking point so to speak for a '**horizontal**' form.  It is the device size on which the form will '**collapse**'.
     * @param integer $indent    The number of columns (up to 12) that you would like to indent the field in a '**horizontal**' form.
     * 
     * ```php
     * $form->align('collapse');
     * ```
     */
    public function align($direction = 'horizontal', $collapse = 'sm', $indent = 2)
    {
        if ($direction == 'collapse') {
            $this->align = '';
        } elseif ($direction == 'inline') {
            $this->align = 'form-inline';
        } else {
            $this->align = 'form-horizontal';
            $this->collapse = (in_array($collapse, array('xs', 'sm', 'md', 'lg'))) ? $collapse : 'sm';
            $this->indent = (is_numeric($indent) && $indent > 0 && $indent < 12) ? $indent : 2;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        }
    }
    
    /**
     * Use to display a message on the retrun trip after you have ``$page->eject()``ed them.  The Bootstrap alert status message will be displayed at the top of the form when you return ``$form->header()``.
     * 
     * @param string $status   Either '**success**', '**info**', '**warning**', or '**danger**'.  If this is '**html**', then the $message will be delivered as is.
     * @param string $message  The message you would like to get across to your user.  ``<h1-6>`` headers and ``<a>`` links may be used.
     * 
     * ```php
     * if ($vars = $form->validator->certified()) {
     *     $form->message('success', 'Good job, you are doing great!');
     *     $page->eject($form->eject);
     * }
     * ```
     */
    public function message($status, $message)
    {
        $this->page->session->getFlashBag()->add($this->header['name'], array(
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            'status' => $status,
            'msg' => $message,
        ));
    }
    
    /**
     * {@inheritdoc}
     */
    public function header(array $validate = array())
    {
        $this->validator->jquery('form[name='.$this->header['name'].']', array_merge(array(
            'ignore' => '[]',
            'errorClass' => '"has-error"',
            'validClass' => '""',
            'errorElement' => '"span"',
            'highlight' => 'function(element, errorClass, validClass){ $(element).closest("div.form-group").addClass(errorClass).removeClass(validClass).find("p.validation").show(); }',
            'unhighlight' => 'function(element, errorClass, validClass){ $(element).closest("div.form-group").removeClass(errorClass).addClass(validClass).find("p.validation").text("").hide(); }',
            'errorPlacement' => 'function(error, element){ $(element).closest("div.form-group").find("p.validation").html(error); }',
            'submitHandler' => 'function(form, event){ event.preventDefault(); $(form).find("button[type=submit]").button("loading"); form.submit(); }',
            'onkeyup' => 'false',
        ), $validate));
        $html = "\n";
        if ($this->align == 'form-horizontal') {
            $html .= '<div class="row"><div class="col-'.$this->collapse.'-12">';
        }
        if ($flash = $this->page->session->getFlashBag()->get($this->header['name'])) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $html .= ($flash[0]['status'] == 'html') ? $flash[0]['msg'] : $this->bp->alert($flash[0]['status'], $flash[0]['msg']);
        }
        $html .= trim(parent::header());
        if (!empty($this->align)) {
            $html = $this->addClass($html, array('form' => $this->align));
        }

        return $html;
    }

    /**
     * {@inheritdoc}
     * 
     * @param false|mixed $inline This tells us if you want the checkboxes to be inline (any value but false), or not (false).
     */
    public function checkbox($field, array $attributes = array(), $inline = false)
    {
        $disabled = in_array('disabled', $attributes) ? 'disabled' : '';
        if ($inline !== false) {
            $wrap = $this->page->tag('label', array('class' => array('checkbox-inline', $this->input, $disabled)), '%s');
        } else {
            $wrap = $this->page->tag('div', array('class' => array('checkbox', $this->input, $disabled)), '<label>%s</label>');
        }

        return parent::checkbox($field, $attributes, $wrap);
    }

    /**
     * {@inheritdoc}
     * 
     * @param false|mixed $inline This tells us if you want the radio buttons to be inline (any value but false), or not (false).
     */
    public function radio($field, array $attributes = array(), $inline = false)
    {
        $disabled = in_array('disabled', $attributes) ? 'disabled' : '';
        if ($inline !== false) {
            $wrap = $this->page->tag('label', array('class' => array('radio-inline', $this->input, $disabled)), '%s');
        } else {
            $wrap = $this->page->tag('div', array('class' => array('radio', $this->input, $disabled)), '<label>%s</label>');
        }

        return parent::radio($field, $attributes, $wrap);
    }

    /**
     * Group an input field with addons.  You can prepend and/or append a ``$bp->button(...)``, ``$bp->icon('...')``, or just a string of text.  To prepend or append multiple elements, then make it an ``array($html, ...)`` of addons.
     * 
     * @param string|array $prepend An element to place before the $input.
     * @param string|array $append  An element to place after the $input.
     * @param string $input   The form field to wrap.    
     * 
     * @return string A ``<div class="input-group">...</div>`` html string.
     * 
     * ```php
     * echo $form->group('$', '.00', $form->text('amount'));
     * ```
     */
    public function group($prepend, $append, $input)
    {
        if (!empty($prepend)) {
            foreach ((array) $prepend as $html) {
                $class = (strpos($html, 'btn') !== false) ? 'input-group-btn' : 'input-group-addon';
                $input = $this->page->tag('div', array('class' => $class), $html).$input;
            }
        }
        if (!empty($append)) {
            foreach ((array) $append as $html) {
                $class = (strpos($html, 'btn') !== false) ? 'input-group-btn' : 'input-group-addon';
                $input = $input.$this->page->tag('div', array('class' => $class), $html);
            }
        }
        $group = array('input-group');
        if (!empty($this->input)) {
            $group[] = str_replace('-', '-group-', $this->input);
        }

        return $this->page->tag('div', array('class' => $group), $input);
    }
    
    /**
     * This is to add html tags, or semicolons, or asterisks, or whatever you would like include with all of the form's prompts.
     * 
     * @param string|array $prompt  The form label reference.  If you want to include additional information relative to the field, then you can make this an ``array($prompt => $info)``, or an ``array($prompt, $info)`` that will appear when cliked or hovered over.  To customize the icon set ``$form->prompt('info', 'fa fa-info-circle')``.
     * @param string       $name    The name of the associated input field.
     * @param string       $id      The id of the associated input field.
     * 
     * @return string  The generated HTML ``<label>``.
     */
    public function label($prompt, $name, $id)
    {
        if (empty($prompt)) {
            return '';
        }
        if (is_array($prompt)) {
            list($prompt, $info) = (count($prompt) > 1) ? array_values($prompt) : each($prompt);
        }
        if (empty($prompt) || strpos($prompt, '<label') !== false) {
            return $prompt;
        }
        if (isset($this->prompt['prepend'])) {
            if (!$this->prompt['prepend']['required'] || $this->validator->required($name)) {
                $prompt = $this->prompt['prepend']['html'] . $prompt;
            }
        }
        if (isset($this->prompt['append'])) {
            $prompt .= $this->prompt['append'];
        }
        if (isset($info)) {
            $prompt .= ' '.$this->page->tag('i', array(
                'title' => htmlspecialchars($info),
                'class' => $this->prompt['info'],
                'style' => 'cursor:pointer;',
                'data-html' => 'true',
                'data-toggle' => 'tooltip',
                'data-placement' => 'bottom',
                'data-container' => 'form[name='.$this->header['name'].']',
            ), '');
            $this->page->jquery('$(\'[data-toggle="tooltip"]\').tooltip();');
        }
        switch ($this->align) {
            case 'form-inline':
                $class = 'sr-only';
                break;
            case 'form-horizontal':
                $class = array(
                    "col-{$this->collapse}-{$this->indent}",
                    'control-label',
                    $this->input,
                );
                break;
            default:
                $class = $this->input;
                break;
        }
        return $this->page->tag('label', array(
            'class' => $class,
            'for' => $id,
        ), $prompt);
    }

    /**
     * Adds a (properly formatted) $prompt to your $input field, and manages any error messages.
     * 
     * @param string $prompt The $input's name.
     * @param string $input  A form field.
     * @param string $error  An optional error to override, or include with the field.
     * 
     * @return string A ``<div class="form-group">...</div>`` html string.
     * 
     * ```php
     * echo $form->field('Amount', $form->group('$', '.00', $form->text('amount')));
     * ```
     */
    public function field($prompt, $input, $error = null)
    {
        foreach (array('input', 'select', 'textarea', 'button', 'p') as $tag) {
            if ($this->firstTagAttributes($input, $matches, '<'.$tag)) {
                break;
            }
        }
        list($first, $tag, $attributes) = $matches;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        $type = (isset($attributes['type'])) ? $attributes['type'] : '';
        $name = (isset($attributes['name'])) ? $attributes['name'] : '';
        $id = (isset($attributes['id'])) ? $attributes['id'] : '';
        $prompt = $this->label($prompt, $name, $id);
        switch ($tag) {
            case 'input':
            case 'select':
            case 'textarea':
                $input = $this->addClass($input, array('p'=>'help-block'));
                if ($tag != 'input' || !in_array($type, array('checkbox', 'radio', 'file', 'submit', 'reset', 'button'))) {
                    $input = $this->addClass($input, array($tag=>'form-control '.$this->input));
                }
                break;
            case 'p':
                $input = $this->addClass($input, array('p'=>'form-control-static'));
                break;
        }
        $group = array('form-group');
        $msg = (empty($name)) ? null : $this->validator->error($name);
        if (!is_null($error)) {
            $msg = $error; // override all
        }
        if (!empty($msg)) {
            $group[] = 'has-error';
            $error = '<p class="validation help-block">'.$msg.'</p>';
        } elseif (!empty($name)) { // only include this when needed for validation
            $error = '<p class="validation help-block" style="display:none;"></p>';
        }
        if ($this->align == 'form-horizontal') {
            $class = array('col-'.$this->collapse.'-'.(12 - $this->indent));
            if (empty($prompt)) {
                $class[] = 'col-'.$this->collapse.'-offset-'.$this->indent;
            }
            $html = $prompt.$this->page->tag('div', array('class'=>$class), $error.$input);
        } else {
            $html = $prompt.$error.$input;
        }

        return "\n\t".$this->page->tag('div', array('class'=>$group), $html);
    }

    /**
     * Quickly adds a submit button to your form.
     * 
     * @param string $submit What you would like the submit button to say.  If it starts with a '**<**', then we assume you have spelled it all out for us.
     * @param string $reset  This will add a reset button if you give it a value, and if it starts with a '**<**' then it can be whatever you want it to be.  You can keep adding args until you run out of ideas for buttons to include.
     * 
     * @return string A ``<div class="form-group">...</div>`` html string with buttons.
     * 
     * ```php
     * echo $form->submit();
     * ```
     */
    public function submit($submit = 'Submit', $reset = '')
    {
        // never use name="submit" per: http://jqueryvalidation.org/reference/#developing-and-debugging-a-form
        $buttons = func_get_args();
        if (substr($submit, 0, 1) != '<') {
            $buttons[0] = $this->page->tag('button', array(
                'type' => 'submit',
                'class' => array('btn', 'btn-primary', str_replace('input', 'btn', $this->input)),
                'data-loading-text' => 'Submitting...',
            ), $submit);
        }
        if (isset($buttons[1]) && substr($reset, 0, 1) != '<') {
            $buttons[1] = $this->page->tag('button', array(
                'type' => 'reset',
                'class' => array('btn', 'btn-default', str_replace('input', 'btn', $this->input)),
            ), $reset);
        }

        return $this->field('', implode(' ', $buttons));
    }

    /**
     * {@inheritdoc}
     */
    public function close()
    {
        $html = parent::close();
        if ($this->align == 'form-horizontal') {
            $html .= '</div></div>';
        }
        return $html;
    }
}


Issues (164)

Security Analysis not enabled

src/Bootstrap/Bootstrap3Form.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Kylob / BootPress

Issues (164)

Security Analysis not enabled

src/Bootstrap/Bootstrap3Form.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like